All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Salman Qazi <sqazi@google.com>,
	Jesse Barnes <jsbarnes@google.com>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 1/2] block: add blk_default_io_timeout() for avoiding task hung in sync IO
Date: Tue, 28 Apr 2020 07:19:33 -0700	[thread overview]
Message-ID: <7e339c3d-8600-4a9b-99bf-24afb023c4dd@acm.org> (raw)
In-Reply-To: <20200428074657.645441-2-ming.lei@redhat.com>

On 2020-04-28 00:46, Ming Lei wrote:
> +/*
> + * Used in sync IO for avoiding to triger task hung warning, which may
> + * cause system panic or reboot.
> + */
> +static inline unsigned long blk_default_io_timeout(void)
> +{
> +	return sysctl_hung_task_timeout_secs * (HZ / 2);
> +}
> +
>  #endif

This function is only used inside the block layer. Has it been
considered to move this function from the public block layer API into a
private header file, e.g. block/blk.h?

Thanks,

Bart.



  parent reply	other threads:[~2020-04-28 14:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-28  7:46 [PATCH 0/2] block: prevent task hung from being triggered in sync dio Ming Lei
2020-04-28  7:46 ` [PATCH 1/2] block: add blk_default_io_timeout() for avoiding task hung in sync IO Ming Lei
2020-04-28  8:05   ` Hannes Reinecke
2020-04-28  8:30     ` Ming Lei
2020-04-28 14:19   ` Bart Van Assche [this message]
2020-04-29  1:17     ` Ming Lei
2020-04-30  3:08       ` Bart Van Assche
2020-05-03  1:43         ` Ming Lei
2020-04-28  7:46 ` [PATCH 2/2] block: add blk_io_schedule() for avoiding task hung in sync dio Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e339c3d-8600-4a9b-99bf-24afb023c4dd@acm.org \
    --to=bvanassche@acm.org \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=jsbarnes@google.com \
    --cc=linux-block@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=sqazi@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.