All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	Hannes Reinecke <hare@suse.com>,
	Damien Le Moal <damien.lemoal@opensource.wdc.com>,
	Stefan Richter <stefanr@s5r6.in-berlin.de>,
	Steffen Maier <maier@linux.ibm.com>,
	Benjamin Block <bblock@linux.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Adaptec OEM Raid Solutions <aacraid@microsemi.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	Don Brace <don.brace@microchip.com>,
	Brian King <brking@us.ibm.com>,
	Kashyap Desai <kashyap.desai@broadcom.com>,
	Sumit Saxena <sumit.saxena@broadcom.com>,
	Shivasharan S <shivasharan.srikanteshwara@broadcom.com>,
	Sathya Prakash <sathya.prakash@broadcom.com>,
	Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
	Suganath Prabu Subramani  <suganath-prabu.subramani@broadcom.com>,
	Hannes Reinecke <hare@kernel.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	Stanislav Nijnikov <stanislav.nijnikov@wdc.com>
Subject: Re: [PATCH 2/2] scsi: Register SCSI device sysfs attributes earlier
Date: Mon, 27 Sep 2021 10:37:03 -0700	[thread overview]
Message-ID: <7e38336a-cb2d-61fc-b1b8-babb99d74cd3@acm.org> (raw)
In-Reply-To: <YU7l02I/eT3+8410@kroah.com>

On 9/25/21 2:03 AM, Greg Kroah-Hartman wrote:
> On Fri, Sep 24, 2021 at 04:26:35PM -0700, Bart Van Assche wrote:
>> --- a/include/scsi/scsi_device.h
>> +++ b/include/scsi/scsi_device.h
>> @@ -226,6 +226,8 @@ struct scsi_device {
>>   
>>   	struct device		sdev_gendev,
>>   				sdev_dev;
>> +	struct attribute_group  gendev_first_attr_group;
>> +	const struct attribute_group *gendev_attr_groups[6];
> 
> Where does 6 come from?

1 + 4 + 1: one array entry for the SCSI core sysfs attributes, four for the
device driver attributes (this is the current limit) and one entry for the NULL
terminating entry.

>> diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h
>> index 5afdc094a445..aa1207ab9d2e 100644
>> --- a/include/scsi/scsi_host.h
>> +++ b/include/scsi/scsi_host.h
>> @@ -481,7 +481,7 @@ struct scsi_host_template {
>>   	/*
>>   	 * Pointer to the SCSI device properties for this host, NULL terminated.
>>   	 */
>> -	struct device_attribute **sdev_attrs;
>> +	struct attribute **sdev_attrs;
> 
> Same here, "const struct attribute_group **groups;" ?

I will make this change.

Thanks,

Bart.

  reply	other threads:[~2021-09-27 17:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-24 23:26 [PATCH 0/2] Register SCSI sysfs attributes earlier Bart Van Assche
2021-09-24 23:26 ` [PATCH 1/2] scsi: Register SCSI host " Bart Van Assche
2021-09-25  9:02   ` Greg Kroah-Hartman
2021-09-27 17:35     ` Bart Van Assche
2021-09-24 23:26 ` [PATCH 2/2] scsi: Register SCSI device " Bart Van Assche
2021-09-25  9:03   ` Greg Kroah-Hartman
2021-09-27 17:37     ` Bart Van Assche [this message]
2021-09-28  4:48       ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e38336a-cb2d-61fc-b1b8-babb99d74cd3@acm.org \
    --to=bvanassche@acm.org \
    --cc=aacraid@microsemi.com \
    --cc=bblock@linux.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=brking@us.ibm.com \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=don.brace@microchip.com \
    --cc=gor@linux.ibm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hare@kernel.org \
    --cc=hare@suse.com \
    --cc=hca@linux.ibm.com \
    --cc=hch@lst.de \
    --cc=jejb@linux.ibm.com \
    --cc=kashyap.desai@broadcom.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=maier@linux.ibm.com \
    --cc=martin.petersen@oracle.com \
    --cc=sathya.prakash@broadcom.com \
    --cc=shivasharan.srikanteshwara@broadcom.com \
    --cc=sreekanth.reddy@broadcom.com \
    --cc=stanislav.nijnikov@wdc.com \
    --cc=stefanr@s5r6.in-berlin.de \
    --cc=stern@rowland.harvard.edu \
    --cc=suganath-prabu.subramani@broadcom.com \
    --cc=sumit.saxena@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.