From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59029) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsuUY-0008UK-4n for qemu-devel@nongnu.org; Fri, 15 Sep 2017 13:33:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dsuUU-0005LM-3d for qemu-devel@nongnu.org; Fri, 15 Sep 2017 13:33:26 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:37480) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dsuUT-0005Ko-Qt for qemu-devel@nongnu.org; Fri, 15 Sep 2017 13:33:22 -0400 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v8FHUdNv118870 for ; Fri, 15 Sep 2017 13:33:19 -0400 Received: from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108]) by mx0a-001b2d01.pphosted.com with ESMTP id 2d0g7b9uw3-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Fri, 15 Sep 2017 13:33:19 -0400 Received: from localhost by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 15 Sep 2017 18:33:16 +0100 References: <1505092240-10864-1-git-send-email-longpeng2@huawei.com> <2d8ae3d3-438b-da84-4959-cf63f4f4ce99@linux.vnet.ibm.com> <59B9D439.10807@huawei.com> From: Halil Pasic Date: Fri, 15 Sep 2017 19:33:08 +0200 MIME-Version: 1.0 In-Reply-To: <59B9D439.10807@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Message-Id: <7e490af1-9caa-c96d-5f62-308f1b5d8805@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [virtio-dev] Re: [RFC 0/8] virtio-crypto: add multiplexing mode support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Longpeng (Mike)" Cc: weidong.huang@huawei.com, mst@redhat.com, jasowang@redhat.com, qemu-devel@nongnu.org, john.griffin@intel.com, Varun.Sethi@freescale.com, denglingli@chinamobile.com, arei.gonglei@hotmail.com, virtio-dev@lists.oasis-open.org, agraf@suse.de, arei.gonglei@huawei.com, vincent.jardin@6wind.com, Ola.Liljedahl@arm.com, luonengjun@huawei.com, xin.zeng@intel.com, liang.j.ma@intel.com, stefanha@redhat.com, Jani.Kokkonen@huawei.com, brian.a.keating@intel.com, wangxinxin.wang@huawei.com, cohuck@redhat.com, mike.caraman@nxp.com On 09/14/2017 02:58 AM, Longpeng (Mike) wrote: > > > On 2017/9/14 2:14, Halil Pasic wrote: > >> >> >> On 09/11/2017 03:10 AM, Longpeng(Mike) wrote: >>> *NOTE* >>> The code realization is based on the latest virtio crypto spec: >>> [PATCH v19 0/2] virtio-crypto: virtio crypto device specification >>> https://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg05217.html >>> >>> In session mode, the process of create/close a session >>> makes we have a least one full round-trip cost from guest to host to guest >>> to be able to send any data for symmetric algorithms. It gets ourself into >>> synchronization troubles in some scenarios like a web server handling lots >>> of small requests whose algorithms and keys are different. >>> >>> We can support one-blob request (no sessions) as well for symmetric >>> algorithms, including HASH, MAC services. The benefit is obvious for >>> HASH service because it's usually a one-blob operation. >>> >> >> Hi! >> >> I've just started looking at this. Patch #1 modifies linux/virtio_crypto.h >> which if I compare with the (almost) latest linux master is different. Thus >> I would expect a corresponding kernel patch set too, but I haven't received >> one, nor did I find a reference in the cover letter. >> >> I think if I want to test the new features I need the kernel counter-part >> too, or? >> >> Could you point me to the kernel counterpart? >> > > > Hi Halil, > > We haven't implemented the kernel frontend part yet, but there's a testcase > based on qtest, you can use it. > > Please see the attachment. > Thanks Longpeng! I have two problems with this: first I can't use this on s390x and as you may have noticed I'm working mostly on s390x (that's what I'm payed for). OK, my laptop is amd64 so I was able to try it out, and that leads to the next problem. I can't test before/after and cross version stuff with this. That hurts me because I have a feeling things can be done simpler but that feeling has failed me before, so I tend to try out first and then start a discussion. Is some kernel patch series already in the pipeline? Regards, Halil From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-2545-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [66.179.20.138]) by lists.oasis-open.org (Postfix) with ESMTP id C0E795819226 for ; Fri, 15 Sep 2017 10:33:22 -0700 (PDT) References: <1505092240-10864-1-git-send-email-longpeng2@huawei.com> <2d8ae3d3-438b-da84-4959-cf63f4f4ce99@linux.vnet.ibm.com> <59B9D439.10807@huawei.com> From: Halil Pasic Date: Fri, 15 Sep 2017 19:33:08 +0200 MIME-Version: 1.0 In-Reply-To: <59B9D439.10807@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Message-Id: <7e490af1-9caa-c96d-5f62-308f1b5d8805@linux.vnet.ibm.com> Subject: [virtio-dev] Re: [Qemu-devel] [virtio-dev] Re: [RFC 0/8] virtio-crypto: add multiplexing mode support To: "Longpeng (Mike)" Cc: weidong.huang@huawei.com, mst@redhat.com, jasowang@redhat.com, qemu-devel@nongnu.org, john.griffin@intel.com, Varun.Sethi@freescale.com, denglingli@chinamobile.com, arei.gonglei@hotmail.com, virtio-dev@lists.oasis-open.org, agraf@suse.de, arei.gonglei@huawei.com, vincent.jardin@6wind.com, Ola.Liljedahl@arm.com, luonengjun@huawei.com, xin.zeng@intel.com, liang.j.ma@intel.com, stefanha@redhat.com, Jani.Kokkonen@huawei.com, brian.a.keating@intel.com, wangxinxin.wang@huawei.com, cohuck@redhat.com, mike.caraman@nxp.com List-ID: On 09/14/2017 02:58 AM, Longpeng (Mike) wrote: > > > On 2017/9/14 2:14, Halil Pasic wrote: > >> >> >> On 09/11/2017 03:10 AM, Longpeng(Mike) wrote: >>> *NOTE* >>> The code realization is based on the latest virtio crypto spec: >>> [PATCH v19 0/2] virtio-crypto: virtio crypto device specification >>> https://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg05217.html >>> >>> In session mode, the process of create/close a session >>> makes we have a least one full round-trip cost from guest to host to guest >>> to be able to send any data for symmetric algorithms. It gets ourself into >>> synchronization troubles in some scenarios like a web server handling lots >>> of small requests whose algorithms and keys are different. >>> >>> We can support one-blob request (no sessions) as well for symmetric >>> algorithms, including HASH, MAC services. The benefit is obvious for >>> HASH service because it's usually a one-blob operation. >>> >> >> Hi! >> >> I've just started looking at this. Patch #1 modifies linux/virtio_crypto.h >> which if I compare with the (almost) latest linux master is different. Thus >> I would expect a corresponding kernel patch set too, but I haven't received >> one, nor did I find a reference in the cover letter. >> >> I think if I want to test the new features I need the kernel counter-part >> too, or? >> >> Could you point me to the kernel counterpart? >> > > > Hi Halil, > > We haven't implemented the kernel frontend part yet, but there's a testcase > based on qtest, you can use it. > > Please see the attachment. > Thanks Longpeng! I have two problems with this: first I can't use this on s390x and as you may have noticed I'm working mostly on s390x (that's what I'm payed for). OK, my laptop is amd64 so I was able to try it out, and that leads to the next problem. I can't test before/after and cross version stuff with this. That hurts me because I have a feeling things can be done simpler but that feeling has failed me before, so I tend to try out first and then start a discussion. Is some kernel patch series already in the pipeline? Regards, Halil --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org