From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1BCBC433E0 for ; Mon, 6 Jul 2020 10:38:57 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70EFC2070B for ; Mon, 6 Jul 2020 10:38:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=xen.org header.i=@xen.org header.b="C9iCoYEA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70EFC2070B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jsOWI-0005HF-Qz; Mon, 06 Jul 2020 10:38:42 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jsOWG-0005H8-Qa for xen-devel@lists.xenproject.org; Mon, 06 Jul 2020 10:38:40 +0000 X-Inumbo-ID: db009bae-bf74-11ea-8c5a-12813bfff9fa Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id db009bae-bf74-11ea-8c5a-12813bfff9fa; Mon, 06 Jul 2020 10:38:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=thad9sChOuafOlmHsNirsbZq9s5m3eeNnXpj9qYAVbw=; b=C9iCoYEARSdKxQNdSrbANA/HUs LOmOFGtKhlvVXUuPuQJwTbp29w7K88FU9scvHeOLLgNfXVvTDuHT5UKnnlZ3cgqOF5W0tDT2PdGvy GZ8ETae0zaNpUYV0IEWyw9F6vjcwbVxecohXUnLw1vJojNFCCHkjMEV6PQrRRcZm+sp8=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jsOWC-0003sy-Bz; Mon, 06 Jul 2020 10:38:36 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jsOWC-0002gk-2b; Mon, 06 Jul 2020 10:38:36 +0000 Subject: Re: [PATCH v5 09/11] x86/domctl: add XEN_DOMCTL_vmtrace_op To: Jan Beulich , =?UTF-8?Q?Micha=c5=82_Leszczy=c5=84ski?= References: <6763525a-dca6-dfe5-b417-96e69a22d927@xen.org> <1fe71a95-1757-ca18-1d36-c3712e7b6fdf@suse.com> From: Julien Grall Message-ID: <7e6e4cd1-7244-243a-6af6-5c24ce24c10f@xen.org> Date: Mon, 6 Jul 2020 11:38:33 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1fe71a95-1757-ca18-1d36-c3712e7b6fdf@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , tamas.lengyel@intel.com, Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , luwei.kang@intel.com, xen-devel@lists.xenproject.org, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 06/07/2020 11:37, Jan Beulich wrote: > On 06.07.2020 12:31, Julien Grall wrote: >> On 05/07/2020 19:55, Michał Leszczyński wrote: >>> +/* XEN_DOMCTL_vmtrace_op: Perform VM tracing related operation */ >>> +#if defined(__XEN__) || defined(__XEN_TOOLS__) >>> + >>> +struct xen_domctl_vmtrace_op { >>> + /* IN variable */ >>> + uint32_t cmd; >>> +/* Enable/disable external vmtrace for given domain */ >>> +#define XEN_DOMCTL_vmtrace_pt_enable 1 >>> +#define XEN_DOMCTL_vmtrace_pt_disable 2 >>> +#define XEN_DOMCTL_vmtrace_pt_get_offset 3 >>> + domid_t domain; >> >> AFAICT, there is a 16-bit implicit padding here and ... >> >> >>> + uint32_t vcpu; >> >> ... a 32-bit implicit padding here. I would suggest to make >> the two explicit. >> >> We possibly want to check they are also always zero. > > Not just possibly imo - we should. I wasn't sure given that DOMCTL is not a stable interface. Cheers, -- Julien Grall