From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50BC0C433F5 for ; Mon, 18 Apr 2022 18:27:58 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CA23E811D8; Mon, 18 Apr 2022 20:27:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=seco.com header.i=@seco.com header.b="2jxJFg0d"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1E58B837C9; Mon, 18 Apr 2022 20:27:54 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20611.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e1a::611]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 43A1480269 for ; Mon, 18 Apr 2022 20:27:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sean.anderson@seco.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aZsOKbmD4LSqDL5fdIkPTNLMOOzC9wqSzMTUrXtXZDv0ejUnJfjTF//k37M+vsmDyyUgw2blGKPfTSKkR2Olh8ZkpeILCuYJ0CpLM0Lhp/rbkRvJWQ5a/6u/6BaXW20PZkGYEd9YiCl0J5xCwYpQrRWThrBWxBFunoMWhSD2gWQ0iPA0TXoCsjlysGtfd9O949tLMbbSLenV694jtW+lTrhdZJKA6dBA34JDH83bpxE+dXQs7e3Fq2FmpTYDhdaPdPWzz8vFoKzbFDaQCDZXyy99JnDyQLsYxrCxTS1VYs3VtEhL/a5bFfBqiw+jD6SQhdh7yttY/SnDsejgzOpf+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WWgm9fi5rLoLdudH+hsnCZSIkbmePOHNv6iOlsVrduI=; b=EAjLIIcyoZYA3XoJoRmQ9NiC/Ugj3KT1H97xvERV5UHZbPAgjeow5qKPaN7cJcoLdI6+qtCrQ6PWKpvS82Mc8rY4jZImsvvWqVs+TUmkEyAa0rDLtP6CPYiArArjGkGwMt0tjT/vVPQXoXIW3MPTt4J6WNQ7IF3nFrjSVCcgZ3ZzpxdfuW/Y8QqvN8G0iXmB3+yhmRt+o5+KyaFsk6gzcivqVZDHEU84+/IRO5zrUU27DNoP4rUsRTyhZrilN48LtroYutjSbHTRelMdn+O1e55zrLZzu2PwODKj6OpWBiHB7HDUiy1CZ2yY6t2nhWTuEcFuoC7xCK1xNPgNUhps1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=seco.com; dmarc=pass action=none header.from=seco.com; dkim=pass header.d=seco.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seco.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WWgm9fi5rLoLdudH+hsnCZSIkbmePOHNv6iOlsVrduI=; b=2jxJFg0d3cbT13DdZUWIlZ3hqgNYnRiGJxSW3I8qPDiqd9MQu4ESdhz7yCwi+k4PJ8GQVS817RwESP2Y4ERU4nwEb3OFKtegxbp7yB9UqTw3pTM1B6FOMrxtvuAkvTgGrukFUcBdLQxilbvkvfdKD9glOLSA45ksauvLuL1lXRqSQkdPoCxVuvZtd1XTZl7Bbr3GhyXNF2E/5wKho93qBtw67r4h/fDJp5ETwT1IPpNakjIAJnBPRc6GB/R/AQTRTEZkIGVNMafNICe0qeFzAomrw1LprGgB0+YniYtxEyV/XfnF3Xt1XgL/fQES9O6g+g4YyWiB5vobSFoBFzYvsg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=seco.com; Received: from DB7PR03MB4972.eurprd03.prod.outlook.com (2603:10a6:10:7d::22) by AS8PR03MB7429.eurprd03.prod.outlook.com (2603:10a6:20b:2e3::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Mon, 18 Apr 2022 18:27:48 +0000 Received: from DB7PR03MB4972.eurprd03.prod.outlook.com ([fe80::fd2d:a04b:de07:33f8]) by DB7PR03MB4972.eurprd03.prod.outlook.com ([fe80::fd2d:a04b:de07:33f8%6]) with mapi id 15.20.5164.025; Mon, 18 Apr 2022 18:27:48 +0000 Subject: Re: [PATCH v2 03/11] test: eth: Add test for ethernet addresses To: Tom Rini Cc: u-boot@lists.denx.de, Simon Glass , Heinrich Schuchardt , Ramon Fried , Joe Hershberger , Mario Six , =?UTF-8?Q?Marek_Beh=c3=ban?= References: <20220404193040.2305153-1-sean.anderson@seco.com> <20220404193040.2305153-4-sean.anderson@seco.com> <20220418170335.GA3032689@bill-the-cat> From: Sean Anderson Message-ID: <7e74d100-7cf2-7690-2305-06271a7c279a@seco.com> Date: Mon, 18 Apr 2022 14:27:42 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 In-Reply-To: <20220418170335.GA3032689@bill-the-cat> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BL0PR0102CA0005.prod.exchangelabs.com (2603:10b6:207:18::18) To DB7PR03MB4972.eurprd03.prod.outlook.com (2603:10a6:10:7d::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 71b0f08e-2e54-4b31-89b9-08da2169239f X-MS-TrafficTypeDiagnostic: AS8PR03MB7429:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xKD3RatCjm8mgvPVHWE55C3loK5PCHa8+ulgUCF3lO5s7FSTn9B5g+Xbi5BZL30Dsn1SX5j/UN75yGoyw/bJnabY6KKwELNP0Xve650r4tvkhyFV/xqhykk7x0cYWwt8sAzYPRYM73tiY9QdWmGzUCRyoQNOJU7BUQ6hT4TwE6nCd5A6FPdssoGCZBcIyuKE2pGa0Cq0Z7cskSzhCoOpHK8kN4MY1sokT/993Dm0qxEeBja/VoTgNf8XjjhfqXIvdlyISO5ogUiPnTF/OLGkJc95Vth1bd38bjUUxFKie6vhcZEqRNEVwOFtFRaeKFq5p1xEhivBNjAcWl/KszF9HDQm728ShsamfSwYsb04n+7tQJkSSCM3kYMWxdVcGYK2YQbUmldpLAWMm82nmu2GqVBLu2MH+HDNkzfZBspEnBcZ2syEEG7ntEyQBeEZmrYKKRgtNEXHqUZR1Z0BL+USatBu+TDgjNZXfAGPC/lEqIQDuPYK3JUpZhseXCxO2aVeSkY4D5Y2pWUEvvzTm65CyLI+n7niQ7jKjxl6MOvkjZ01a0bl7cLn489ce/RODpDaz65SlfApwLcHe4YtgQcPGWsYTvGn56qlE0mMuEiBa4kLxBC8iXnXrGF5JXJkUkezkLvGqgC887X171nNearqTIvO3E5ebh/OGhuepkwCWcC4M1yGfvqOSx6zKe3NbFxYjbkHO0efKqPTQYZJiZdyIsF082OsSGYFOJIEV1l0/ZtWVHCM62QOT7m5RxWwodHKYCNFNwcB2LeFQjXB/3JOMA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR03MB4972.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(8676002)(66476007)(66556008)(4326008)(508600001)(6916009)(2616005)(54906003)(44832011)(2906002)(6512007)(53546011)(8936002)(52116002)(36756003)(6506007)(31686004)(66946007)(5660300002)(31696002)(83380400001)(6666004)(86362001)(38100700002)(38350700002)(6486002)(316002)(186003)(26005)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?eG6Qq0nkGGvDsNlmNpIE9FNy8LxirqPTFQZ2sBPVk/+43ehyPvKiikDm?= =?Windows-1252?Q?dQ7UnDvkdh+ULoSRoJR/8L5dnXs1fn/cOeulbCF+CZReUon/LdBONUv7?= =?Windows-1252?Q?BMHI4TW9zOPAvPjoHkXbYVUa6MNZn1F6bFkF8IMW8pG66akHtMwGXPxe?= =?Windows-1252?Q?lpw3URLUydlrl5VeCYzwENjaZYWH2c4yBGYUUPiN3I3s0M9LrL0dALQj?= =?Windows-1252?Q?rbPspCYk3bcLZli410PIrPuKuvZYfz0IiQgib0xoC+Yk5PZiWTzvvAkA?= =?Windows-1252?Q?rs52gOsBOV1+7IJejMD2fk9KRdXtAGcVyX2iWu3V8lhPlyr/KHvUtALn?= =?Windows-1252?Q?oUHOHp3cYJV3HpQTYOSR0g6t9j0wzEz11vauCtlQqSlzeOhVaAsvzD4B?= =?Windows-1252?Q?3uJA+2IR5u4WFAMA1iI2CwNVJuf3nz0AJNTrO1lE6qRvNSHw0wIdC1IY?= =?Windows-1252?Q?0KXkVPJWts3VRq92liMb735KjICn3Y3nTkGUJJLcdf2CTdPL5kzdpyPp?= =?Windows-1252?Q?jld5/V+eTe48LkNOyxIDg42DIP6eKWPZ7TjIUxl7uGrvWA1UVaTOF2oL?= =?Windows-1252?Q?eCrFQaoUCgTOMXTvIi9Eg/ekVrAMyGEOOsUm2BR0llS9tqTWAsf7CEQp?= =?Windows-1252?Q?G6PJ18fuTgVM8VpuMrZ5V+/7+iSgfSJAjaFzN3dCmk+HO/xiVhEoIC1t?= =?Windows-1252?Q?KC735JFgToCBAsXJikrZyLJPnkg4Z+XgecqiWhWvqVAgAuQ8xgMWCgJ7?= =?Windows-1252?Q?8XUeO66nrJFcvxGAEwdx1m42PPnCl7sJlweMN2N8DF51LgS6pZyYvnMh?= =?Windows-1252?Q?I4/+cpPIlqHWl0e+5uaYbIc0n15O4hoUyGuIeZcndlP8cWrLNCowJB6S?= =?Windows-1252?Q?5ii5QHQiXfVmuWasPy9MBRAs3a9lMRgoNLu7Nv0jN3Ruw1EawRntSYrQ?= =?Windows-1252?Q?TEhzNWK2ylreQpAnlO1/SdSC1uGK8GWS+OdNkdZJH7xUwFLdzPQvWz87?= =?Windows-1252?Q?rcHWx35995w5T7xzd8k1eVZ5RVKxVL5PuoAzYp6QYpf+hPvvpBMazDon?= =?Windows-1252?Q?J9/o3eIckcyAt/QbeetXq3v0rgxzxV6ln314Hs0EtEyE8NRSCsT2CKGk?= =?Windows-1252?Q?722yX5e+gcGly4MpyuM5jFwoQ1SfEQd6usPrFaGgnEIaS6pzCRpHps8F?= =?Windows-1252?Q?Oy8TVGgwYRu7kZmewMv1CF7pfgf51nN+kL8OnGOTMSWA8KamU+lt+lK4?= =?Windows-1252?Q?dTOhJlSPGmxS1PTWz3mtahVO0BbNonGgTODlX6uZRRSW7pTJ0O+nqi0W?= =?Windows-1252?Q?DsX6dfpD+SG6TvZ14Ws5d6SJi2G1CDzWSam8afj/ejBhUnIfRf5OigBl?= =?Windows-1252?Q?fHw5YL2uKydpwg+ltxy3plzGQEGRoAtdHFft+S/ouY8EAME59/qjW4k/?= =?Windows-1252?Q?4/0uLPnGyw40YxJauO4gN/Wj6wLGSQg9ijioxKDO6sLNL4xVQ25zstsw?= =?Windows-1252?Q?i894Hly5lXunial/sA8J2sfqU5IltsCuhnh2PAuFJpewjGkz8BocXPCk?= =?Windows-1252?Q?TlN5Nt7sUKL2WiowlhdHh/7u5NPBmZB64Z270Xp4qm6FoskYeFhwiwOn?= =?Windows-1252?Q?kYAs/xJiVOTvLF70klOhxxrGDkzw6NmedcvugpsnTfy9FFrVr3GQEmGn?= =?Windows-1252?Q?/qfrDlqPNmRnu6vF/UlYJcpV1ljdy3ZoEW+N0Bxpu5dLv1AWyZr0o/qO?= =?Windows-1252?Q?gEevGFM80cmw7sHBaTGwR8NKKkHKZE3QW7S14JyFa52oZe7L8e7d9TJR?= =?Windows-1252?Q?wPM0eA0BlK8EDUM65lzgcAQVnAWrZz/gPzmHTIKaH6quVLfKXM73Xw2x?= =?Windows-1252?Q?2IGLL/JqxmA2AX04+SKfpgsqtNT+YDiq8Cg=3D?= X-OriginatorOrg: seco.com X-MS-Exchange-CrossTenant-Network-Message-Id: 71b0f08e-2e54-4b31-89b9-08da2169239f X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4972.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2022 18:27:48.0849 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oFevq7McNqixTKWgxUeNvBTCU4+dcRrVU6IoP9jHk3Ys6yj5yBDRDthX31cRsx87sOjbmAq5izI6ULEzzeKyfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB7429 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 4/18/22 1:03 PM, Tom Rini wrote: > On Mon, Apr 04, 2022 at 03:30:32PM -0400, Sean Anderson wrote: > >> This adds a test to make sure that all the ethernet interfaces have >> their addresses read properly. At the moment everything is read from the >> environment, but the next few commits will add additional sources. >> >> Signed-off-by: Sean Anderson >> Reviewed-by: Simon Glass >> --- >> >> (no changes since v1) >> >> test/dm/eth.c | 28 ++++++++++++++++++++++++++++ >> 1 file changed, 28 insertions(+) >> >> diff --git a/test/dm/eth.c b/test/dm/eth.c >> index e4ee695610..d7b1d5a2d2 100644 >> --- a/test/dm/eth.c >> +++ b/test/dm/eth.c >> @@ -147,6 +147,34 @@ static int dm_test_eth_act(struct unit_test_state *uts) >> } >> DM_TEST(dm_test_eth_act, UT_TESTF_SCAN_FDT); >> >> +/* Ensure that all addresses are loaded properly */ >> +static int dm_test_ethaddr(struct unit_test_state *uts) >> +{ >> + static const char *const addr[] = { >> + "02:00:11:22:33:44", >> + "02:00:11:22:33:48", /* dsa slave */ >> + "02:00:11:22:33:45", >> + "02:00:11:22:33:48", /* dsa master */ >> + "02:00:11:22:33:46", >> + "02:00:11:22:33:47", >> + "02:00:11:22:33:48", /* dsa slave */ >> + }; >> + int i; >> + >> + for (i = 0; i < ARRAY_SIZE(addr); i++) { >> + char addrname[10]; >> + >> + if (i) >> + snprintf(addrname, sizeof(addrname), "eth%daddr", i + 1); >> + else >> + strcpy(addrname, "ethaddr"); >> + ut_asserteq_str(addr[i], env_get(addrname)); >> + } >> + >> + return 0; >> +} >> +DM_TEST(dm_test_ethaddr, UT_TESTF_SCAN_FDT); >> + >> /* The asserts include a return on fail; cleanup in the caller */ >> static int _dm_test_eth_rotate1(struct unit_test_state *uts) >> { > > This, and I guess something related to the lists of ethaddrs in > board/sandbox/sandbox.env causes the test to fail. Can you please look > in to it? Thanks. > Looks like f3dd213e15 ("net: introduce helpers to get PHY ofnode from MAC") added another fake-host-hwaddr property and messed up the ordering. I'll send v3 if there are no other comments. --Sean