From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 5/6] nvme-auth: set DNR bit on non-retryable errors
Date: Wed, 2 Nov 2022 09:40:11 +0100 [thread overview]
Message-ID: <7e7610c0-b301-39ea-109d-707771a74d08@suse.de> (raw)
In-Reply-To: <20221102080220.GA10816@lst.de>
On 11/2/22 09:02, Christoph Hellwig wrote:
> On Wed, Nov 02, 2022 at 08:52:23AM +0100, Hannes Reinecke wrote:
>> diff --git a/drivers/nvme/host/auth.c b/drivers/nvme/host/auth.c
>> index b4af8661c988..6ca0c2bb06c0 100644
>> --- a/drivers/nvme/host/auth.c
>> +++ b/drivers/nvme/host/auth.c
>> @@ -151,7 +151,7 @@ static int nvme_auth_process_dhchap_challenge(struct nvme_ctrl *ctrl,
>>
>> if (chap->buf_size < size) {
>> chap->status = NVME_AUTH_DHCHAP_FAILURE_INCORRECT_PAYLOAD;
>> - return NVME_SC_INVALID_FIELD;
>> + return NVME_SC_DNR | NVME_SC_INVALID_FIELD;
>
> Any use of NVME_SC_ for error purely in host software are bogus. This
> should be using Linux error codes.
I knew you would be saying that.
I was worrying about retryable and non-retryable errors, but seeing that
all errors are currently treated as non-retryable I'll be changing it to
return error codes.
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
next prev parent reply other threads:[~2022-11-02 8:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 7:52 [PATCH 0/6] nvme-auth: use xarray and minor fixes Hannes Reinecke
2022-11-02 7:52 ` [PATCH 1/6] nvme-auth: allocate authentication buffer only during transaction Hannes Reinecke
2022-11-03 20:01 ` Sagi Grimberg
2022-11-04 6:49 ` Hannes Reinecke
2022-11-04 6:55 ` Christoph Hellwig
2022-11-02 7:52 ` [PATCH 2/6] nvme-auth: do not queue authentication if the queue is not live Hannes Reinecke
2022-11-03 21:19 ` Sagi Grimberg
2022-11-04 6:54 ` Hannes Reinecke
2022-11-02 7:52 ` [PATCH 3/6] nvme-auth: use xarray instead of linked list Hannes Reinecke
2022-11-02 8:03 ` Christoph Hellwig
2022-11-02 8:52 ` Hannes Reinecke
2022-11-02 8:54 ` Christoph Hellwig
2022-11-03 21:20 ` Sagi Grimberg
2022-11-04 6:57 ` Hannes Reinecke
2022-11-02 7:52 ` [PATCH 4/6] nvme-auth: return real error instead of NVME_SC_AUTH_REQUIRED Hannes Reinecke
2022-11-02 7:52 ` [PATCH 5/6] nvme-auth: set DNR bit on non-retryable errors Hannes Reinecke
2022-11-02 8:02 ` Christoph Hellwig
2022-11-02 8:40 ` Hannes Reinecke [this message]
2022-11-02 7:52 ` [PATCH 6/6] nvme-auth: use a define for chap buffer size Hannes Reinecke
2022-11-03 21:22 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e7610c0-b301-39ea-109d-707771a74d08@suse.de \
--to=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.