All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: chugh.ishani@research.iiit.ac.in
Subject: Re: [Qemu-devel] [PATCH 0/3] scripts: add argparse module for Python 2.6 compatibility
Date: Mon, 28 Aug 2017 17:47:05 -0400	[thread overview]
Message-ID: <7e7711c2-1618-2212-847b-f069aabb0015@redhat.com> (raw)
In-Reply-To: <20170825155732.15665-1-stefanha@redhat.com>



On 08/25/2017 11:57 AM, Stefan Hajnoczi wrote:
> Many scripts can benefit from the standard library argparse module, which has
> improvements over the older optparse module.  Unfortunately argparse was only
> shipped in Python 2.7 so we need a fallback for Python 2.6.
> 
> This patch series adds a copy of argparse.py and updates scripts as necessary
> to import it.
> 
> Stefan Hajnoczi (3):
>   scripts: add argparse module for Python 2.6 compatibility
>   docker.py: Python 2.6 argparse compatibility
>   tests: migration/guestperf Python 2.6 argparse compatibility
> 
>  COPYING.PYTHON                     |  270 ++++
>  scripts/argparse.py                | 2406 ++++++++++++++++++++++++++++++++++++
>  tests/docker/docker.py             |    4 +-
>  tests/migration/guestperf/shell.py |    8 +-
>  4 files changed, 2684 insertions(+), 4 deletions(-)
>  create mode 100644 COPYING.PYTHON
>  create mode 100644 scripts/argparse.py
> 

Acked-by: John Snow <jsnow@redhat.com>

Seems sane to me, provided it actually works in those 2.6 contexts we
wish it to...

  parent reply	other threads:[~2017-08-28 21:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-25 15:57 [Qemu-devel] [PATCH 0/3] scripts: add argparse module for Python 2.6 compatibility Stefan Hajnoczi
2017-08-25 15:57 ` [Qemu-devel] [PATCH 1/3] " Stefan Hajnoczi
2017-08-25 15:57 ` [Qemu-devel] [PATCH 2/3] docker.py: Python 2.6 argparse compatibility Stefan Hajnoczi
2017-08-26  0:29   ` Fam Zheng
2017-08-25 15:57 ` [Qemu-devel] [PATCH 3/3] tests: migration/guestperf " Stefan Hajnoczi
2017-08-25 16:24 ` [Qemu-devel] [PATCH 0/3] scripts: add argparse module for Python 2.6 compatibility no-reply
2017-08-29  9:59   ` Stefan Hajnoczi
2017-08-25 16:35 ` Philippe Mathieu-Daudé
2017-08-25 16:40   ` Peter Maydell
2017-08-25 17:42     ` Eric Blake
2017-08-29 10:01       ` Stefan Hajnoczi
2017-08-29 18:02         ` Philippe Mathieu-Daudé
2017-08-28 21:47 ` John Snow [this message]
2017-08-30 11:02 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e7711c2-1618-2212-847b-f069aabb0015@redhat.com \
    --to=jsnow@redhat.com \
    --cc=chugh.ishani@research.iiit.ac.in \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.