From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Wang Subject: Re: [PATCH] net/packet: fix packet drop as of virtio gso Date: Mon, 29 Oct 2018 10:40:18 +0800 Message-ID: <7e894134-0178-e9e0-c584-8c607a270901@redhat.com> References: <20180929154127.20867-1-jianfeng.tan@linux.alibaba.com> <7aed6adf-eea3-c5ea-ead5-8ab31bb9e61a@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Cc: davem@davemloft.net, mst@redhat.com To: Jianfeng Tan , netdev@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:55644 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729045AbeJ2L1F (ORCPT ); Mon, 29 Oct 2018 07:27:05 -0400 In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 2018/10/28 上午7:42, Jianfeng Tan wrote: > > On 10/8/2018 11:14 AM, Jason Wang wrote: >> >> >> On 2018年09月29日 23:41, Jianfeng Tan wrote: >>> When we use raw socket as the vhost backend, a packet from virito with >>> gso offloading information, cannot be sent out in later validaton at >>> xmit path, as we did not set correct skb->protocol which is further >>> used >>> for looking up the gso function. >> >> Hi: >> >> May I ask the reason for using raw socket for vhost? It was not a >> common setup with little care in the past few years. And it was slow >> since it lacks some recent improvements. Can it be replaced with e.g >> macvtap? > > Hi Jason, > > Apologize for late response. We are in container environment, in which > case veth is used mostly. Either tap or macvtap cannot be put into an > isolated netns. I think it can? See 17af2bce88d31e65ed73d638bb752d2e13c66ced. > Another thing could be macvlan as the backend of vhost, which is not > supported either. So unfortunately, improving raw socket is the only > choice I suppose. Btw, you can setup macvtap on top of veth. Does this help? Thanks > > Thanks, > Jianfeng