From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5620C2D0E4 for ; Fri, 27 Nov 2020 07:31:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 85D66221F7 for ; Fri, 27 Nov 2020 07:31:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405330AbgK0HbQ (ORCPT ); Fri, 27 Nov 2020 02:31:16 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:8417 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726408AbgK0HbQ (ORCPT ); Fri, 27 Nov 2020 02:31:16 -0500 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4Cj5rq6ZfCz6wBk; Fri, 27 Nov 2020 15:30:51 +0800 (CST) Received: from [10.174.178.154] (10.174.178.154) by smtp.huawei.com (10.3.19.212) with Microsoft SMTP Server (TLS) id 14.3.487.0; Fri, 27 Nov 2020 15:31:11 +0800 Subject: Re: [PATCH] usb: dwc3: meson-g12a: disable clk on error handling path in probe To: Martin Blumenstingl CC: , , , Neil Armstrong , , , , References: <20201111095256.10477-1-zhengzengkai@huawei.com> From: Zheng Zengkai Message-ID: <7ea6de9c-f482-2f8e-1d54-b8c127d10f22@huawei.com> Date: Fri, 27 Nov 2020 15:31:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.154] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Ping... > On Wed, Nov 11, 2020 at 10:48 AM Zheng Zengkai wrote: >> dwc3_meson_g12a_probe() does not invoke clk_bulk_disable_unprepare() >> on one error handling path. This patch fixes that. >> >> Fixes: 347052e3bf1b ("usb: dwc3: meson-g12a: fix USB2 PHY initialization on G12A and A1 SoCs") >> Reported-by: Hulk Robot >> Signed-off-by: Zheng Zengkai > Reviewed-by: Martin Blumenstingl > > many thanks for this fix! > > > Best regards > Martin > . > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9259C2D0E4 for ; Fri, 27 Nov 2020 07:31:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 176E421D93 for ; Fri, 27 Nov 2020 07:31:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NezVS67Z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 176E421D93 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=d4sTXyfRtvEt/ritHpCxr6HJN1V8tIxHtPpynET8vi8=; b=NezVS67ZhIAadF9jf3YPXaHcP hd//TNE8MrnNvNPiuAIHLsRbgDPFIBTt7aSzvoEeKn5kKQUBT+CO1al/vn9Omx14fpXkkim4qArhQ 4DNHbZpsxi0LqHKqs1Ob6fMFX+ttWLcOOGuQ8bkTT8x3c9I6xnMX6FLRweepWgMmGmqIZFR/sG+Tg 0QT2YJXX3fiiCl8UL2lq8Nl8+b4eKq8JDn6CY5ZyaQVqefl2xyXAqurpRPRH0DskkCgSmbxjwheE1 WAPu6gUg5jdSH7hYApfmt/uIp6wNZpEHG43VUdTytyhxzS3HcaNweei6EpdMJUg0R2aPU1D80iovq NgzRwkTTg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiYEG-0006Xo-EL; Fri, 27 Nov 2020 07:31:40 +0000 Received: from szxga07-in.huawei.com ([45.249.212.35]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiYE9-0006S4-Px; Fri, 27 Nov 2020 07:31:36 +0000 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4Cj5rq6ZfCz6wBk; Fri, 27 Nov 2020 15:30:51 +0800 (CST) Received: from [10.174.178.154] (10.174.178.154) by smtp.huawei.com (10.3.19.212) with Microsoft SMTP Server (TLS) id 14.3.487.0; Fri, 27 Nov 2020 15:31:11 +0800 Subject: Re: [PATCH] usb: dwc3: meson-g12a: disable clk on error handling path in probe To: Martin Blumenstingl References: <20201111095256.10477-1-zhengzengkai@huawei.com> From: Zheng Zengkai Message-ID: <7ea6de9c-f482-2f8e-1d54-b8c127d10f22@huawei.com> Date: Fri, 27 Nov 2020 15:31:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.174.178.154] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201127_023136_141719_20F9A830 X-CRM114-Status: UNSURE ( 9.62 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: balbi@kernel.org, Neil Armstrong , khilman@baylibre.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Ping... > On Wed, Nov 11, 2020 at 10:48 AM Zheng Zengkai wrote: >> dwc3_meson_g12a_probe() does not invoke clk_bulk_disable_unprepare() >> on one error handling path. This patch fixes that. >> >> Fixes: 347052e3bf1b ("usb: dwc3: meson-g12a: fix USB2 PHY initialization on G12A and A1 SoCs") >> Reported-by: Hulk Robot >> Signed-off-by: Zheng Zengkai > Reviewed-by: Martin Blumenstingl > > many thanks for this fix! > > > Best regards > Martin > . > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1450BC2D0E4 for ; Fri, 27 Nov 2020 07:33:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8AA8E21D93 for ; Fri, 27 Nov 2020 07:33:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tLmgDgw/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8AA8E21D93 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2u7TBd7bDJSMxWn7zFi0uA9hDWbgS6LeQn8G3+8FNAs=; b=tLmgDgw/mLyuCSKVVCuhmK2vX juypK6KfJZ6plzBDash+MxDpGS/76yuhRlYQfU2v+hEnsoWKFerwYBpms0CEz/rD/v4ceTlksuowi v4dn3jBYBo3P9z0cpBZTdFjcfDIk6pdaCNr2m4jz7qeVOLGJIVXwhah5XFTx4ADiRerWzlHc3zauK DCNtP+lP/Uz1m8uMDJrbpYXi1ehdpkVWrZwc1bUq6e0IATszGvkRTG/wPH+TdwFBXY8JrVP8KRBKS rfgD6pOJT7nTNLDRGSRQVL4gFSghqvnKoUPCUj8roE8yZ4aVzbIzbvlRm82egHVpJsIiVpngey6Nr uBwTN5nOg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiYEN-0006Yz-AK; Fri, 27 Nov 2020 07:31:47 +0000 Received: from szxga07-in.huawei.com ([45.249.212.35]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiYE9-0006S4-Px; Fri, 27 Nov 2020 07:31:36 +0000 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4Cj5rq6ZfCz6wBk; Fri, 27 Nov 2020 15:30:51 +0800 (CST) Received: from [10.174.178.154] (10.174.178.154) by smtp.huawei.com (10.3.19.212) with Microsoft SMTP Server (TLS) id 14.3.487.0; Fri, 27 Nov 2020 15:31:11 +0800 Subject: Re: [PATCH] usb: dwc3: meson-g12a: disable clk on error handling path in probe To: Martin Blumenstingl References: <20201111095256.10477-1-zhengzengkai@huawei.com> From: Zheng Zengkai Message-ID: <7ea6de9c-f482-2f8e-1d54-b8c127d10f22@huawei.com> Date: Fri, 27 Nov 2020 15:31:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.174.178.154] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201127_023136_141719_20F9A830 X-CRM114-Status: UNSURE ( 9.62 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: balbi@kernel.org, Neil Armstrong , khilman@baylibre.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Ping... > On Wed, Nov 11, 2020 at 10:48 AM Zheng Zengkai wrote: >> dwc3_meson_g12a_probe() does not invoke clk_bulk_disable_unprepare() >> on one error handling path. This patch fixes that. >> >> Fixes: 347052e3bf1b ("usb: dwc3: meson-g12a: fix USB2 PHY initialization on G12A and A1 SoCs") >> Reported-by: Hulk Robot >> Signed-off-by: Zheng Zengkai > Reviewed-by: Martin Blumenstingl > > many thanks for this fix! > > > Best regards > Martin > . > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel