From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D0C170 for ; Sat, 22 May 2021 14:46:26 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id D0EE0580548; Sat, 22 May 2021 10:46:25 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sat, 22 May 2021 10:46:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-type:content-transfer-encoding; s=fm2; bh=l +A4yTvicWmupzboZaUYCZiVaO0UIe5ScpESUsU9qVg=; b=mwHxG35kMgCv7LB1q m93yPspC9iIzIASxKMhRZY1PR8SrosB/MEsjWl4gSBI/JdqPGpa6FuMTsgIiAfmI YzcaAdan8ZtJ62q+q/Bc6u6WLJFy7Ll3nD2//RqnaI/LmDnQT8d9FUxr4KBtH5Aq kSMzbC1/IrxXkwWEG9gttRmEfB5uMoGPeJB89QCsKnUmrgUzWgHid8s0UGjDJQah DZ8K9q4ZO3+k0U9XkySSvPnwGVYHaDFLT6/2iS6ozm6Kice/zU7Lx8LOts5JfRr+ VkU0qSgF5vxQNvueWpEe6+Erc+razb106C0+GvS6uySIgG//rx3sPaAxshpkP038 s8sAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=l+A4yTvicWmupzboZaUYCZiVaO0UIe5ScpESUsU9q Vg=; b=iyAe4uF97inD6q5ixipJ+wohnSaIU0vpOgaqTbb9qhER7he1xfsSQsST5 FfTT471rBYOLmhMPq50VrLdjulb+EWRly8UVHItfjEPTtOJwgvzmRCwreiC+XnnR dT/ZIwssiN+AvtoTBh+v+oV0u/hijmmhJYHxSFXbEPAyF8Ln4UaE4Y4LaZBFJuNK 788Cto/lEqgvKlIPBsUHC15V8fRKixJhUQj5sbRM6l4maXDlHpyvwCr6A45dMECF L/cDdaaNlZ7vWKmidBmIPRV9dPBD5YMgRpP49qUgSDSPKbDSgVDht1/kYFRp/l+A /fX4qA43zzt9GdPhLrMtAj7dU+kHQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdejhedgkeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepuffvfhfhkffffgggjggtgfesthejredttdefjeenucfhrhhomhepufgrmhhu vghlucfjohhllhgrnhguuceoshgrmhhuvghlsehshhholhhlrghnugdrohhrgheqnecugg ftrfgrthhtvghrnhepgfevffetleehffejueekvdekvdeitdehveegfeekheeuieeiueet uefgtedtgeegnecukfhppedufeeirdefvddrieefrddvgedvnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshgrmhhuvghlsehshhholhhlrghn ugdrohhrgh X-ME-Proxy: Received: from [192.168.18.153] (unknown [136.32.63.242]) by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 22 May 2021 10:46:23 -0400 (EDT) Subject: Re: [PATCH v6 01/17] dt-bindings: mfd: axp20x: Add AXP305 compatible (plus optional IRQ) To: Andre Przywara , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec Cc: Rob Herring , Icenowy Zheng , Ondrej Jirman , linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Lee Jones References: <20210519104152.21119-1-andre.przywara@arm.com> <20210519104152.21119-2-andre.przywara@arm.com> From: Samuel Holland Message-ID: <7ebfaef7-5cf2-e60c-99ef-4275c873e72d@sholland.org> Date: Sat, 22 May 2021 09:46:23 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20210519104152.21119-2-andre.przywara@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 5/19/21 5:41 AM, Andre Przywara wrote: > The AXP305 PMIC used in AXP805 seems to be fully compatible to the ^^^^^^^^^^^^^^ Typo? Do you mean "used with the H616 SoC"? > AXP805 PMIC, so add the proper chain of compatible strings. > > Also at least on one board (Orangepi Zero2) there is no interrupt line > connected to the CPU, so make the "interrupts" property optional. > > Signed-off-by: Andre Przywara > --- > Documentation/devicetree/bindings/mfd/axp20x.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mfd/axp20x.txt b/Documentation/devicetree/bindings/mfd/axp20x.txt > index 4991a6415796..4fd748101e3c 100644 > --- a/Documentation/devicetree/bindings/mfd/axp20x.txt > +++ b/Documentation/devicetree/bindings/mfd/axp20x.txt > @@ -26,10 +26,10 @@ Required properties: > * "x-powers,axp803" > * "x-powers,axp806" > * "x-powers,axp805", "x-powers,axp806" > + * "x-powers,axp803", "x-powers,axp805", "x-powers,axp806" ^^^^^^ This should be x-powers,axp305. Regards, Samuel > * "x-powers,axp809" > * "x-powers,axp813" > - reg: The I2C slave address or RSB hardware address for the AXP chip > -- interrupts: SoC NMI / GPIO interrupt connected to the PMIC's IRQ pin > - interrupt-controller: The PMIC has its own internal IRQs > - #interrupt-cells: Should be set to 1 > > @@ -43,6 +43,7 @@ more information: > AXP20x/LDO3: software-based implementation > > Optional properties: > +- interrupts: SoC NMI / GPIO interrupt connected to the PMIC's IRQ pin > - x-powers,dcdc-freq: defines the work frequency of DC-DC in KHz > AXP152/20X: range: 750-1875, Default: 1.5 MHz > AXP22X/8XX: range: 1800-4050, Default: 3 MHz > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 551D1C2B9F2 for ; Sat, 22 May 2021 14:48:17 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BDAD061205 for ; Sat, 22 May 2021 14:48:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BDAD061205 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sholland.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LGW/zpxSLN/VKlyIyniE4o8v+M9HgfhvoSyRR4/9k7w=; b=Z47fYto0Mq4l2Yta4xjFhrIjpQ PUTVXALb0hQCdR4GiZrDqI7Kn/ju97dT1m/G6KlkOvFT6/ws8RFinN4t9h9l/Pkf5Xal4YsvJ4+UU GShtLbMhBGZg5k7G/pjqYtivzqhyLsg67jPtlmWgriaCKOYfYPSGiTN51LkG4eMm6JHGB03F7HTH4 QqNcOQDs/IxQaTVKlpI1KUJADaefv8VxGLmoe/2WtKYVcMuW8NNjcOlG+p3Y0N8f5Wbp3Y1KbQuVM Ykw812EF2Pcezv37l2/8mu6x4rv9/5ev3hwL8VhToKvBYDl3VX/qn7zgQL9MNszLn2afs33jgoxjZ UHtLdbkQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lkSth-002fnf-Vv; Sat, 22 May 2021 14:46:38 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lkSte-002fnV-Ft for linux-arm-kernel@desiato.infradead.org; Sat, 22 May 2021 14:46:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=l+A4yTvicWmupzboZaUYCZiVaO0UIe5ScpESUsU9qVg=; b=rQ+UlZKeGSj3gCdIxz6egzoIZ4 1uu//tCnhV6JtNEqogogB5+uZFNAfFdQd5pZK1uXmVEVzmm8ZAKLVjWkFkGSug6rKzz509or9ZvCM tZdVTKu4RwHssTXLYttRa51RAoTL0K3ETwHY9mghiVsMxlj4hc4tKD1urHynvD9HFdZgC1fqhXDir A6d3/CoRI9pEDQuqyZNdCixvZxtZOXIboKyLH0qtH5f3ictfa3YvmAUq+/VF7InYm4pf9EGIHQnA2 g/OSr9VrA9tWpdGoky3ltNgIOO65fn+Tz4crcE1P3kgWGLjLUgxCqOW4DVLmvHbtI4jy3fRwPoFhx o5hYjO2A==; Received: from new1-smtp.messagingengine.com ([66.111.4.221]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lkStb-0008La-Qy for linux-arm-kernel@lists.infradead.org; Sat, 22 May 2021 14:46:33 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id D0EE0580548; Sat, 22 May 2021 10:46:25 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sat, 22 May 2021 10:46:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-type:content-transfer-encoding; s=fm2; bh=l +A4yTvicWmupzboZaUYCZiVaO0UIe5ScpESUsU9qVg=; b=mwHxG35kMgCv7LB1q m93yPspC9iIzIASxKMhRZY1PR8SrosB/MEsjWl4gSBI/JdqPGpa6FuMTsgIiAfmI YzcaAdan8ZtJ62q+q/Bc6u6WLJFy7Ll3nD2//RqnaI/LmDnQT8d9FUxr4KBtH5Aq kSMzbC1/IrxXkwWEG9gttRmEfB5uMoGPeJB89QCsKnUmrgUzWgHid8s0UGjDJQah DZ8K9q4ZO3+k0U9XkySSvPnwGVYHaDFLT6/2iS6ozm6Kice/zU7Lx8LOts5JfRr+ VkU0qSgF5vxQNvueWpEe6+Erc+razb106C0+GvS6uySIgG//rx3sPaAxshpkP038 s8sAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=l+A4yTvicWmupzboZaUYCZiVaO0UIe5ScpESUsU9q Vg=; b=iyAe4uF97inD6q5ixipJ+wohnSaIU0vpOgaqTbb9qhER7he1xfsSQsST5 FfTT471rBYOLmhMPq50VrLdjulb+EWRly8UVHItfjEPTtOJwgvzmRCwreiC+XnnR dT/ZIwssiN+AvtoTBh+v+oV0u/hijmmhJYHxSFXbEPAyF8Ln4UaE4Y4LaZBFJuNK 788Cto/lEqgvKlIPBsUHC15V8fRKixJhUQj5sbRM6l4maXDlHpyvwCr6A45dMECF L/cDdaaNlZ7vWKmidBmIPRV9dPBD5YMgRpP49qUgSDSPKbDSgVDht1/kYFRp/l+A /fX4qA43zzt9GdPhLrMtAj7dU+kHQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdejhedgkeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepuffvfhfhkffffgggjggtgfesthejredttdefjeenucfhrhhomhepufgrmhhu vghlucfjohhllhgrnhguuceoshgrmhhuvghlsehshhholhhlrghnugdrohhrgheqnecugg ftrfgrthhtvghrnhepgfevffetleehffejueekvdekvdeitdehveegfeekheeuieeiueet uefgtedtgeegnecukfhppedufeeirdefvddrieefrddvgedvnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshgrmhhuvghlsehshhholhhlrghn ugdrohhrgh X-ME-Proxy: Received: from [192.168.18.153] (unknown [136.32.63.242]) by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 22 May 2021 10:46:23 -0400 (EDT) Subject: Re: [PATCH v6 01/17] dt-bindings: mfd: axp20x: Add AXP305 compatible (plus optional IRQ) To: Andre Przywara , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec Cc: Rob Herring , Icenowy Zheng , Ondrej Jirman , linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Lee Jones References: <20210519104152.21119-1-andre.przywara@arm.com> <20210519104152.21119-2-andre.przywara@arm.com> From: Samuel Holland Message-ID: <7ebfaef7-5cf2-e60c-99ef-4275c873e72d@sholland.org> Date: Sat, 22 May 2021 09:46:23 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20210519104152.21119-2-andre.przywara@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210522_074631_976272_08B4CDD0 X-CRM114-Status: GOOD ( 17.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/19/21 5:41 AM, Andre Przywara wrote: > The AXP305 PMIC used in AXP805 seems to be fully compatible to the ^^^^^^^^^^^^^^ Typo? Do you mean "used with the H616 SoC"? > AXP805 PMIC, so add the proper chain of compatible strings. > > Also at least on one board (Orangepi Zero2) there is no interrupt line > connected to the CPU, so make the "interrupts" property optional. > > Signed-off-by: Andre Przywara > --- > Documentation/devicetree/bindings/mfd/axp20x.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mfd/axp20x.txt b/Documentation/devicetree/bindings/mfd/axp20x.txt > index 4991a6415796..4fd748101e3c 100644 > --- a/Documentation/devicetree/bindings/mfd/axp20x.txt > +++ b/Documentation/devicetree/bindings/mfd/axp20x.txt > @@ -26,10 +26,10 @@ Required properties: > * "x-powers,axp803" > * "x-powers,axp806" > * "x-powers,axp805", "x-powers,axp806" > + * "x-powers,axp803", "x-powers,axp805", "x-powers,axp806" ^^^^^^ This should be x-powers,axp305. Regards, Samuel > * "x-powers,axp809" > * "x-powers,axp813" > - reg: The I2C slave address or RSB hardware address for the AXP chip > -- interrupts: SoC NMI / GPIO interrupt connected to the PMIC's IRQ pin > - interrupt-controller: The PMIC has its own internal IRQs > - #interrupt-cells: Should be set to 1 > > @@ -43,6 +43,7 @@ more information: > AXP20x/LDO3: software-based implementation > > Optional properties: > +- interrupts: SoC NMI / GPIO interrupt connected to the PMIC's IRQ pin > - x-powers,dcdc-freq: defines the work frequency of DC-DC in KHz > AXP152/20X: range: 750-1875, Default: 1.5 MHz > AXP22X/8XX: range: 1800-4050, Default: 3 MHz > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel