All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH v3] afs: Fix memory leak in afs_put_sysnames()
@ 2020-06-02  6:00 Markus Elfring
  0 siblings, 0 replies; 2+ messages in thread
From: Markus Elfring @ 2020-06-02  6:00 UTC (permalink / raw)
  To: Zhihao Cheng, David Howells, linux-afs, linux-fsdevel
  Cc: linux-kernel, Yi Zhang

> Cc: <Stable@vger.kernel.org> # v4.17+

Are capital letters tolerated for this special email address?

Regards,
Markus

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH v3] afs: Fix memory leak in afs_put_sysnames()
@ 2020-06-02  1:30 Zhihao Cheng
  0 siblings, 0 replies; 2+ messages in thread
From: Zhihao Cheng @ 2020-06-02  1:30 UTC (permalink / raw)
  To: linux-afs, linux-fsdevel, linux-kernel; +Cc: dhowells, yi.zhang

Fix afs_put_sysnames() to actually free the specified afs_sysnames
object after its reference count has been decreased to zero and
its contents have been released.

Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
Cc: <Stable@vger.kernel.org> # v4.17+
Fixes: 6f8880d8e681557 ("afs: Implement @sys substitution handling")
---
 fs/afs/proc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/afs/proc.c b/fs/afs/proc.c
index 468e1713bce1..6f34c84a0fd0 100644
--- a/fs/afs/proc.c
+++ b/fs/afs/proc.c
@@ -563,6 +563,7 @@ void afs_put_sysnames(struct afs_sysnames *sysnames)
 			if (sysnames->subs[i] != afs_init_sysname &&
 			    sysnames->subs[i] != sysnames->blank)
 				kfree(sysnames->subs[i]);
+		kfree(sysnames);
 	}
 }
 
-- 
2.25.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-06-02  6:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-02  6:00 [PATCH v3] afs: Fix memory leak in afs_put_sysnames() Markus Elfring
  -- strict thread matches above, loose matches on Subject: below --
2020-06-02  1:30 Zhihao Cheng

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.