From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67666C4338F for ; Mon, 2 Aug 2021 11:36:25 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6604560F6D for ; Mon, 2 Aug 2021 11:36:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6604560F6D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=siemens.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6BBDD82C48; Mon, 2 Aug 2021 13:36:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=siemens.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id BB00A82C48; Mon, 2 Aug 2021 13:36:20 +0200 (CEST) Received: from thoth.sbs.de (thoth.sbs.de [192.35.17.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9CE4F82916 for ; Mon, 2 Aug 2021 13:36:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=siemens.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jan.kiszka@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id 172BaFrE023981 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 2 Aug 2021 13:36:15 +0200 Received: from [167.87.245.49] ([167.87.245.49]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 172BaDnB019888; Mon, 2 Aug 2021 13:36:14 +0200 Subject: Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64" To: Marek Vasut , Tom Rini Cc: U-Boot Mailing List , Hai Pham , Simon Goldschmidt , Stephen Warren , Lokesh Vutla References: <1971775f-28de-83d0-9459-a4e68c744a18@siemens.com> <20210729152307.GP9379@bill-the-cat> <20210729165802.GA9379@bill-the-cat> <446b4861-6987-092a-43ce-5d3aa322f8f3@denx.de> From: Jan Kiszka Message-ID: <7edb5a3f-9896-278d-fe41-e2d48bb8f974@siemens.com> Date: Mon, 2 Aug 2021 13:36:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 02.08.21 12:48, Marek Vasut wrote: > On 8/2/21 11:37 AM, Jan Kiszka wrote: >> On 02.08.21 02:54, Marek Vasut wrote: >>> On 7/29/21 6:58 PM, Tom Rini wrote: >>> >>> [...] >>> >>>>>> so when did rcar3 introduce something there that shouldn't be >>>>>> reserved?  And you had phrased this to me on IRC as about reserving >>>>>> spot >>>>>> for ATAGS, and that not being needed of course on arm64.  But that's >>>>>> not >>>>>> what's going on.  Perhaps the answer is that rcar3 needs to >>>>>> introduce a >>>>>> board_lmb_reserve to free the normal arch one and provide whatever >>>>>> more >>>>>> narrow scope it needs. >>>>> >>>>> Based on the commit message 2359fa7a878 ("arm: bootm: Disable LMB >>>>> reservation for command line and board info on arm64") , this is >>>>> about ATAGS >>>>> and we really don't need to reserve those on arm64. >>>> >>>> Commit 2359fa7a878 disables the entire arch_lmb_reserve function on >>>> aarch64, yes.  I assumed when we had talked that it was a small area >>>> being set aside and perhaps mis-recalled that ATAGS tended to live at >>>> DDR_BASE + 0x800 or so. >>> >>> That arch_lmb_reserve() is responsible for reserving architecture >>> specific memory. On arm32 it is ATAGS, on arm64 it is nothing as far as >>> I can tell (and see below regarding the TLB). >>> >>>> This reservation is not at that spot, and a lot >>>> more than that. >>> >>> Can you please elaborate on this "lot more" part ? Because as much as I >>> studied the reservation code, the "lot more" was ATAGS on arm32 and >>> nothing on arm64. >> >> See my commit log. > > This is not particularly useful answer, considering the commit log says: > "lot of crucial things", "Possibly more", "likely also on other boards" > and other opaque statements. But really, the problem so far happens on > one K3 board. "Such things are the page table (tlb_addr), relocated U-Boot and the active stack." Jan -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux