From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [85.220.165.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E733C2C81 for ; Mon, 18 Oct 2021 10:20:45 +0000 (UTC) Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcPl3-0000Du-8U; Mon, 18 Oct 2021 12:20:41 +0200 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1mcPl2-0005I1-UB; Mon, 18 Oct 2021 12:20:40 +0200 Message-ID: <7eed841351748709ec9a173532cd3db99139d69e.camel@pengutronix.de> Subject: Re: [PATCHv2 3/4] media: imx: Forward type of hardware implementation From: Philipp Zabel To: Dorota Czaplejewicz , Steve Longerbeam , Mauro Carvalho Chehab , Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@puri.sm, phone-devel@vger.kernel.org Date: Mon, 18 Oct 2021 12:20:40 +0200 In-Reply-To: <20211017102904.756408-3-dorota.czaplejewicz@puri.sm> References: <20211017102904.756408-1-dorota.czaplejewicz@puri.sm> <20211017102904.756408-3-dorota.czaplejewicz@puri.sm> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-staging@lists.linux.dev On Sun, 2021-10-17 at 13:08 +0200, Dorota Czaplejewicz wrote: > Signed-off-by: Dorota Czaplejewicz > --- > drivers/staging/media/imx/imx-media-capture.c | 14 ++++++++------ > drivers/staging/media/imx/imx-media-utils.c | 3 ++- > drivers/staging/media/imx/imx-media.h | 3 ++- > 3 files changed, 12 insertions(+), 8 deletions(-) >=20 > diff --git a/drivers/staging/media/imx/imx-media-capture.c b/drivers/stag= ing/media/imx/imx-media-capture.c > index fdf0f3a8f253..22208b7ce825 100644 > --- a/drivers/staging/media/imx/imx-media-capture.c > +++ b/drivers/staging/media/imx/imx-media-capture.c [...] > @@ -184,7 +185,8 @@ __capture_try_fmt(struct v4l2_pix_format *pixfmt, str= uct v4l2_rect *compose) > static int capture_try_fmt_vid_cap(struct file *file, void *fh, > struct v4l2_format *f) > { > - __capture_try_fmt(&f->fmt.pix, NULL); > + struct capture_priv *priv =3D video_drvdata(file); Missing blank line. > + __capture_try_fmt(&f->fmt.pix, NULL, priv->type); > return 0; > } > =20 With that fixed, Reviewed-by: Philipp Zabel regards Philipp From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC055C433EF for ; Mon, 18 Oct 2021 10:52:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7872B6103C for ; Mon, 18 Oct 2021 10:52:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7872B6103C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=03pz9fCuSfdx71f8oRncaKGyygefNxOLI88ZTom+YrU=; b=eizdoLB3eok/lP qzrxsMrIei21UYjfKQa7yA7AtNLnNeTIXjZXRE1MBQ17poEWifw3ohrMJaQNanPqLbLaNDKsyseAh nmDlztezAc15I+nlO+ZcmP7OVsWCjOjegygrkFqRuP87XTm+PH7e4PFaJRGlXLmzY+HSsOG/XXoEf 4ZeVHJUFOeJPTg5Ct+POA3sHnZ0ZbWYVNj/dZI+Feuz3EdEz8c3W9HiQtlNONo734osaqjHAPtgSW 1TYMJ3vy8jFEUNJNlxmquKkqOi5Tw+xLPzSn1g89ywIETy1h3rUYf0BxrIapfIEBznKv0ajoT57W+ WQn6wEeltprHvVPvWOeQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcQDl-00F83N-QR; Mon, 18 Oct 2021 10:50:21 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcPl7-00EyYD-Sx for linux-arm-kernel@lists.infradead.org; Mon, 18 Oct 2021 10:20:47 +0000 Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcPl3-0000Du-8U; Mon, 18 Oct 2021 12:20:41 +0200 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1mcPl2-0005I1-UB; Mon, 18 Oct 2021 12:20:40 +0200 Message-ID: <7eed841351748709ec9a173532cd3db99139d69e.camel@pengutronix.de> Subject: Re: [PATCHv2 3/4] media: imx: Forward type of hardware implementation From: Philipp Zabel To: Dorota Czaplejewicz , Steve Longerbeam , Mauro Carvalho Chehab , Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@puri.sm, phone-devel@vger.kernel.org Date: Mon, 18 Oct 2021 12:20:40 +0200 In-Reply-To: <20211017102904.756408-3-dorota.czaplejewicz@puri.sm> References: <20211017102904.756408-1-dorota.czaplejewicz@puri.sm> <20211017102904.756408-3-dorota.czaplejewicz@puri.sm> User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211018_032045_954601_C55CD527 X-CRM114-Status: GOOD ( 12.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 2021-10-17 at 13:08 +0200, Dorota Czaplejewicz wrote: > Signed-off-by: Dorota Czaplejewicz > --- > drivers/staging/media/imx/imx-media-capture.c | 14 ++++++++------ > drivers/staging/media/imx/imx-media-utils.c | 3 ++- > drivers/staging/media/imx/imx-media.h | 3 ++- > 3 files changed, 12 insertions(+), 8 deletions(-) > > diff --git a/drivers/staging/media/imx/imx-media-capture.c b/drivers/staging/media/imx/imx-media-capture.c > index fdf0f3a8f253..22208b7ce825 100644 > --- a/drivers/staging/media/imx/imx-media-capture.c > +++ b/drivers/staging/media/imx/imx-media-capture.c [...] > @@ -184,7 +185,8 @@ __capture_try_fmt(struct v4l2_pix_format *pixfmt, struct v4l2_rect *compose) > static int capture_try_fmt_vid_cap(struct file *file, void *fh, > struct v4l2_format *f) > { > - __capture_try_fmt(&f->fmt.pix, NULL); > + struct capture_priv *priv = video_drvdata(file); Missing blank line. > + __capture_try_fmt(&f->fmt.pix, NULL, priv->type); > return 0; > } > With that fixed, Reviewed-by: Philipp Zabel regards Philipp _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel