From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: dwc2: Fix endless deferral probe From: Stefan Wahren Message-Id: <7ef21b99-67c8-b246-cc9a-b7202264a7a0@i2se.com> Date: Wed, 10 Jan 2018 13:15:48 +0100 To: Arnd Bergmann Cc: Eric Anholt , John Youn , Kishon Vijay Abraham I , Greg Kroah-Hartman , Florian Fainelli , Felipe Balbi , Minas Harutyunyan , Linux ARM , linux-usb@vger.kernel.org List-ID: SGkgQXJuZCwKCkFtIDA5LjAxLjIwMTggdW0gMjI6MzMgc2NocmllYiBBcm5kIEJlcmdtYW5uOgo+ IE9uIFR1ZSwgSmFuIDksIDIwMTggYXQgODoyOCBQTSwgU3RlZmFuIFdhaHJlbiA8c3RlZmFuLndh aHJlbkBpMnNlLmNvbT4gd3JvdGU6Cj4+IFRoZSBkd2MyIFVTQiBkcml2ZXIgdHJpZXMgdG8gZmlu ZCBhIGdlbmVyaWMgUEhZIGZpcnN0IGFuZCB0aGVuIGxvb2sKPj4gZm9yIGFuIG9sZCBzdHlsZSBV U0IgUEhZLiBJbiBjYXNlIG9mIGEgdmFsaWQgZ2VuZXJpYyBQSFkgbm9kZSB3aXRob3V0Cj4+IGEg UEhZIGRyaXZlciwgdGhlIFBIWSBsYXllciB3aWxsIHJldHVybiAtRVBST0JFX0RFRkVSIGZvcmV2 ZXIuIFNvIGR3YzIKPj4gd2lsbCBuZXZlciB0cmllcyBmb3IgYW4gVVNCIFBIWS4KPj4KPj4gRml4 IHRoaXMgaXNzdWUgYnkgZmluZGluZyBhIGdlbmVyaWMgUEhZIGFuZCBhbiBvbGQgc3R5bGUgVVNC IFBIWQo+PiBhdCBvbmNlLgo+IFRoaXMgd291bGQgZml4IG9ubHkgb25lIG9mIHRoZSBVU0IgY29u dHJvbGxlcnMgKGR3YzIpLCBidXQgbm90IHRoZSBvdGhlcnMKPiB0aGF0IGFyZSBhZmZlY3RlZC4g QXMgSSB3cm90ZSBpbiBteSBzdWdnZXN0ZWQgcGF0Y2gsIGR3YzMgYXBwZWFycyB0byBiZQo+IGFm ZmVjdGVkIHRoZSBzYW1lIHdheSwgYW5kIGFsbCBvdGhlciBob3N0IGRyaXZlcnMgdGhhdCBjYWxs IHVzYl9hZGRfaGNkKCkKPiB3aXRob3V0IGZpcnN0IHNldHRpbmcgaGNkLT5waHkgd291bGQgc3Vm ZmVyIGZyb20gdGhpcyBhcyB3ZWxsLgo+Cj4gSWYgd2UgZ28gZG93biB0aGUgcm91dGUgb2YgYWRk cmVzc2luZyBpdCBoZXJlIGluIHRoZSBoY2QgZHJpdmVycywgd2Ugc2hvdWxkCj4gYXQgbGVhc3Qg Y2hhbmdlIGFsbCB0aHJlZSBvZiB0aG9zZSwgYW5kIGhvcGUgdGhpcyBkb2Vzbid0IHJlZ3Jlc3Mg aW4KPiBhbm90aGVyIHdheS4KPgo+ICAgICAgICAgQXJuZAoKaSBmdWxseSB1bnRlcnN0YW5kLiBC dXQgd2UgbGVhdmluZyB0aGUgcGF0aCBvZiAiZml4aW5nIGEgY3JpdGljYWwgaXNzdWUgCm9uIEJD TTI4MzUiIGFuZCBnbyB0byAiZml4aW5nIG11bHRpcGxlIFVTQiBob3N0IGNvbnRyb2xsZXIiLiBJ IGRvIHRoaXMgCmFsbCBpbiBteSBzcGFyZSB0aW1lIGFuZCBkb24ndCBoYXZlIGFueSBvZiB0aGUg b3RoZXIgVVNCIGNvbnRyb2xsZXIgCmF2YWlsYWJsZS4gU28gYmVmb3JlIGkgcHJvY2VlZCB3aXRo IGFueSBvdGhlciBwYXRjaCBpIGxpa2Ugc28gc2VlIHNvbWUgCmZlZWRiYWNrIGZyb20gSm9obiwg R3JlZyBvciBGZWxpcGUuCgpBZnRlciBmaW5hbGl6aW5nIHRoaXMgcGF0Y2ggaSB0aGluayB0aGUg Y2hhbmNlIGlzIGxpdHRsZSB0aGF0IHRoaXMgd291bGQgCmJlIGFwcGxpZWQgdG8gNC4xNS4gU28g aSBzZWVtcyB0byBtZSB0aGF0IHdlIHN0aWxsIHJldmVydCBteSBEVCBjbGVhbiB1cCAKcGF0Y2gu CgpTdGVmYW4KLS0tClRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5l ICJ1bnN1YnNjcmliZSBsaW51eC11c2IiIGluCnRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpv cmRvbW9Admdlci5rZXJuZWwub3JnCk1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2Vy Lmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: stefan.wahren@i2se.com (Stefan Wahren) Date: Wed, 10 Jan 2018 13:15:48 +0100 Subject: [PATCH] usb: dwc2: Fix endless deferral probe In-Reply-To: References: <1515526134-2148-1-git-send-email-stefan.wahren@i2se.com> Message-ID: <7ef21b99-67c8-b246-cc9a-b7202264a7a0@i2se.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Arnd, Am 09.01.2018 um 22:33 schrieb Arnd Bergmann: > On Tue, Jan 9, 2018 at 8:28 PM, Stefan Wahren wrote: >> The dwc2 USB driver tries to find a generic PHY first and then look >> for an old style USB PHY. In case of a valid generic PHY node without >> a PHY driver, the PHY layer will return -EPROBE_DEFER forever. So dwc2 >> will never tries for an USB PHY. >> >> Fix this issue by finding a generic PHY and an old style USB PHY >> at once. > This would fix only one of the USB controllers (dwc2), but not the others > that are affected. As I wrote in my suggested patch, dwc3 appears to be > affected the same way, and all other host drivers that call usb_add_hcd() > without first setting hcd->phy would suffer from this as well. > > If we go down the route of addressing it here in the hcd drivers, we should > at least change all three of those, and hope this doesn't regress in > another way. > > Arnd i fully unterstand. But we leaving the path of "fixing a critical issue on BCM2835" and go to "fixing multiple USB host controller". I do this all in my spare time and don't have any of the other USB controller available. So before i proceed with any other patch i like so see some feedback from John, Greg or Felipe. After finalizing this patch i think the chance is little that this would be applied to 4.15. So i seems to me that we still revert my DT clean up patch. Stefan