All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Smart <james.smart@broadcom.com>
To: Steffen Maier <maier@linux.vnet.ibm.com>,
	James Smart <jsmart2021@gmail.com>,
	linux-scsi@vger.kernel.org
Cc: Dick Kennedy <dick.kennedy@broadcom.com>
Subject: Re: [PATCH 06/13] lpfc: Add 64G link speed support
Date: Mon, 29 Jan 2018 10:32:58 -0800	[thread overview]
Message-ID: <7efadbc3-60dc-b134-26ff-d4d89421488c@broadcom.com> (raw)
In-Reply-To: <bdaf0bdc-576d-4052-4e63-238d773b26ce@linux.vnet.ibm.com>

On 1/29/2018 3:45 AM, Steffen Maier wrote:
> @@ -2966,6 +2975,9 @@ struct lpfc_mbx_read_top {
>>   #define LPFC_LINK_SPEED_10GHZ    0x40
>>   #define LPFC_LINK_SPEED_16GHZ    0x80
>>   #define LPFC_LINK_SPEED_32GHZ    0x90
>> +#define LPFC_LINK_SPEED_64GHZ    0xA0
>> +#define LPFC_LINK_SPEED_128GHZ    0xB0
>> +#define LPFC_LINK_SPEED_2568GHZ    0xC0
>                               ^
> typo? 2568 => 256
>
> The new 128 and 256 definitions do not seem to be used in this patch set?
>

Yep. And not used yet.  I'll fix in a repost.  For the repost, I'll wait 
until the other patches have a review.

-- james

  reply	other threads:[~2018-01-29 18:33 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-26 19:31 [PATCH 00/13] lpfc new hardware patches for 12.0.0.0 James Smart
2018-01-26 19:31 ` [PATCH 01/13] lpfc: Rework lpfc to allow different sli4 cq and eq handlers James Smart
2018-02-07  0:26   ` Martin K. Petersen
2018-02-07  2:01     ` James Smart
2018-01-26 19:31 ` [PATCH 02/13] lpfc: Rework sli4 doorbell infrastructure James Smart
2018-01-26 19:31 ` [PATCH 03/13] lpfc: Add SLI-4 if_type=6 support to the code base James Smart
2018-01-26 19:31 ` [PATCH 04/13] lpfc: Add push-to-adapter support to sli4 James Smart
2018-02-07  0:27   ` Martin K. Petersen
2018-01-26 19:31 ` [PATCH 05/13] lpfc: Add PCI Ids for if_type=6 hardware James Smart
2018-01-26 19:31 ` [PATCH 06/13] lpfc: Add 64G link speed support James Smart
2018-01-29 11:45   ` Steffen Maier
2018-01-29 18:32     ` James Smart [this message]
2018-01-26 19:31 ` [PATCH 07/13] lpfc: Add if_type=6 support for cycling valid bits James Smart
2018-02-07  0:28   ` Martin K. Petersen
2018-01-26 19:31 ` [PATCH 08/13] lpfc: Enable fw download on if_type=6 devices James Smart
2018-01-26 19:31 ` [PATCH 09/13] lpfc: Add embedded data pointers for enhanced performance James Smart
2018-01-26 19:31 ` [PATCH 10/13] lpfc: Fix nvme embedded io length on new hardware James Smart
2018-01-26 19:31 ` [PATCH 11/13] lpfc: Work around NVME cmd iu SGL type James Smart
2018-01-26 19:31 ` [PATCH 12/13] lpfc: update driver version to 12.0.0.0 James Smart
2018-01-26 19:31 ` [PATCH 13/13] lpfc: Update 12.0.0.0 modified files for 2018 Copyright James Smart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7efadbc3-60dc-b134-26ff-d4d89421488c@broadcom.com \
    --to=james.smart@broadcom.com \
    --cc=dick.kennedy@broadcom.com \
    --cc=jsmart2021@gmail.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=maier@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.