All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Smart <jsmart2021@gmail.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: linux-scsi@vger.kernel.org, James Smart <james.smart@broadcom.com>
Subject: Re: [PATCH] lpfc: Fix nvme io stoppage after link bounce
Date: Thu, 22 Jun 2017 08:52:14 -0700	[thread overview]
Message-ID: <7f10cbae-a88e-f5a8-d54d-a22a543438e0@gmail.com> (raw)
In-Reply-To: <20170622074142.GB5670@linux-x5ow.site>

On 6/22/2017 12:41 AM, Johannes Thumshirn wrote:
> On Wed, Jun 21, 2017 at 10:37:58AM -0700, James Smart wrote:
> [...]
>> -	/*
>> -	 * Catch race where our node has transitioned, but the
>> -	 * transport is still transitioning.
>> -	 */
> 
> 
> The patch looks fine but can you please explain why the above race can't
> happen anymore?
> 
> Thanks,
> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
> 

well, the primary reason is the code that was removed was bogus to begin 
with. Abort of an io/exchange, if its active, needs to occur on the link 
regardless of the ndlp state. This it simply needed to occur. As not 
checks on ndlp state are needed, there is no race.

-- james

  reply	other threads:[~2017-06-22 15:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-21 17:37 [PATCH] lpfc: Fix nvme io stoppage after link bounce James Smart
2017-06-22  7:41 ` Johannes Thumshirn
2017-06-22 15:52   ` James Smart [this message]
2017-06-22 18:50     ` Johannes Thumshirn
2017-06-26 17:12 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7f10cbae-a88e-f5a8-d54d-a22a543438e0@gmail.com \
    --to=jsmart2021@gmail.com \
    --cc=james.smart@broadcom.com \
    --cc=jthumshirn@suse.de \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.