From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [RFC PATCH 4/4] plugins: gemalto: fix incomplete at-chat shutdown
Date: Tue, 18 Aug 2020 09:33:14 -0500 [thread overview]
Message-ID: <7f213a9f-4fcd-dca9-c643-dd79c440c435@gmail.com> (raw)
In-Reply-To: <13183792-de6e-c20d-cfbb-e9d86a136153@geanix.com>
[-- Attachment #1: Type: text/plain, Size: 727 bytes --]
Hi Martin,
>> Instead of this dance of opening / closing the chat in order to force-cancel
>> the 'AT' command queued in gemalto_enable(), maybe there should be something
>> in GAtChat itself to handle this case.
<snip>
>
> There's also the retry logic used on quectel modems with auto-detection of baud
> rates:
> https://git.kernel.org/pub/scm/network/ofono/ofono.git/tree/plugins/quectel.c#n1082
>
Ah right, I completely forgot about g_at_chat_retry that you added for exactly
the use case I outlined above. Thanks for the reminder.
Maybe we should just add this modem poking logic into
drivers/atmodem/atutil.[ch] or something if it will be used across multiple drivers.
Regards,
-Denis
prev parent reply other threads:[~2020-08-18 14:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-15 21:43 [RFC PATCH 0/4] gemalto: USB ethernet data path for ELS81x Sergey Matyukevich
2020-08-15 21:43 ` [RFC PATCH 1/4] drivers: gemalto: add gprs-context driver Sergey Matyukevich
2020-08-17 19:23 ` Denis Kenzior
2020-08-15 21:43 ` [RFC PATCH 2/4] plugins: udevng: detect gemalto network interfaces Sergey Matyukevich
2020-08-15 21:43 ` [RFC PATCH 3/4] plugins: gemalto: add optional gprs-context driver Sergey Matyukevich
2020-08-15 21:43 ` [RFC PATCH 4/4] plugins: gemalto: fix incomplete at-chat shutdown Sergey Matyukevich
2020-08-17 16:56 ` Sergey Matyukevich
2020-08-17 19:54 ` Denis Kenzior
2020-08-17 20:22 ` Sergey Matyukevich
2020-08-18 9:06 ` Martin =?unknown-8bit?q?Hundeb=C3=B8ll?=
2020-08-18 14:33 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f213a9f-4fcd-dca9-c643-dd79c440c435@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.