From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Paulo Zanoni <paulo.r.zanoni@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/8] drm/i915/gen9: fix the WaWmMemoryReadLatency implementation
Date: Tue, 13 Sep 2016 14:28:40 +0200 [thread overview]
Message-ID: <7f216c7a-7b05-799b-1671-2c9b0bfa037b@linux.intel.com> (raw)
In-Reply-To: <1473209539-6689-5-git-send-email-paulo.r.zanoni@intel.com>
Op 07-09-16 om 02:52 schreef Paulo Zanoni:
> Bspec says:
> "The mailbox response data may not account for memory read latency.
> If the mailbox response data for level 0 is 0us, add 2 microseconds
> to the result for each valid level."
>
> This means we should only do the +2 in case wm[0] == 0, not always.
>
> So split the sanitizing implementation from the WA implementation and
> fix the WA implementation.
>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
This one probably needs a dim fixes $commit, just like patch 6 and 7.
For the rest the changes look sane, so with the review comments in the other patches addressed:
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-09-13 12:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 0:52 [PATCH 0/8] SKL/KBL watermark fixes Paulo Zanoni
2016-09-07 0:52 ` [PATCH 1/8] drm/i915: SAGV is not SKL-only, so rename a few things Paulo Zanoni
2016-09-07 16:05 ` Lyude
2016-09-09 20:16 ` Zanoni, Paulo R
2016-09-07 0:52 ` [PATCH 2/8] drm/i915: introduce intel_has_sagv() Paulo Zanoni
2016-09-07 16:12 ` Lyude
2016-09-08 8:59 ` Jani Nikula
2016-09-08 14:43 ` Lyude Paul
2016-09-09 8:06 ` Jani Nikula
2016-09-09 19:51 ` Zanoni, Paulo R
2016-09-10 10:49 ` Ville Syrjälä
2016-09-12 9:48 ` Jani Nikula
2016-09-07 0:52 ` [PATCH 3/8] drm/i915/kbl: KBL also needs to run the SAGV code Paulo Zanoni
2016-09-07 16:11 ` Ville Syrjälä
2016-09-07 16:17 ` Lyude
2016-09-13 19:34 ` Zanoni, Paulo R
2016-09-14 9:59 ` Jani Nikula
2016-09-14 13:32 ` Zanoni, Paulo R
2016-09-15 7:15 ` Jani Nikula
2016-09-07 0:52 ` [PATCH 4/8] drm/i915/gen9: fix the WaWmMemoryReadLatency implementation Paulo Zanoni
2016-09-13 12:28 ` Maarten Lankhorst [this message]
2016-09-07 0:52 ` [PATCH 5/8] drm/i915/gen9: minimum scanlines for Y tile is not always 4 Paulo Zanoni
2016-09-07 23:03 ` Lyude
2016-09-13 20:22 ` Zanoni, Paulo R
2016-09-07 0:52 ` [PATCH 6/8] drm/i915/gen9: fix plane_blocks_per_line on watermarks calculations Paulo Zanoni
2016-09-07 0:52 ` [PATCH 7/8] drm/i915/gen9: fix the watermark res_blocks value Paulo Zanoni
2016-09-07 0:52 ` [PATCH 8/8] drm/i915/gen9: implement missing case for SKL watermarks calculation Paulo Zanoni
2016-09-07 1:24 ` ✗ Fi.CI.BAT: warning for SKL/KBL watermark fixes Patchwork
2016-09-07 23:54 ` [PATCH 0/8] " Lyude
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f216c7a-7b05-799b-1671-2c9b0bfa037b@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.