From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH v6 11/14] memory: tegra: Support derated timings on Tegra210 Date: Fri, 10 Apr 2020 02:44:16 +0300 Message-ID: <7f23f140-4c56-3d9a-946e-f29bc569f40c@gmail.com> References: <20200409175238.3586487-1-thierry.reding@gmail.com> <20200409175238.3586487-12-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20200409175238.3586487-12-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Thierry Reding , Rob Herring Cc: Jon Hunter , Michael Turquette , Stephen Boyd , Joseph Lo , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-tegra@vger.kernel.org 09.04.2020 20:52, Thierry Reding пишет: ... > tegra210_emc_debugfs_init(emc); > > + cd = devm_thermal_of_cooling_device_register(emc->dev, np, "emc", emc, > + &tegra210_emc_cd_ops); > + if (IS_ERR(cd)) { > + err = PTR_ERR(cd); > + dev_err(emc->dev, "failed to register cooling device: %d\n", > + err); > + goto detach; I think it's not really worthwhile to fail whole EMC driver because of the failed CDEV. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13F44C2BB1D for ; Thu, 9 Apr 2020 23:44:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E077B208E4 for ; Thu, 9 Apr 2020 23:44:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z+OFqTSE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726916AbgDIXoV (ORCPT ); Thu, 9 Apr 2020 19:44:21 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:43195 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726327AbgDIXoV (ORCPT ); Thu, 9 Apr 2020 19:44:21 -0400 Received: by mail-lj1-f193.google.com with SMTP id h25so343169lja.10; Thu, 09 Apr 2020 16:44:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=eplP7HigK8Ewza+SjO81i9tb9swgjSdpeTM2vE+t2FI=; b=Z+OFqTSEtWD+OR0/pzr+dM8ugXHWeikyhxm/KgbzcPr0hpv7bgSSKGq1REFh393r9Y +cjiNaten3HWmd7TxIHO3zqw54SrSOcpfrZFCIrd6ZPeX8z3tuYZGZybmwKgVsYzYMZv eaHQahH+nMqmL8ymsrSYu0pUiacrioYnJ+jb4B6zLDyFv07S2Qenm395qW5Z3Ua0fx6y zL6ESY9Mh8/zrOc1NJEE1+dZEp9WaL/bG8glG3/JD0+fyAPuMQSuHsCUVj0MRqVMxj9o VmddSw5J9OruFahcTsOUaNrxs4X1GoXvMZIfHrSbUf+tKQtQIkzoFZvCZDQ5jUc14PLx nViw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=eplP7HigK8Ewza+SjO81i9tb9swgjSdpeTM2vE+t2FI=; b=EOnMeZe7c9xA2nP2VytTEEU3JPgaHLGV2ZEpRo2Hc6gfVeHJy1Ad5h3vmbEXg+m5J8 5nJaPXUuobpIgh6UVB3zyZ7fNMKm88tkMoXK1g8B2RUo/io3YWqgQj0cy47IZDEqJR3x EMyePe8wGGSmFyuhSLMEJJl0kaRfMJjBHBd87H4qgHUP861v5DZxqQO3vp3+TpAbYjPx nKEjE6Ark+3aFgWCJMo940P6xR0Y7wUYplAiHJoUaSh01yulmkHJP+nKUdFImQGMyO00 SMVVYdsn/Ghfse57Y12+KtazSuAkYeGT/Pm0pRl9Qpt2GSlXDX7bGdnwFBlsF86dGyOi AKfg== X-Gm-Message-State: AGi0PuaEQF5Vi8aC0E7bfXrGubTANfFSuWM9W4wjZhj/QYfrf7yBw3JX EyGTHfYF56gnhHlEm+qWGkM= X-Google-Smtp-Source: APiQypKOjhusE3Y7SNrXp1CXEoE/mqfoQN6rYgf5UIc2VAPmQ3PefCXTqRsbwrmhttzvDhBHDOpurA== X-Received: by 2002:a2e:8511:: with SMTP id j17mr1356714lji.292.1586475858785; Thu, 09 Apr 2020 16:44:18 -0700 (PDT) Received: from [192.168.2.145] (ppp91-78-208-152.pppoe.mtu-net.ru. [91.78.208.152]) by smtp.googlemail.com with ESMTPSA id 64sm283254lfh.32.2020.04.09.16.44.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Apr 2020 16:44:17 -0700 (PDT) Subject: Re: [PATCH v6 11/14] memory: tegra: Support derated timings on Tegra210 To: Thierry Reding , Rob Herring Cc: Jon Hunter , Michael Turquette , Stephen Boyd , Joseph Lo , linux-tegra@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20200409175238.3586487-1-thierry.reding@gmail.com> <20200409175238.3586487-12-thierry.reding@gmail.com> From: Dmitry Osipenko Message-ID: <7f23f140-4c56-3d9a-946e-f29bc569f40c@gmail.com> Date: Fri, 10 Apr 2020 02:44:16 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200409175238.3586487-12-thierry.reding@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org 09.04.2020 20:52, Thierry Reding пишет: ... > tegra210_emc_debugfs_init(emc); > > + cd = devm_thermal_of_cooling_device_register(emc->dev, np, "emc", emc, > + &tegra210_emc_cd_ops); > + if (IS_ERR(cd)) { > + err = PTR_ERR(cd); > + dev_err(emc->dev, "failed to register cooling device: %d\n", > + err); > + goto detach; I think it's not really worthwhile to fail whole EMC driver because of the failed CDEV. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33284C2BA19 for ; Thu, 9 Apr 2020 23:44:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F07CB20679 for ; Thu, 9 Apr 2020 23:44:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XEtaW1fD"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z+OFqTSE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F07CB20679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y7wXaJV/EiDTD1dRRS4b+QUQ8tz7Vp80mabVD52elEU=; b=XEtaW1fD9nSD6r KUsGBjT5Yjcqb8O5ulCfFc4PBbLgY57fujdTgmTUQQADAaH39AvZY7M03S9Ok3WRUnXGS/urMkgPg P2DjnlQjJ+/ySXsK3j0kDkdrpAfmmVfq0eXPNUW88Vaufu3i0fCAl7EOk8VRTYjWnRtFC9YdgshfB 0vGDeNiz5TOdp/gKY53Geqv9MHDngdLkPTQmVUnE96vc1iKpGU3z86eHIYG2zRqXQGynCzh/6rVXU DnLQ97kCPI4ibSgH1ZE/9LucO1oxmeOcEaHka1Rw3Tc7L/oa4obnXz0pvOR4CnqPym24PH2/jBtnD adN3c9tPa0MLN7Coi0dg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jMgqO-0006Nh-0v; Thu, 09 Apr 2020 23:44:24 +0000 Received: from mail-lj1-x241.google.com ([2a00:1450:4864:20::241]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jMgqL-0006NO-5y for linux-arm-kernel@lists.infradead.org; Thu, 09 Apr 2020 23:44:22 +0000 Received: by mail-lj1-x241.google.com with SMTP id m8so391020lji.1 for ; Thu, 09 Apr 2020 16:44:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=eplP7HigK8Ewza+SjO81i9tb9swgjSdpeTM2vE+t2FI=; b=Z+OFqTSEtWD+OR0/pzr+dM8ugXHWeikyhxm/KgbzcPr0hpv7bgSSKGq1REFh393r9Y +cjiNaten3HWmd7TxIHO3zqw54SrSOcpfrZFCIrd6ZPeX8z3tuYZGZybmwKgVsYzYMZv eaHQahH+nMqmL8ymsrSYu0pUiacrioYnJ+jb4B6zLDyFv07S2Qenm395qW5Z3Ua0fx6y zL6ESY9Mh8/zrOc1NJEE1+dZEp9WaL/bG8glG3/JD0+fyAPuMQSuHsCUVj0MRqVMxj9o VmddSw5J9OruFahcTsOUaNrxs4X1GoXvMZIfHrSbUf+tKQtQIkzoFZvCZDQ5jUc14PLx nViw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=eplP7HigK8Ewza+SjO81i9tb9swgjSdpeTM2vE+t2FI=; b=Mven17/isst9MrF+pZyKVw7PW45JISy6cZ1LbnY3BLgX/zSUOZapgRnWKuPqsYCD6c J7XX3q4Xm6R/9ntDZFVlBRWhatNzRT773eF+oS0RDAGOLtr/Hs9AdP9KhjRfh1mtpuCZ 9YN5yXijS8n9VK67K4o0SzrEAiBMZYb1u9CfpI1I0Gvk7UL1i92uMAntKz4O/PVKfpFc PCYdrTiezk1byL2/onLJ9pPEZSeW+L7zk4Pg4HxN1ZTIL6OYSod9TkblJEx64RS3y+wz OraYq2coyZtj8wClQD/bpisvd57e4ELXBqJAg8EQ1Av5YlSRB0JuOk+C1Pq5LXK6Y1Tq pYSQ== X-Gm-Message-State: AGi0PualUq4AZQYSCBR4Ro96Jt1Ox6kLLrfvFmwa9zKfHnDE1RBeBtRK HD4vzHRdHVExOA5vmRGmNZDG6M4Z X-Google-Smtp-Source: APiQypKOjhusE3Y7SNrXp1CXEoE/mqfoQN6rYgf5UIc2VAPmQ3PefCXTqRsbwrmhttzvDhBHDOpurA== X-Received: by 2002:a2e:8511:: with SMTP id j17mr1356714lji.292.1586475858785; Thu, 09 Apr 2020 16:44:18 -0700 (PDT) Received: from [192.168.2.145] (ppp91-78-208-152.pppoe.mtu-net.ru. [91.78.208.152]) by smtp.googlemail.com with ESMTPSA id 64sm283254lfh.32.2020.04.09.16.44.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Apr 2020 16:44:17 -0700 (PDT) Subject: Re: [PATCH v6 11/14] memory: tegra: Support derated timings on Tegra210 To: Thierry Reding , Rob Herring References: <20200409175238.3586487-1-thierry.reding@gmail.com> <20200409175238.3586487-12-thierry.reding@gmail.com> From: Dmitry Osipenko Message-ID: <7f23f140-4c56-3d9a-946e-f29bc569f40c@gmail.com> Date: Fri, 10 Apr 2020 02:44:16 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200409175238.3586487-12-thierry.reding@gmail.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200409_164421_243803_AE440723 X-CRM114-Status: GOOD ( 11.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Stephen Boyd , Michael Turquette , Jon Hunter , Joseph Lo , linux-tegra@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org MDkuMDQuMjAyMCAyMDo1MiwgVGhpZXJyeSBSZWRpbmcg0L/QuNGI0LXRgjoKLi4uCj4gIAl0ZWdy YTIxMF9lbWNfZGVidWdmc19pbml0KGVtYyk7Cj4gIAo+ICsJY2QgPSBkZXZtX3RoZXJtYWxfb2Zf Y29vbGluZ19kZXZpY2VfcmVnaXN0ZXIoZW1jLT5kZXYsIG5wLCAiZW1jIiwgZW1jLAo+ICsJCQkJ CQkgICAgICZ0ZWdyYTIxMF9lbWNfY2Rfb3BzKTsKPiArCWlmIChJU19FUlIoY2QpKSB7Cj4gKwkJ ZXJyID0gUFRSX0VSUihjZCk7Cj4gKwkJZGV2X2VycihlbWMtPmRldiwgImZhaWxlZCB0byByZWdp c3RlciBjb29saW5nIGRldmljZTogJWRcbiIsCj4gKwkJCWVycik7Cgo+ICsJCWdvdG8gZGV0YWNo OwoKSSB0aGluayBpdCdzIG5vdCByZWFsbHkgd29ydGh3aGlsZSB0byBmYWlsIHdob2xlIEVNQyBk cml2ZXIgYmVjYXVzZSBvZgp0aGUgZmFpbGVkIENERVYuCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdAps aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==