From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F178C4332F for ; Thu, 28 Apr 2022 06:53:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244571AbiD1G5F (ORCPT ); Thu, 28 Apr 2022 02:57:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244570AbiD1G5E (ORCPT ); Thu, 28 Apr 2022 02:57:04 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C679986CA for ; Wed, 27 Apr 2022 23:53:49 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id k23so7629439ejd.3 for ; Wed, 27 Apr 2022 23:53:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=2VtYpl+AopG0sr9SMMb9GWmnfMrojG66n7RjufImm50=; b=lwaaQoJPHunxuYnucsJqsKlb/ZFMAcQ+0k8j6mvSEbAo+tDnwkfLRmrWMus5ro/udm FOHnvHIg+Od8zeBv9pcz/+cSrUdxgqQjP7LUfO5NpvqYDQmijdUhOcA1fi34Aq+v38MX LhJVz0OpmKIEFVZr1zh0LqshKffrL5kTQmEbOHNw8+fdZsutWv+daA9N/88TA6yG2Me+ IP84bUWImyT7N4KoEfs6JcgGo0jE3XVl0Y+aXu9Uo8Eujf8kUR0SMvaMN82ptr0AJudN A4IHMQF5otBDYl5yva1nkfVg+FjDmhen4fiFXu/kXW6txMcdM5evUL/uXw7KbIfuXHKO /PVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=2VtYpl+AopG0sr9SMMb9GWmnfMrojG66n7RjufImm50=; b=jlZgB89bwuXjcXKheUMBT2R7O7sai/XCm963Quyo/0AkK8494kWvljQIrkfwQEKSmR r6TBhDKu9xvkZEFPblscOmDmInAN98UUuPPr78101OlQXBsvr9yI58rV4yxUGOZcbYPE FuaBCCPmXNy8By6RK1pTt9zO7QIyYcOXzpWfp/GIv0Tuz5W0U6VajafUskdJoJmFdgNj Ngbr/kx23lVhP/wQwtiGGA9QdQ+kD0Pv/yfRykwy3Tl7N1lw7ezo5JbUiKYxWzT4xDaS mL5dVQ+9AmbnhEIJ1+3/lBBk62h62W1J8i8HqspaaHmgmSfg4BKSPXEGrvUnqo0ULdKn 0rIA== X-Gm-Message-State: AOAM531qdWBKkXVNwNW+GZBNFWr02py32lCcj0mZADixqFnWtW8NvQ0M TwVhEtNHTB4CZiXpiXy2WCbXRA== X-Google-Smtp-Source: ABdhPJzso+XpXZx+m3nRJuf0ndPiYOfzhdXdRErjmKATg8VtTt/Cvcsd1y1NHq262yirrd9t4vNvdQ== X-Received: by 2002:a17:907:6090:b0:6f0:2a64:2ef7 with SMTP id ht16-20020a170907609000b006f02a642ef7mr29814689ejc.476.1651128828187; Wed, 27 Apr 2022 23:53:48 -0700 (PDT) Received: from [192.168.0.160] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id o22-20020a170906289600b006e44a0c1105sm7920189ejd.46.2022.04.27.23.53.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Apr 2022 23:53:47 -0700 (PDT) Message-ID: <7f435547-35f5-7885-3b1d-159199ca201a@linaro.org> Date: Thu, 28 Apr 2022 08:53:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] dt-bindings: pinctrl: aspeed: Drop referenced nodes in examples Content-Language: en-US To: Joel Stanley , Rob Herring Cc: Andrew Jeffery , Linus Walleij , Krzysztof Kozlowski , linux-aspeed , OpenBMC Maillist , "open list:GPIO SUBSYSTEM" , devicetree , Linux ARM , Linux Kernel Mailing List References: <20220422192139.2592632-1-robh@kernel.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 27/04/2022 10:40, Joel Stanley wrote: > On Fri, 22 Apr 2022 at 19:21, Rob Herring wrote: >> >> The additional nodes in the example referenced from the pinctrl node >> 'aspeed,external-nodes' properties are either incorrect (aspeed,ast2500-lpc) >> or not documented with a schema (aspeed,ast2500-gfx). There's no need to >> show these nodes as part of the pinctrl example, so just remove them. >> >> Signed-off-by: Rob Herring > > Nak. > > This removes the information on how to use the bindings. Surely we > prefer to over document rather than under document? There is no need to document consumers of generic providers, like syscon, clock or pinctrl. These are already well documented. The examples of consumers here do not bring any additional value. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76EF2C433EF for ; Thu, 28 Apr 2022 06:54:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xRz2eUS+/1YFL5hGQ1G/3zer871j3mUHbfgUEB+VYXg=; b=OVyTwTzO/B0yFG XHkvymIEtDZsAnJFsdjMkr9p8yym9EP64zZQLFK5rv9SO/D/e87Mf9HiX7D9BwNx8K/nUsboWR6YY o1r/gBLZWQYbrPJyVgHo8t+WYHnGfj9p2b/6TQhsM+bKsx0CKBfCuJIcnZhJgIVIjpgjq6eM02PQt 5F7E4117tj27iz0JJe0fGSD+AbdZS/GvrURdBGnXvNOu6TbUwEg5ry7xi9u0NloH+m9Q1GsM/y/U5 X3C+ZvtUpzSdP4ISL4hIqTUeBipWCz4KFS60iy+HnKm+U/vcbMcYBpu1LOW5N1PJuyEL8gzV6P/bU d3fMcXnjHZtS6ESOOTFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1njy2C-004yvt-GA; Thu, 28 Apr 2022 06:53:52 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1njy29-004yuW-QW for linux-arm-kernel@lists.infradead.org; Thu, 28 Apr 2022 06:53:51 +0000 Received: by mail-ej1-x634.google.com with SMTP id kq17so7616179ejb.4 for ; Wed, 27 Apr 2022 23:53:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=2VtYpl+AopG0sr9SMMb9GWmnfMrojG66n7RjufImm50=; b=lwaaQoJPHunxuYnucsJqsKlb/ZFMAcQ+0k8j6mvSEbAo+tDnwkfLRmrWMus5ro/udm FOHnvHIg+Od8zeBv9pcz/+cSrUdxgqQjP7LUfO5NpvqYDQmijdUhOcA1fi34Aq+v38MX LhJVz0OpmKIEFVZr1zh0LqshKffrL5kTQmEbOHNw8+fdZsutWv+daA9N/88TA6yG2Me+ IP84bUWImyT7N4KoEfs6JcgGo0jE3XVl0Y+aXu9Uo8Eujf8kUR0SMvaMN82ptr0AJudN A4IHMQF5otBDYl5yva1nkfVg+FjDmhen4fiFXu/kXW6txMcdM5evUL/uXw7KbIfuXHKO /PVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=2VtYpl+AopG0sr9SMMb9GWmnfMrojG66n7RjufImm50=; b=g4gWqzRxaE7mIh8smgv8vGtZGfMkdNDPHPuu/eBjQaYpr+YZqb0O77QqxwGyIH/znL RD0kdokNfPDFvu5vASlmE3Lcyv7O+7b8leoK+JeJuHPIKB4tvPUMqzxZh49a7hAiWqBp tbND4xz3tHl0Oo0gts8P+YDJu2gZrSkBd+wjFiLVrrpaclFCdi7Tvb9ymfutM/19j7Wy Mi0gaiVaI88nFIAKYKqGPGrx3z7GkNbU81/F+L8+vKDdErKJfv1TrZLQyi7EIu5Nyew7 O7er1q2zmf0GyrK0Gy/x1To0FMwTZLviy7KF5dPLGdXBjDooO9FOahlDKvdemtpgDDSx oCOA== X-Gm-Message-State: AOAM532+uB86m23mGNXGx/y2VL2RttqJpflioYHQ8R2f83c/Iiiohinx J7e4qq99POFnS4MvnJ7yBbbU8g== X-Google-Smtp-Source: ABdhPJzso+XpXZx+m3nRJuf0ndPiYOfzhdXdRErjmKATg8VtTt/Cvcsd1y1NHq262yirrd9t4vNvdQ== X-Received: by 2002:a17:907:6090:b0:6f0:2a64:2ef7 with SMTP id ht16-20020a170907609000b006f02a642ef7mr29814689ejc.476.1651128828187; Wed, 27 Apr 2022 23:53:48 -0700 (PDT) Received: from [192.168.0.160] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id o22-20020a170906289600b006e44a0c1105sm7920189ejd.46.2022.04.27.23.53.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Apr 2022 23:53:47 -0700 (PDT) Message-ID: <7f435547-35f5-7885-3b1d-159199ca201a@linaro.org> Date: Thu, 28 Apr 2022 08:53:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] dt-bindings: pinctrl: aspeed: Drop referenced nodes in examples Content-Language: en-US To: Joel Stanley , Rob Herring Cc: Andrew Jeffery , Linus Walleij , Krzysztof Kozlowski , linux-aspeed , OpenBMC Maillist , "open list:GPIO SUBSYSTEM" , devicetree , Linux ARM , Linux Kernel Mailing List References: <20220422192139.2592632-1-robh@kernel.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220427_235349_905891_1AEFFDC0 X-CRM114-Status: GOOD ( 12.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 27/04/2022 10:40, Joel Stanley wrote: > On Fri, 22 Apr 2022 at 19:21, Rob Herring wrote: >> >> The additional nodes in the example referenced from the pinctrl node >> 'aspeed,external-nodes' properties are either incorrect (aspeed,ast2500-lpc) >> or not documented with a schema (aspeed,ast2500-gfx). There's no need to >> show these nodes as part of the pinctrl example, so just remove them. >> >> Signed-off-by: Rob Herring > > Nak. > > This removes the information on how to use the bindings. Surely we > prefer to over document rather than under document? There is no need to document consumers of generic providers, like syscon, clock or pinctrl. These are already well documented. The examples of consumers here do not bring any additional value. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BDF93C433F5 for ; Fri, 29 Apr 2022 12:15:22 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KqWf10NV7z3bl5 for ; Fri, 29 Apr 2022 22:15:21 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=lwaaQoJP; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2a00:1450:4864:20::630; helo=mail-ej1-x630.google.com; envelope-from=krzysztof.kozlowski@linaro.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=lwaaQoJP; dkim-atps=neutral Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KpmYY0TF8z2xvW for ; Thu, 28 Apr 2022 16:53:51 +1000 (AEST) Received: by mail-ej1-x630.google.com with SMTP id bv19so7613578ejb.6 for ; Wed, 27 Apr 2022 23:53:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=2VtYpl+AopG0sr9SMMb9GWmnfMrojG66n7RjufImm50=; b=lwaaQoJPHunxuYnucsJqsKlb/ZFMAcQ+0k8j6mvSEbAo+tDnwkfLRmrWMus5ro/udm FOHnvHIg+Od8zeBv9pcz/+cSrUdxgqQjP7LUfO5NpvqYDQmijdUhOcA1fi34Aq+v38MX LhJVz0OpmKIEFVZr1zh0LqshKffrL5kTQmEbOHNw8+fdZsutWv+daA9N/88TA6yG2Me+ IP84bUWImyT7N4KoEfs6JcgGo0jE3XVl0Y+aXu9Uo8Eujf8kUR0SMvaMN82ptr0AJudN A4IHMQF5otBDYl5yva1nkfVg+FjDmhen4fiFXu/kXW6txMcdM5evUL/uXw7KbIfuXHKO /PVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=2VtYpl+AopG0sr9SMMb9GWmnfMrojG66n7RjufImm50=; b=mQCoiZlPYh6csjdSkjEFfi2Zd2ZbhW0qc0nG5WrgJVrs88MX1+sC5OvQS6vSa+75+p 8xXA8wWBlIggv9u2mFyjs4+22ntH9HsJMAlFsaxZerAmNgn5tmv3p8U1weOtc+DFyrYf pKXL/4DI9uis+eNdgQP9658KQaSVxpkF3IafQ0FBE+wZtY72Y1qa0jOLTxgThfzE36z7 SL3dGFpfgI0pNH0ntrVUcqYBUGHhfq9Q2yV3lyYxALNFALBTMc16okVDHxtpJz12uuJ1 fdAKlD/yaRAIw9XxLPmwigRSpXKOoWPx6DMgmY9hXKuVRxTzyOvkTuCxVfIWJHLxiRJa b1qA== X-Gm-Message-State: AOAM533SYm9+uxEiDfTqrJWHR8m+fxCiROLv/F0THDvHbMdIG7ZzYyQK q5jhISvGcygQvTBg4nbTK9cTTA== X-Google-Smtp-Source: ABdhPJzso+XpXZx+m3nRJuf0ndPiYOfzhdXdRErjmKATg8VtTt/Cvcsd1y1NHq262yirrd9t4vNvdQ== X-Received: by 2002:a17:907:6090:b0:6f0:2a64:2ef7 with SMTP id ht16-20020a170907609000b006f02a642ef7mr29814689ejc.476.1651128828187; Wed, 27 Apr 2022 23:53:48 -0700 (PDT) Received: from [192.168.0.160] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id o22-20020a170906289600b006e44a0c1105sm7920189ejd.46.2022.04.27.23.53.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Apr 2022 23:53:47 -0700 (PDT) Message-ID: <7f435547-35f5-7885-3b1d-159199ca201a@linaro.org> Date: Thu, 28 Apr 2022 08:53:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] dt-bindings: pinctrl: aspeed: Drop referenced nodes in examples Content-Language: en-US To: Joel Stanley , Rob Herring References: <20220422192139.2592632-1-robh@kernel.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Fri, 29 Apr 2022 22:12:55 +1000 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , linux-aspeed , Andrew Jeffery , Linus Walleij , Linux Kernel Mailing List , "open list:GPIO SUBSYSTEM" , Krzysztof Kozlowski , OpenBMC Maillist , Linux ARM Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On 27/04/2022 10:40, Joel Stanley wrote: > On Fri, 22 Apr 2022 at 19:21, Rob Herring wrote: >> >> The additional nodes in the example referenced from the pinctrl node >> 'aspeed,external-nodes' properties are either incorrect (aspeed,ast2500-lpc) >> or not documented with a schema (aspeed,ast2500-gfx). There's no need to >> show these nodes as part of the pinctrl example, so just remove them. >> >> Signed-off-by: Rob Herring > > Nak. > > This removes the information on how to use the bindings. Surely we > prefer to over document rather than under document? There is no need to document consumers of generic providers, like syscon, clock or pinctrl. These are already well documented. The examples of consumers here do not bring any additional value. Best regards, Krzysztof