All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Xu <peterx@redhat.com>, kvm@vger.kernel.org
Cc: Sean Christopherson <sean.j.christopherson@intel.com>,
	Vitaly Kuznetsov <vkuznets@redhat.com>
Subject: Re: [PATCH] KVM: Remove async parameter for hva_to_pfn_remapped()
Date: Thu, 16 Apr 2020 18:13:57 +0200	[thread overview]
Message-ID: <7f576843-6b64-6561-05ee-730326249409@redhat.com> (raw)
In-Reply-To: <20200416155903.267414-1-peterx@redhat.com>

On 16/04/20 17:59, Peter Xu wrote:
> We always do synchronous fault in for those pages.
> 
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> 
> Or, does it make sense to allow async pf for PFNMAP|IO too?  I just
> didn't figure out why not...
> ---

I think async pf would use FAULT_FLAG_ALLOW_RETRY |
FAULT_FLAG_RETRY_NOWAIT.  On failure you would set *async = true.

In practice I don't think fixup_user_fault is likely to do anything
asynchronously.

Paolo


  reply	other threads:[~2020-04-16 16:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-16 15:59 [PATCH] KVM: Remove async parameter for hva_to_pfn_remapped() Peter Xu
2020-04-16 16:13 ` Paolo Bonzini [this message]
2020-04-16 16:22   ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7f576843-6b64-6561-05ee-730326249409@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=peterx@redhat.com \
    --cc=sean.j.christopherson@intel.com \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.