From: "Philippe Mathieu-Daudé" <philippe.mathieu.daude@gmail.com>
To: Mark Kanda <mark.kanda@oracle.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, richard.henderson@linaro.org, f4bug@amsat.org
Subject: Re: [PATCH v3 2/5] softmmu/cpus: Free cpu->thread in generic_destroy_vcpu_thread()
Date: Mon, 21 Mar 2022 23:08:03 +0100 [thread overview]
Message-ID: <7f689b45-a16c-8a59-d3d7-6344f0982b38@gmail.com> (raw)
In-Reply-To: <20220321141409.3112932-3-mark.kanda@oracle.com>
On 21/3/22 15:14, Mark Kanda wrote:
> Free cpu->thread in a new AccelOpsClass::destroy_vcpu_thread() handler
> generic_destroy_vcpu_thread().
>
> vCPU hotunplug related leak reported by Valgrind:
>
> ==102631== 8 bytes in 1 blocks are definitely lost in loss record 1,037 of 8,555
> ==102631== at 0x4C3ADBB: calloc (vg_replace_malloc.c:1117)
> ==102631== by 0x69EE4CD: g_malloc0 (in /usr/lib64/libglib-2.0.so.0.5600.4)
> ==102631== by 0x92443A: kvm_start_vcpu_thread (kvm-accel-ops.c:68)
> ==102631== by 0x4505C2: qemu_init_vcpu (cpus.c:643)
> ==102631== by 0x76B4D1: x86_cpu_realizefn (cpu.c:6520)
> ==102631== by 0x9344A7: device_set_realized (qdev.c:531)
> ==102631== by 0x93E329: property_set_bool (object.c:2273)
> ==102631== by 0x93C2F8: object_property_set (object.c:1408)
> ==102631== by 0x940796: object_property_set_qobject (qom-qobject.c:28)
> ==102631== by 0x93C663: object_property_set_bool (object.c:1477)
> ==102631== by 0x933D3B: qdev_realize (qdev.c:333)
> ==102631== by 0x455EC4: qdev_device_add_from_qdict (qdev-monitor.c:713)
>
> Signed-off-by: Mark Kanda <mark.kanda@oracle.com>
> ---
> accel/accel-common.c | 6 ++++++
> accel/hvf/hvf-accel-ops.c | 1 +
> accel/kvm/kvm-accel-ops.c | 1 +
> accel/qtest/qtest.c | 1 +
> accel/tcg/tcg-accel-ops.c | 1 +
> accel/xen/xen-all.c | 1 +
> include/sysemu/accel-ops.h | 2 ++
> target/i386/hax/hax-accel-ops.c | 1 +
> target/i386/nvmm/nvmm-accel-ops.c | 1 +
> target/i386/whpx/whpx-accel-ops.c | 1 +
> 10 files changed, 16 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
next prev parent reply other threads:[~2022-03-21 22:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 14:14 [PATCH v3 0/5] vCPU hotunplug related memory leaks Mark Kanda
2022-03-21 14:14 ` [PATCH v3 1/5] accel: Introduce AccelOpsClass::destroy_vcpu_thread() Mark Kanda
2022-03-21 14:14 ` [PATCH v3 2/5] softmmu/cpus: Free cpu->thread in generic_destroy_vcpu_thread() Mark Kanda
2022-03-21 22:08 ` Philippe Mathieu-Daudé [this message]
2022-03-23 14:43 ` Paolo Bonzini
2022-03-21 14:14 ` [PATCH v3 3/5] softmmu/cpus: Free cpu->halt_cond " Mark Kanda
2022-03-21 22:12 ` Philippe Mathieu-Daudé
2022-03-22 12:52 ` Mark Kanda
2022-03-22 13:32 ` Philippe Mathieu-Daudé
2022-03-21 14:14 ` [PATCH v3 4/5] cpu: Free cpu->cpu_ases in cpu_address_space_destroy() Mark Kanda
2022-03-21 22:03 ` Philippe Mathieu-Daudé
2022-03-21 22:08 ` Philippe Mathieu-Daudé
2022-03-21 14:14 ` [PATCH v3 5/5] i386/cpu: Free env->xsave_buf in KVM and HVF destory_vcpu_thread routines Mark Kanda
2022-03-21 22:04 ` Philippe Mathieu-Daudé
2022-03-21 22:08 ` Philippe Mathieu-Daudé
2022-03-22 12:01 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f689b45-a16c-8a59-d3d7-6344f0982b38@gmail.com \
--to=philippe.mathieu.daude@gmail.com \
--cc=f4bug@amsat.org \
--cc=mark.kanda@oracle.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.