All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
	"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
	linux-scsi@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Keith Busch <kbusch@kernel.org>, Sagi Grimberg <sagi@grimberg.me>,
	Jens Axboe <axboe@fb.com>, Felipe Balbi <balbi@kernel.org>,
	Harvey Harrison <harvey.harrison@gmail.com>,
	Ingo Molnar <mingo@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H . Peter Anvin" <hpa@zytor.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2 3/5] treewide: Consolidate {get,put}_unaligned_[bl]e24() definitions
Date: Fri, 13 Mar 2020 13:04:38 -0700	[thread overview]
Message-ID: <7f70533a-d883-ceda-4bb7-074b01c58181@acm.org> (raw)
In-Reply-To: <20200313163328.GY1922688@smile.fi.intel.com>

On 2020-03-13 09:33, Andy Shevchenko wrote:
> You have at least two advantages on this:
> a) we really don't modify the content of the input value;
> b) it will be consistent with the rest of consolidated helpers.

(b) is an excellent point. I'm all in favor of consistency so I will add
the 'const' keyword.

Thanks,

Bart.



  parent reply	other threads:[~2020-03-13 20:04 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-13  2:37 [PATCH v2 0/5] Consolidate {get,put}_unaligned_[bl]e24() definitions Bart Van Assche
2020-03-13  2:37 ` [PATCH v2 1/5] linux/unaligned/byteshift.h: Remove superfluous casts Bart Van Assche
2020-03-13 11:05   ` Christoph Hellwig
2020-03-13  2:37 ` [PATCH v2 2/5] c6x: Include <linux/unaligned/generic.h> instead of duplicating it Bart Van Assche
2020-03-13  2:37 ` [PATCH v2 3/5] treewide: Consolidate {get,put}_unaligned_[bl]e24() definitions Bart Van Assche
2020-03-13  9:15   ` Andy Shevchenko
2020-03-13 14:54     ` Bart Van Assche
2020-03-13 16:33       ` Andy Shevchenko
2020-03-13 16:38         ` Andy Shevchenko
2020-03-13 20:04         ` Bart Van Assche [this message]
2020-03-13  9:25   ` Andy Shevchenko
2020-03-13 14:56     ` Bart Van Assche
2020-03-13 11:06   ` Christoph Hellwig
2020-03-13 14:44   ` Felipe Balbi
2020-03-13  2:37 ` [PATCH v2 4/5] scsi/st: Use get_unaligned_be24() and sign_extend32() Bart Van Assche
2020-03-13 11:08   ` Christoph Hellwig
2020-03-13 15:03     ` Bart Van Assche
2020-03-13  2:37 ` [PATCH v2 5/5] scsi/trace: Use get_unaligned_be24() Bart Van Assche
2020-03-13 11:08   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7f70533a-d883-ceda-4bb7-074b01c58181@acm.org \
    --to=bvanassche@acm.org \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=axboe@fb.com \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=harvey.harrison@gmail.com \
    --cc=hch@lst.de \
    --cc=hpa@zytor.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=kbusch@kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=mingo@kernel.org \
    --cc=sagi@grimberg.me \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.