From mboxrd@z Thu Jan 1 00:00:00 1970 From: Declan Doherty Subject: Re: [PATCH v2] test: Fix memory corruption issues which fails the link_bonding test. Date: Wed, 12 Jul 2017 11:23:05 +0100 Message-ID: <7f76a7ca-d243-7d9f-da6c-e853be1e03a5@intel.com> References: <1499671222-8283-1-git-send-email-herbert.guan@arm.com> <1499685226-8659-1-git-send-email-herbert.guan@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit To: Herbert Guan , dev@dpdk.org, jianbo.liu@linaro.org Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id CC20C3257 for ; Wed, 12 Jul 2017 12:25:50 +0200 (CEST) In-Reply-To: <1499685226-8659-1-git-send-email-herbert.guan@arm.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/07/17 12:13, Herbert Guan wrote: > Patch V2: fix build warnings by deleting unused variables. > > There were double-free problems in some test cases, which will cause > a duplicated mbuf will be added into mempool. After double-free, > some new allocated mbuf will hold a same address and thus cause the > memory corruption. > > Another minor issue is that in some test cases, allocated mbuf will > not be released after test case exits. Hopefully these leaked mbuf > will be released by the next test case in its setup phase when > stopping the virtual pmd ports, while this do is a memory leak of > the exited test case. > > To fix above 2 issues, this patch will do: > 1) Release virtual pmd ports' tx queue in the clean up function > remove_slaves_and_stop_bonded_device() of each test cases. > 2) Do not release allocated mbufs for test bursts. These mbufs > will be released in remove_slaves_and_stop_bonded_device() when > test case exits. > > Signed-off-by: Herbert Guan > --- ... > Acked-by: Declan Doherty