From: Sander Vanheule <sander@svanheule.net>
To: Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <maz@kernel.org>,
devicetree@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>,
Birger Koblitz <mail@birger-koblitz.de>,
Bert Vermeulen <bert@biot.com>, John Crispin <john@phrozen.org>,
linux-kernel@vger.kernel.org,
Sander Vanheule <sander@svanheule.net>
Subject: [RFC PATCH v1 1/4] irqchip: realtek-rtl: map control data to virq
Date: Thu, 23 Dec 2021 13:08:31 +0100 [thread overview]
Message-ID: <7f89a2ed75482b8d1d8469d2c6bfd479aba07b9f.1640261161.git.sander@svanheule.net> (raw)
In-Reply-To: <cover.1640261161.git.sander@svanheule.net>
The driver assigned the irqchip and irq handler to the hardware irq,
instead of the virq. This is incorrect, and only worked because these
irq numbers happened to be the same on the devices used for testing the
original driver.
Fixes: 9f3a0f34b84a ("irqchip: Add support for Realtek RTL838x/RTL839x interrupt controller")
Signed-off-by: Sander Vanheule <sander@svanheule.net>
---
drivers/irqchip/irq-realtek-rtl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-realtek-rtl.c b/drivers/irqchip/irq-realtek-rtl.c
index fd9f275592d2..d6788dd93c7b 100644
--- a/drivers/irqchip/irq-realtek-rtl.c
+++ b/drivers/irqchip/irq-realtek-rtl.c
@@ -62,7 +62,7 @@ static struct irq_chip realtek_ictl_irq = {
static int intc_map(struct irq_domain *d, unsigned int irq, irq_hw_number_t hw)
{
- irq_set_chip_and_handler(hw, &realtek_ictl_irq, handle_level_irq);
+ irq_set_chip_and_handler(irq, &realtek_ictl_irq, handle_level_irq);
return 0;
}
--
2.33.1
next prev parent reply other threads:[~2021-12-23 12:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 12:08 [RFC PATCH v1 0/4] Rework realtek-rtl IRQ driver Sander Vanheule
2021-12-23 12:08 ` Sander Vanheule [this message]
2021-12-23 12:08 ` [RFC PATCH v1 2/4] irqchip: realtek-rtl: use per-parent irq handling Sander Vanheule
2021-12-23 17:57 ` Marc Zyngier
2021-12-23 19:17 ` Sander Vanheule
2021-12-23 12:08 ` [RFC PATCH v1 3/4] dt-bindings: interrupt-controller: realtek,rtl-intc: replace irq mapping Sander Vanheule
2021-12-23 18:00 ` Marc Zyngier
2021-12-23 19:29 ` Sander Vanheule
2021-12-27 10:04 ` Marc Zyngier
2021-12-27 10:15 ` Sander Vanheule
2021-12-23 12:08 ` [RFC PATCH v1 4/4] irqchip: realtek-rtl: replace custom interrupt-map Sander Vanheule
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f89a2ed75482b8d1d8469d2c6bfd479aba07b9f.1640261161.git.sander@svanheule.net \
--to=sander@svanheule.net \
--cc=bert@biot.com \
--cc=devicetree@vger.kernel.org \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@birger-koblitz.de \
--cc=maz@kernel.org \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.