All of lore.kernel.org
 help / color / mirror / Atom feed
From: Craig McQueen <craig.mcqueen@innerrange.com>
To: "linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>
Subject: rtc-pcf85063 driver bug in pcf85063_stop_clock()
Date: Thu, 11 Oct 2018 06:53:15 +0000	[thread overview]
Message-ID: <7f8c164eb0fd47788ec6bbd34735f4a5@innerrange.com> (raw)

The function pcf85063_stop_clock() is intended to provide the value of the Control_1 register via the pointer ctrl1.

However, it's really providing the return value of the last i2c_smbus_write_byte_data() call, i.e., zero. So the register value needs to be saved in a separate local variable other than ret. Or, the line *ctrl1 = ret; needs to be moved up to be above the last i2c_smbus_write_byte_data() call.

-- 
Craig McQueen


             reply	other threads:[~2018-10-11  7:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-11  6:53 Craig McQueen [this message]
2018-10-15 12:39 ` rtc-pcf85063 driver bug in pcf85063_stop_clock() Alexandre Belloni
2018-11-19 22:56 ` Craig McQueen
2018-11-25 14:10   ` Alexandre Belloni
2018-11-26  0:21     ` Craig McQueen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7f8c164eb0fd47788ec6bbd34735f4a5@innerrange.com \
    --to=craig.mcqueen@innerrange.com \
    --cc=linux-rtc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.