Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"David Gibson" <david@gibson.dropbear.id.au>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image
Date: Fri, 21 Feb 2020 15:09:46 +1100	[thread overview]
Message-ID: <7f9d26fe-1ad0-9ccf-dd00-9aad7491d36d@ozlabs.ru> (raw)
In-Reply-To: <38cfa5c3-2563-7aaa-b1db-c7dd2f053d3c@redhat.com>

On 18/02/2020 16:48, Philippe Mathieu-Daudé wrote:
> On 2/17/20 11:46 PM, David Gibson wrote:
>> On Mon, Feb 17, 2020 at 11:24:11AM +0100, Philippe Mathieu-Daudé wrote:
>>> On 2/17/20 10:26 AM, Philippe Mathieu-Daudé wrote:
>>>> Hi Alexey,
>>>>
>>>> On 2/17/20 3:12 AM, Alexey Kardashevskiy wrote:
>>>>> The following changes since commit
>>>>> 05943fb4ca41f626078014c0327781815c6584c5:
>>>>>
>>>>>     ppc: free 'fdt' after reset the machine (2020-02-17 11:27:23
>>>>> +1100)
>>>>>
>>>>> are available in the Git repository at:
>>>>>
>>>>>     git@github.com:aik/qemu.git tags/qemu-slof-20200217
>>>>>
>>>>> for you to fetch changes up to
>>>>> ea9a03e5aa023c5391bab5259898475d0298aac2:
>>>>>
>>>>>     pseries: Update SLOF firmware image (2020-02-17 13:08:59 +1100)
>>>>>
>>>>> ----------------------------------------------------------------
>>>>> Alexey Kardashevskiy (1):
>>>>>         pseries: Update SLOF firmware image
>>>>>
>>>>>    pc-bios/README   |   2 +-
>>>>>    pc-bios/slof.bin | Bin 931032 -> 968560 bytes
>>>>>    roms/SLOF        |   2 +-
>>>>>    3 files changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> I only received the cover, not the patch, have you posted it?
>>>
>>> OK I see the SLOF binary is almost 1MB. Maybe this got blocked by spam
>>> filter. FYI you can use 'git-format-patch --no-binary' to emit the patch
>>> with the commit description but without the content.
>>
>> Generally Alexey sends SLOF updates to me just as pull requests
>> without patches in full, because a huge slab of base64 encoded
>> firmware isn't particularly illuminating.
> 
> I understand, this is why I later suggested Alexey to use
> 'git-format-patch --no-binary', because Laszlo uses it for EDK2
> submodule, this allow to quickly review the change on the list (without
> posting the base64), see:
> 
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg624429.html
> (pull-request cover)
> 
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg624432.html
> "roms/edk2: update submodule"
> 
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg624435.html
> "pc-bios: refresh edk2 build artifacts"

I am not quite sure where to fit this "git-format-patch". I run now "git
request-pull" and "git send-email" so am I expected to run format-patch
and post it as a patchset but with the pull request mail as a cover
letter? This does not seem very useful though. For today, I'll add the
change log to the pull request mail. Thanks,

-- 
Alexey