All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Gix, Brian" <brian.gix@intel.com>
To: "linux-bluetooth@vger.kernel.org"
	<linux-bluetooth@vger.kernel.org>,
	"Stotland, Inga" <inga.stotland@intel.com>
Cc: "michal.lowas-rzechonek@silvair.com" 
	<michal.lowas-rzechonek@silvair.com>
Subject: Re: [PATCH BlueZ v2 0/4] Add options to Models and VendorModels
Date: Wed, 1 Jul 2020 19:11:09 +0000	[thread overview]
Message-ID: <7f9da664fa4c34b42d5174f937c06e4ed9902cfe.camel@intel.com> (raw)
In-Reply-To: <20200630185617.14755-1-inga.stotland@intel.com>

Patchset Applied
On Tue, 2020-06-30 at 11:56 -0700, Inga Stotland wrote:
> v2:
> 
> Changes constaned to patch 0002:
> 
> - Fixed returned status in config pub/sub model calls
> - Consistent use of pub_enabled & sub_enabled in the code
> 
> ************
> If a model does not support either subscription mechanism,
> Config Server is supposed to return "Not a Subscribe Model" if a Config Client sends
> a subscription add/overwrite message.
> 
> Similarly, if a model does not support publication, "Invalid Publish Parameters"
> should be returned in response to Publication Set message.
> 
> Since config server is running even when an app is not attached, the only way to collect
> these model capabilities is on Attach, Join, Create, Import methods when the
> object manager collects app info.
> 
> To address this issue, signatures for properties "Models" and "VendorModels" on Element
> interface change to include "options" dictionary:
>     Models: signature change "aq" -> "a(qa{sv})"
>     VendorModels: signature change "a(qq)" -> "a(qqa{sv})"
>     
> The defined keywords for the options dictionary are:
>     "Publish" - indicates whether the model supports publication mechanism.
>                 If not present, publication is enabled.
>     "Subscribe" - indicates whether the model supports subscription mechanism.
>                 If not present, subscriptions are enabled.
> 
> Inga Stotland (4):
>   doc/mesh-api: Add dictionary to model properties
>   mesh: Check app model settings of pub/sub support
>   tools/mesh-cfgclient: Add options to "Models" property
>   test/test-mesh: Add options to "Models" property
> 
>  doc/mesh-api.txt        |  40 ++++++++--
>  mesh/mesh-config-json.c |  76 +++++++++++++++++-
>  mesh/mesh-config.h      |   8 ++
>  mesh/model.c            |  98 +++++++++++++++++++----
>  mesh/model.h            |   6 ++
>  mesh/node.c             | 168 ++++++++++++++++++++++++++++++++--------
>  test/test-mesh          |  21 ++---
>  tools/mesh-cfgclient.c  |  25 ++++--
>  8 files changed, 374 insertions(+), 68 deletions(-)
> 

      parent reply	other threads:[~2020-07-01 19:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-30 18:56 [PATCH BlueZ v2 0/4] Add options to Models and VendorModels Inga Stotland
2020-06-30 18:56 ` [PATCH BlueZ v2 1/4] doc/mesh-api: Add dictionary to model properties Inga Stotland
2020-06-30 18:56 ` [PATCH BlueZ v2 2/4] mesh: Check app model settings of pub/sub support Inga Stotland
2020-06-30 18:56 ` [PATCH BlueZ v2 3/4] tools/mesh-cfgclient: Add options to "Models" property Inga Stotland
2020-06-30 18:56 ` [PATCH BlueZ v2 4/4] test/test-mesh: " Inga Stotland
2020-07-01 19:11 ` Gix, Brian [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7f9da664fa4c34b42d5174f937c06e4ed9902cfe.camel@intel.com \
    --to=brian.gix@intel.com \
    --cc=inga.stotland@intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=michal.lowas-rzechonek@silvair.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.