From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Hauke Mehrtens <hauke@hauke-m.de>, johannes@sipsolutions.net
Cc: backports@vger.kernel.org
Subject: Re: [PATCH 16/21] patches: brcmfmac: fix netdev destructor
Date: Wed, 13 Sep 2017 21:36:15 +0200 [thread overview]
Message-ID: <7fad164c-e46f-ad64-4586-5521c2fc770d@broadcom.com> (raw)
In-Reply-To: <20170821222817.17376-17-hauke@hauke-m.de>
On 22-08-17 00:28, Hauke Mehrtens wrote:
> brcmfmac uses a complicated netdev destructor handling. The
> brcmf_net_attach() function just adds a normal destructor and later the
> brcmf_add_if() function sets the needs_free_netdev callback.
>
> The normal spatch was not applied correctly to this file, add a patch
> before to try to fx this problem manually.
Way overdue, but better late than never. I think we prefer to use
spatch, but I understand the destructor handling in brcmfmac is complicated.
The story above does not tell it right. brcmf_add_if() is called first
doing the alloc_netdev() setting needs_free_netdev to true and
subsequently brcmf_net_attach() is called doing the
register_netdevice(). When that is successful and only then I set the
priv_destructor. The reason for this was to keep the error path simple,
because when register_netdevice() fails it calls the priv_destructor
although that is not documented in struct net_device:
* @priv_destructor: Called from unregister
I think I will make an attempt to change brcmfmac so we can get rid of
this patch file and rely on the spatch, but for now I am fine with it.
Regards,
Arend
--
To unsubscribe from this list: send the line "unsubscribe backports" in
next prev parent reply other threads:[~2017-09-13 19:36 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-21 22:27 [PATCH 00/21] backports: multiple changes for kernel 3.13-rc6 Hauke Mehrtens
2017-08-21 22:27 ` [PATCH 01/21] copy: do not copy files removed in kernel 4.13 Hauke Mehrtens
2017-09-06 14:56 ` Johannes Berg
2017-08-21 22:27 ` [PATCH 02/21] patches: header fix for st-nci not needed any more Hauke Mehrtens
2017-08-21 22:27 ` [PATCH 03/21] header: skbuff: add skb_put_zero(), skb_put_data() and skb_put_u8() Hauke Mehrtens
2017-08-21 22:28 ` [PATCH 04/21] header: skbuff: fix signature of skb_put(), skb_push() and () Hauke Mehrtens
2017-08-21 22:28 ` [PATCH 05/21] header: backport mii_ethtool_{get,set}_link_ksettings() Hauke Mehrtens
2017-08-21 22:28 ` [PATCH 06/21] patches: adapt the stat64 usage for usbnet Hauke Mehrtens
2017-08-21 22:28 ` [PATCH 07/21] header: add module_param_hw_array() Hauke Mehrtens
2017-09-06 15:00 ` Johannes Berg
2017-08-21 22:28 ` [PATCH 08/21] header: backport devm_acpi_dev_add_driver_gpios() Hauke Mehrtens
2017-09-06 15:01 ` Johannes Berg
2017-09-06 21:58 ` Hauke Mehrtens
2017-09-08 9:25 ` Johannes Berg
2017-09-08 9:28 ` Johannes Berg
2017-08-21 22:28 ` [PATCH 09/21] header: add get_random_u32() Hauke Mehrtens
2017-08-21 22:28 ` [PATCH 10/21] header: rename wait_queue_entry_t to wait_queue_t Hauke Mehrtens
2017-08-21 22:28 ` [PATCH 11/21] backport: add __print_array() Hauke Mehrtens
2017-08-21 22:28 ` [PATCH 12/21] compat: avoid usage of kvzalloc() in rhashtable.c Hauke Mehrtens
2017-09-06 15:05 ` Johannes Berg
2017-09-06 22:12 ` Hauke Mehrtens
2017-09-08 9:25 ` Johannes Berg
2017-08-21 22:28 ` [PATCH 13/21] patch: Allow usage of pci_error_handlers->reset_notify Hauke Mehrtens
2017-08-21 22:28 ` [PATCH 14/21] header: add offsetofend() Hauke Mehrtens
2017-08-21 22:28 ` [PATCH 15/21] dependencies: add deps for struct acpi_gpio_mapping Hauke Mehrtens
2017-08-21 22:28 ` [PATCH 16/21] patches: brcmfmac: fix netdev destructor Hauke Mehrtens
2017-09-06 15:05 ` Johannes Berg
2017-09-07 7:48 ` Arend van Spriel
2017-09-07 9:04 ` compilation errors in ath10k driver with latest backports git KAVITA MATHUR
2017-09-07 9:17 ` Arend van Spriel
2017-09-13 19:36 ` Arend van Spriel [this message]
2017-09-14 7:21 ` [PATCH 16/21] patches: brcmfmac: fix netdev destructor Johannes Berg
2017-09-17 22:00 ` Hauke Mehrtens
2017-09-18 7:16 ` Arend van Spriel
2017-08-21 22:28 ` [PATCH 17/21] patches: backport the probe_new for i2c drivers Hauke Mehrtens
2017-08-21 22:28 ` [PATCH 18/21] patches: adapt signature of proto_ops->accept Hauke Mehrtens
2017-08-21 22:28 ` [PATCH 19/21] header: add linux/refcount.h Hauke Mehrtens
2017-08-21 22:28 ` [PATCH 20/21] header: add dma_wmb() Hauke Mehrtens
2017-08-21 22:28 ` [PATCH 21/21] copy-list: add quantenna qtnfmac driver Hauke Mehrtens
2017-09-06 15:10 ` Johannes Berg
2017-09-06 15:13 ` Johannes Berg
2017-09-06 22:14 ` Hauke Mehrtens
2017-09-06 15:14 ` Johannes Berg
2017-09-05 9:00 ` [PATCH 00/21] backports: multiple changes for kernel 3.13-rc6 Johannes Berg
2017-09-05 21:41 ` Hauke Mehrtens
2017-09-06 7:23 ` Johannes Berg
2017-09-13 20:00 ` Arend van Spriel
2017-09-17 22:07 ` Hauke Mehrtens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fad164c-e46f-ad64-4586-5521c2fc770d@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=backports@vger.kernel.org \
--cc=hauke@hauke-m.de \
--cc=johannes@sipsolutions.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.