From: Steve Dickson <SteveD@RedHat.com>
To: Trond Myklebust <trondmy@gmail.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH v3 00/11] Add the "[exports] rootdir" option to nfs.conf
Date: Mon, 10 Jun 2019 09:53:01 -0400 [thread overview]
Message-ID: <7fbb9de3-8da4-5475-d425-ecc68c9ef709@RedHat.com> (raw)
In-Reply-To: <20190528203122.11401-1-trond.myklebust@hammerspace.com>
On 5/28/19 4:31 PM, Trond Myklebust wrote:
> The following patchset adds support for the "rootdir" configuration
> option for nfsd in the "[exports]" section in /etc/nfs.conf.
>
> If a user sets this option to a valid directory path, then nfsd will
> act as if it is confined to a chroot jail based on that directory.
> All paths in /etc/exports and the exportfs utility are then resolved
> relative to that directory.
>
> Trond Myklebust (11):
> mountd: Ensure we don't share cache file descriptors among processes.
> Add a simple workqueue mechanism
> Allow callers to check mountpoint status using a custom lstat function
> Add utilities for resolving nfsd paths and stat()ing them
> Use xstat() with no synchronisation if available
> Add helpers to read/write to a file through the chrooted thread
> Add a helper to return the real path given an export entry
> Add support for the "[exports] rootdir" nfs.conf option to rpc.mountd
> Add support for the "[exports] rootdir" nfs.conf option to exportfs
> Add a helper for resolving symlinked nfsd paths via realpath()
> Fix up symlinked mount path resolution when "[exports] rootdir" is set
>
> aclocal/libpthread.m4 | 13 +-
> configure.ac | 6 +-
> nfs.conf | 3 +
> support/export/export.c | 24 +++
> support/include/Makefile.am | 3 +
> support/include/exportfs.h | 1 +
> support/include/misc.h | 7 +-
> support/include/nfsd_path.h | 21 +++
> support/include/nfslib.h | 1 +
> support/include/workqueue.h | 18 +++
> support/include/xstat.h | 11 ++
> support/misc/Makefile.am | 3 +-
> support/misc/mountpoint.c | 8 +-
> support/misc/nfsd_path.c | 289 ++++++++++++++++++++++++++++++++++++
> support/misc/workqueue.c | 228 ++++++++++++++++++++++++++++
> support/misc/xstat.c | 105 +++++++++++++
> support/nfs/exports.c | 4 +
> systemd/nfs.conf.man | 20 ++-
> utils/exportfs/Makefile.am | 2 +-
> utils/exportfs/exportfs.c | 11 +-
> utils/mountd/Makefile.am | 3 +-
> utils/mountd/cache.c | 63 +++++---
> utils/mountd/mountd.c | 24 +--
> 23 files changed, 819 insertions(+), 49 deletions(-)
> create mode 100644 support/include/nfsd_path.h
> create mode 100644 support/include/workqueue.h
> create mode 100644 support/include/xstat.h
> create mode 100644 support/misc/nfsd_path.c
> create mode 100644 support/misc/workqueue.c
> create mode 100644 support/misc/xstat.c
>
Committed!
steved.
prev parent reply other threads:[~2019-06-10 13:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 20:31 [PATCH v3 00/11] Add the "[exports] rootdir" option to nfs.conf Trond Myklebust
2019-05-28 20:31 ` [PATCH v3 01/11] mountd: Ensure we don't share cache file descriptors among processes Trond Myklebust
2019-05-28 20:31 ` [PATCH v3 02/11] Add a simple workqueue mechanism Trond Myklebust
2019-05-28 20:31 ` [PATCH v3 03/11] Allow callers to check mountpoint status using a custom lstat function Trond Myklebust
2019-05-28 20:31 ` [PATCH v3 04/11] Add utilities for resolving nfsd paths and stat()ing them Trond Myklebust
2019-05-28 20:31 ` [PATCH v3 05/11] Use xstat() with no synchronisation if available Trond Myklebust
2019-05-28 20:31 ` [PATCH v3 06/11] Add helpers to read/write to a file through the chrooted thread Trond Myklebust
2019-05-28 20:31 ` [PATCH v3 07/11] Add a helper to return the real path given an export entry Trond Myklebust
2019-05-28 20:31 ` [PATCH v3 08/11] Add support for the "[exports] rootdir" nfs.conf option to rpc.mountd Trond Myklebust
2019-05-28 20:31 ` [PATCH v3 09/11] Add support for the "[exports] rootdir" nfs.conf option to exportfs Trond Myklebust
2019-05-28 20:31 ` [PATCH v3 10/11] Add a helper for resolving symlinked nfsd paths via realpath() Trond Myklebust
2019-05-28 20:31 ` [PATCH v3 11/11] Fix up symlinked mount path resolution when "[exports] rootdir" is set Trond Myklebust
2019-05-31 16:02 ` [PATCH v3 08/11] Add support for the "[exports] rootdir" nfs.conf option to rpc.mountd J. Bruce Fields
2019-06-03 14:18 ` Steve Dickson
2019-06-03 16:30 ` Trond Myklebust
2019-05-29 14:38 ` [PATCH v3 07/11] Add a helper to return the real path given an export entry Steve Dickson
2019-05-29 14:55 ` Trond Myklebust
2019-05-29 16:03 ` Steve Dickson
2019-05-29 16:12 ` Trond Myklebust
2019-05-29 17:17 ` Steve Dickson
2019-05-31 15:52 ` [PATCH v3 04/11] Add utilities for resolving nfsd paths and stat()ing them J. Bruce Fields
2019-06-03 14:21 ` Steve Dickson
2019-06-03 16:32 ` Trond Myklebust
2019-06-10 13:53 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fbb9de3-8da4-5475-d425-ecc68c9ef709@RedHat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.