All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: chenweilong <chenweilong@huawei.com>,
	f.fangjian@huawei.com, linus.walleij@linaro.org,
	yangyicong@hisilicon.com, xuwei5@huawei.com, robh+dt@kernel.org,
	robh@kernel.org, krzysztof.kozlowski+dt@linaro.org
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH next 2/2] dt-bindings: gpio: add entry for hisilicon,gpio-ascend910
Date: Thu, 27 Oct 2022 08:51:03 -0400	[thread overview]
Message-ID: <7fbbb805-f215-f079-5e8e-8f5e085da6e9@linaro.org> (raw)
In-Reply-To: <050ab042-d51c-1e9a-eb85-8fbec8020211@huawei.com>

On 27/10/2022 03:47, chenweilong wrote:
>> Convention for counting is to use decimal numbers.
>>
>>> +      gpio-controller;
>>> +      #gpio-cells = <2>;
>>> +      interrupts = <0x0 33 0x4>;
>> This looks like standard IRQ flags, so use respective defines.
> 
> Sorry, I don't get this, you mean like this? :
> 
> interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;

Yes.

Best regards,
Krzysztof


  reply	other threads:[~2022-10-27 12:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-26  3:42 [PATCH next 1/2] gpio: hisi: Add initial device tree support Weilong Chen
2022-10-26  3:42 ` [PATCH next 2/2] dt-bindings: gpio: add entry for hisilicon,gpio-ascend910 Weilong Chen
2022-10-26 14:46   ` Krzysztof Kozlowski
2022-10-27  7:47     ` chenweilong
2022-10-27 12:51       ` Krzysztof Kozlowski [this message]
2022-10-26 20:11   ` Rob Herring
2022-11-08 10:33 ` [PATCH next 1/2] gpio: hisi: Add initial device tree support Linus Walleij
2022-11-08 11:17   ` chenweilong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7fbbb805-f215-f079-5e8e-8f5e085da6e9@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=chenweilong@huawei.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fangjian@huawei.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=xuwei5@huawei.com \
    --cc=yangyicong@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.