From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] ethdev: convert Tx offloads to Tx queue
	config
Date: Fri, 4 May 2018 14:59:00 +0100
Message-ID: <7fbe404e-db54-8074-3b0d-e91a46e9dd45@intel.com>
References: <20180503060325.153722-1-qi.z.zhang@intel.com>
 <c1dc17ef-175f-a029-427b-c4e13b8cd79e@solarflare.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Andrew Rybchenko <arybchenko@solarflare.com>,
 Qi Zhang <qi.z.zhang@intel.com>, konstantin.ananyev@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by dpdk.org (Postfix) with ESMTP id C2B941E35
 for <dev@dpdk.org>; Fri,  4 May 2018 15:59:03 +0200 (CEST)
In-Reply-To: <c1dc17ef-175f-a029-427b-c4e13b8cd79e@solarflare.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 5/3/2018 10:24 AM, Andrew Rybchenko wrote:
> On 05/03/2018 09:03 AM, Qi Zhang wrote:
>> Tx offload will be converted to txq_flags automatically during
>> rte_eth_dev_info_get and rte_eth_tx_queue_info_get. So PMD can
>> clean the code to get rid of txq_flags at all while keep old APP
>> not be impacted.
>>
>> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> 
> It is a step in right direction. It allows net/sfc to cut the code which
> fills in txq_flags in default TxQ config.
> 
> Tested-by: Andrew Rybchenko <arybchenko@solarflare.com>

> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>