All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>,
	Khem Raj <raj.khem@gmail.com>,
	 Armin Kuster <akuster808@gmail.com>,
	Jerome Neanne <jneanne@baylibre.com>,
	Quentin Schulz <quentin.schulz@streamunlimited.com>
Cc: openembedded-core@lists.openembedded.org,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [meta-OE][PATCH v3] image.bbclass: deploy image artifacts in stages
Date: Fri, 15 May 2020 06:56:01 +0100	[thread overview]
Message-ID: <7fbf9d94860522944c8764760b717a0524bf20b5.camel@linuxfoundation.org> (raw)
In-Reply-To: <20200512140529.27606-1-brgl@bgdev.pl>

On Tue, 2020-05-12 at 16:05 +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> 
> Make each IMAGE_CMD task an sstate task with its own IMGDEPLOYDIR
> override. This way each generated set of artifacts is deployed as soon
> as it's ready instead of the do_image_complete task handling the entire
> deployement. This allows us to better fine-tune dependencies e.g. we
> can make do_image_wic depend on fitImage task which can in turn depend
> on do_image_ext4.
> 
> We need delete the IMGDEPLOYDIR variable from the data object passed
> to each image task so that it gets expanded with the correct override.
> 
> In order to make sure that tasks added to SSTATETASKS in anonymous python
> functions are correctly setup, move the code that assigns pre- and
> postfuncs to an event handler invoked on bb.event.RecipeTaskPreProcess
> in sstate.bbclass. This event is fired right after the anonymous
> functions.
> 
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> Changes since v2:
> - dropped the qemuboot patch (already upstream)
> - switched to % string formatting instead of using .format() for consistency

Thanks, I included this in automated testing and its shown a few
issues:

https://autobuilder.yoctoproject.org/typhoon/#/builders/79/builds/943

"oe-selftest -r
sstatetests.SStateTests.test_sstate_nativelsbstring_same_hash " should
reproduce

I think multiconfig.MultiConfig.test_multiconfig and
multiconfig.MultiConfig.test_multiconfig are also related but its
harder to be sure.

package.PackageTests.test_gdb_hardlink_debug isn't related in there.
runqemu.RunqemuTests.test_boot_deploy_hddimg and
runqemu.RunqemuTests.test_boot_machine_iso could be, not sure.

Cheers,

Richard




  parent reply	other threads:[~2020-05-15  5:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-12 14:05 [meta-OE][PATCH v3] image.bbclass: deploy image artifacts in stages Bartosz Golaszewski
2020-05-14 16:16 ` Bartosz Golaszewski
2020-05-14 16:48   ` [OE-core] " Richard Purdie
2020-05-15  5:56 ` Richard Purdie [this message]
2020-08-07 18:17   ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7fbf9d94860522944c8764760b717a0524bf20b5.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=akuster808@gmail.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=brgl@bgdev.pl \
    --cc=jneanne@baylibre.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=quentin.schulz@streamunlimited.com \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.