From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5467CC433E0 for ; Wed, 13 Jan 2021 06:46:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C55BB23125 for ; Wed, 13 Jan 2021 06:46:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C55BB23125 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 22AB46B00DD; Wed, 13 Jan 2021 01:46:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DA656B00EF; Wed, 13 Jan 2021 01:46:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A2578D0007; Wed, 13 Jan 2021 01:46:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0047.hostedemail.com [216.40.44.47]) by kanga.kvack.org (Postfix) with ESMTP id E4EFB6B00DD for ; Wed, 13 Jan 2021 01:46:01 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id B7C6033CD for ; Wed, 13 Jan 2021 06:46:01 +0000 (UTC) X-FDA: 77699816922.07.hen47_19179062751c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id 9A8F91803F798 for ; Wed, 13 Jan 2021 06:46:01 +0000 (UTC) X-HE-Tag: hen47_19179062751c X-Filterd-Recvd-Size: 5931 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Wed, 13 Jan 2021 06:45:59 +0000 (UTC) IronPort-SDR: NKdp4jT2gLtEnPIM5N8g/VonXp46NKq9LFF6mL3uBnDSZJjP/nSXvEPmtwvRQJrnhF3Doyle/Y o/R2oHPmT2Ng== X-IronPort-AV: E=McAfee;i="6000,8403,9862"; a="177383231" X-IronPort-AV: E=Sophos;i="5.79,343,1602572400"; d="scan'208";a="177383231" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2021 22:45:58 -0800 IronPort-SDR: oDlAFkGhPkRiH7y0b2QdTIa5WkQ7XIPj8cz4oMdyVSDngCk61ZLm8VmQMb9/Gr50AEE5SvFl4B W6DS+/dBdNdQ== X-IronPort-AV: E=Sophos;i="5.79,343,1602572400"; d="scan'208";a="381729761" Received: from shao2-debian.sh.intel.com (HELO [10.239.13.117]) ([10.239.13.117]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2021 22:45:55 -0800 Subject: Re: [kbuild-all] Re: [linux-stable-rc:linux-4.19.y 1441/2773] drivers/base/node.c:429:5: warning: no previous prototype for function 'register_mem_block_under_node_early' To: Greg Kroah-Hartman , Souptick Joarder Cc: kernel test robot , Laurent Dufour , kbuild-all@lists.01.org, clang-built-linux@googlegroups.com, Andrew Morton , Linux Memory Management List , David Hildenbrand , Oscar Salvador References: <202101100936.GwZyiMDo-lkp@intel.com> From: Rong Chen Message-ID: <7fc5e732-ee2e-a63b-c018-0fc89efe78c1@intel.com> Date: Wed, 13 Jan 2021 14:45:03 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/13/21 3:31 AM, Greg Kroah-Hartman wrote: > On Tue, Jan 12, 2021 at 08:30:16PM +0100, Greg Kroah-Hartman wrote: >> On Wed, Jan 13, 2021 at 12:49:52AM +0530, Souptick Joarder wrote: >>> On Tue, Jan 12, 2021 at 1:32 AM Greg Kroah-Hartman >>> wrote: >>>> On Tue, Jan 12, 2021 at 12:48:22AM +0530, Souptick Joarder wrote: >>>>> On Sun, Jan 10, 2021 at 6:33 AM kernel test robot wrote: >>>>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y >>>>>> head: 610bdbf6a174c9a91e34e276a9594114b44bef74 >>>>>> commit: b6f69f72c15d7f973f5709c5351f378f235b3654 [1441/2773] mm: don't rely on system state to detect hot-plug operations >>>>>> config: x86_64-randconfig-a001-20210110 (attached as .config) >>>>>> compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project bc556e5685c0f97e79fb7b3c6f15cc5062db8e36) >>>>>> reproduce (this is a W=1 build): >>>>>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >>>>>> chmod +x ~/bin/make.cross >>>>>> # install x86_64 cross compiling tool for clang build >>>>>> # apt-get install binutils-x86-64-linux-gnu >>>>>> # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=b6f69f72c15d7f973f5709c5351f378f235b3654 >>>>>> git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git >>>>>> git fetch --no-tags linux-stable-rc linux-4.19.y >>>>>> git checkout b6f69f72c15d7f973f5709c5351f378f235b3654 >>>>>> # save the attached .config to linux build tree >>>>>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 >>>>>> >>>>>> If you fix the issue, kindly add following tag as appropriate >>>>>> Reported-by: kernel test robot >>>>>> >>>>>> All warnings (new ones prefixed by >>): >>>>>> >>>>>>>> drivers/base/node.c:429:5: warning: no previous prototype for function 'register_mem_block_under_node_early' [-Wmissing-prototypes] >>>>>> int register_mem_block_under_node_early(struct memory_block *mem_blk, void *arg) >>>>>> ^ >>>>>> drivers/base/node.c:429:1: note: declare 'static' if the function is not intended to be used outside of this translation unit >>>>>> int register_mem_block_under_node_early(struct memory_block *mem_blk, void *arg) >>>>>> ^ >>>>>> static >>>>>> 1 warning generated. >>>>> It is fixed in the mainline. Will stable tree pick it from there ? >>>> What is the git commit id for this? >>> commit f85086f95fa3 (mm: don't rely on system state to detect >>> hot-plug operations) >>> which marks this function as static. >> Ah, that's not ok for stable trees. Don't worry about this, sparse >> issues for stuff like this is not a big deal for stable releases. > And it's already in the 4.19 tree, so I have no idea why 0-day is > complaining... Hi Greg, The function isn't marked as static in the 4.19 tree. # commit in mainline is "f85086f95fa3 (mm: don't rely on system state to detect hot-plug operations)" $ git show f85086f95fa3 | grep register_mem_block_under_node_early\( +static int register_mem_block_under_node_early(struct memory_block *mem_blk, # commit in linux-stable-rc/linux-4.19.y is "b6f69f72c15d (mm: don't rely on system state to detect hot-plug operations)" $ git show b6f69f72c15d | grep register_mem_block_under_node_early\( +int register_mem_block_under_node_early(struct memory_block *mem_blk, void *arg) Best Regards, Rong Chen From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============3075667736078960709==" MIME-Version: 1.0 From: Rong Chen To: kbuild-all@lists.01.org Subject: Re: [linux-stable-rc:linux-4.19.y 1441/2773] drivers/base/node.c:429:5: warning: no previous prototype for function 'register_mem_block_under_node_early' Date: Wed, 13 Jan 2021 14:45:03 +0800 Message-ID: <7fc5e732-ee2e-a63b-c018-0fc89efe78c1@intel.com> In-Reply-To: List-Id: --===============3075667736078960709== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 1/13/21 3:31 AM, Greg Kroah-Hartman wrote: > On Tue, Jan 12, 2021 at 08:30:16PM +0100, Greg Kroah-Hartman wrote: >> On Wed, Jan 13, 2021 at 12:49:52AM +0530, Souptick Joarder wrote: >>> On Tue, Jan 12, 2021 at 1:32 AM Greg Kroah-Hartman >>> wrote: >>>> On Tue, Jan 12, 2021 at 12:48:22AM +0530, Souptick Joarder wrote: >>>>> On Sun, Jan 10, 2021 at 6:33 AM kernel test robot w= rote: >>>>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux= -stable-rc.git linux-4.19.y >>>>>> head: 610bdbf6a174c9a91e34e276a9594114b44bef74 >>>>>> commit: b6f69f72c15d7f973f5709c5351f378f235b3654 [1441/2773] mm: don= 't rely on system state to detect hot-plug operations >>>>>> config: x86_64-randconfig-a001-20210110 (attached as .config) >>>>>> compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project= bc556e5685c0f97e79fb7b3c6f15cc5062db8e36) >>>>>> reproduce (this is a W=3D1 build): >>>>>> wget https://raw.githubusercontent.com/intel/lkp-tests/mast= er/sbin/make.cross -O ~/bin/make.cross >>>>>> chmod +x ~/bin/make.cross >>>>>> # install x86_64 cross compiling tool for clang build >>>>>> # apt-get install binutils-x86-64-linux-gnu >>>>>> # https://git.kernel.org/pub/scm/linux/kernel/git/stable/li= nux-stable-rc.git/commit/?id=3Db6f69f72c15d7f973f5709c5351f378f235b3654 >>>>>> git remote add linux-stable-rc https://git.kernel.org/pub/s= cm/linux/kernel/git/stable/linux-stable-rc.git >>>>>> git fetch --no-tags linux-stable-rc linux-4.19.y >>>>>> git checkout b6f69f72c15d7f973f5709c5351f378f235b3654 >>>>>> # save the attached .config to linux build tree >>>>>> COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dclang make.cr= oss ARCH=3Dx86_64 >>>>>> >>>>>> If you fix the issue, kindly add following tag as appropriate >>>>>> Reported-by: kernel test robot >>>>>> >>>>>> All warnings (new ones prefixed by >>): >>>>>> >>>>>>>> drivers/base/node.c:429:5: warning: no previous prototype for func= tion 'register_mem_block_under_node_early' [-Wmissing-prototypes] >>>>>> int register_mem_block_under_node_early(struct memory_block *mem= _blk, void *arg) >>>>>> ^ >>>>>> drivers/base/node.c:429:1: note: declare 'static' if the functio= n is not intended to be used outside of this translation unit >>>>>> int register_mem_block_under_node_early(struct memory_block *mem= _blk, void *arg) >>>>>> ^ >>>>>> static >>>>>> 1 warning generated. >>>>> It is fixed in the mainline. Will stable tree pick it from there ? >>>> What is the git commit id for this? >>> commit f85086f95fa3 (mm: don't rely on system state to detect >>> hot-plug operations) >>> which marks this function as static. >> Ah, that's not ok for stable trees. Don't worry about this, sparse >> issues for stuff like this is not a big deal for stable releases. > And it's already in the 4.19 tree, so I have no idea why 0-day is > complaining... Hi Greg, The function isn't marked as static in the 4.19 tree. # commit in mainline is "f85086f95fa3 (mm: don't rely on system state to = detect hot-plug operations)" $ git show f85086f95fa3 | grep register_mem_block_under_node_early\( +static int register_mem_block_under_node_early(struct memory_block = *mem_blk, # commit in linux-stable-rc/linux-4.19.y is "b6f69f72c15d (mm: don't = rely on system state to detect hot-plug operations)" $ git show b6f69f72c15d | grep register_mem_block_under_node_early\( +int register_mem_block_under_node_early(struct memory_block *mem_blk, = void *arg) Best Regards, Rong Chen --===============3075667736078960709==--