From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE46AC4363D for ; Fri, 2 Oct 2020 07:41:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D085206C1 for ; Fri, 2 Oct 2020 07:41:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726352AbgJBHlf (ORCPT ); Fri, 2 Oct 2020 03:41:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725961AbgJBHlf (ORCPT ); Fri, 2 Oct 2020 03:41:35 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E96A9C0613D0 for ; Fri, 2 Oct 2020 00:41:34 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1kOFh5-0005Rh-6T; Fri, 02 Oct 2020 09:41:31 +0200 Subject: Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles To: Krzysztof Kozlowski Cc: Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Anson Huang , Andreas Kemnade , Stefan Riedmueller , Robert Jones , Li Yang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20200930190143.27032-1-krzk@kernel.org> <20200930190143.27032-9-krzk@kernel.org> <0a0afea6-8cbb-3e89-5a4f-89660c942ca3@pengutronix.de> <20201001073208.GA5208@kozik-lap> <027fd826-6822-9e92-0c6c-2ebed63f4a07@pengutronix.de> <20201001103704.GA26287@kozik-lap> From: Ahmad Fatoum Message-ID: <7fcea21d-4651-9ba7-5331-86530296a847@pengutronix.de> Date: Fri, 2 Oct 2020 09:41:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201001103704.GA26287@kozik-lap> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On 10/1/20 12:37 PM, Krzysztof Kozlowski wrote: >> The existing binding doesn't cover these boards then and needs to be >> extended, no? How about following patch? > > What do you mean it doesn't cover? It was added exactly to handle them: > + - technexion,imx6q-pico-dwarf # TechNexion i.MX6Q Pico-Dwarf > + - technexion,imx6q-pico-hobbit # TechNexion i.MX6Q Pico-Hobbit > + - technexion,imx6q-pico-nymph # TechNexion i.MX6Q Pico-Nymph > + - technexion,imx6q-pico-pi # TechNexion i.MX6Q Pico-Pi > Still they are unused. So I'd think these boards should be handled like boards that predated bindings: a binding is written that doesn't break existing users. >> [I guess we need to keep the two-compatible list they were originally >> in for compatibility even if it's unused among upstream device trees?] > > You want to change both the binding (thus breaking the ABI) and update > the DTS to reflect new ABI. Then why having a binding at all? If we leave the old two-compatible enumeration intact, there is no ABI broken. > I would assume that either binding is correct or DTS. You propose that > both are wrong and both need changes... in such case this is clearly > broken. IMO the DTS is the correct one. If you want to honor the author's intention that each base board has a different compatible, it should be an extra compatible and not replace the existing one that may be already in use. Cheers Ahmad > > Best regards, > Krzysztof > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F10FC4363D for ; Fri, 2 Oct 2020 07:42:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08799206CA for ; Fri, 2 Oct 2020 07:42:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="1ORCnBqo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08799206CA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=q84CoKCpmgIVV1hqD9AIWDXKVwJpaSNclo+dLCnTCGg=; b=1ORCnBqobgyBOGKdMTXb6Uz8h USrtOKszbq7XcOoGy6W5FB8z65FIE5kFtnxvtHPitYC1rfan3iLWI7LXHjkG7rQwib/PHZsXaBqzb w9EM+82tz7zoMhLIV4x/yTPeEo30HkU0eDo9hPq016fFChyGRWYs4kz6EfG0HFhKLQg7SkOsKiX8U 1VVe8RP2KMfQCKS78pWQFdw41rRFFcawcXmpHTV6i0DxnglZPXRQInMp3vnSJt3eL7wz2IeAl0rCM 4wUZZGmeuS00BQwYHRLVlu3Gtev0COyTH9AgI0KORINikTSv9Tb3bpcQFbFQYCWp8gi7gnpecLXTX 0jNQjVddg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOFhA-0001Cj-2Z; Fri, 02 Oct 2020 07:41:36 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOFh6-0001CA-Oq for linux-arm-kernel@lists.infradead.org; Fri, 02 Oct 2020 07:41:33 +0000 Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1kOFh5-0005Rh-6T; Fri, 02 Oct 2020 09:41:31 +0200 Subject: Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles To: Krzysztof Kozlowski References: <20200930190143.27032-1-krzk@kernel.org> <20200930190143.27032-9-krzk@kernel.org> <0a0afea6-8cbb-3e89-5a4f-89660c942ca3@pengutronix.de> <20201001073208.GA5208@kozik-lap> <027fd826-6822-9e92-0c6c-2ebed63f4a07@pengutronix.de> <20201001103704.GA26287@kozik-lap> From: Ahmad Fatoum Message-ID: <7fcea21d-4651-9ba7-5331-86530296a847@pengutronix.de> Date: Fri, 2 Oct 2020 09:41:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201001103704.GA26287@kozik-lap> Content-Language: en-US X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201002_034132_823832_FB664796 X-CRM114-Status: GOOD ( 19.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Robert Jones , Stefan Riedmueller , Anson Huang , Shawn Guo , Sascha Hauer , linux-kernel@vger.kernel.org, Li Yang , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Andreas Kemnade , Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, On 10/1/20 12:37 PM, Krzysztof Kozlowski wrote: >> The existing binding doesn't cover these boards then and needs to be >> extended, no? How about following patch? > > What do you mean it doesn't cover? It was added exactly to handle them: > + - technexion,imx6q-pico-dwarf # TechNexion i.MX6Q Pico-Dwarf > + - technexion,imx6q-pico-hobbit # TechNexion i.MX6Q Pico-Hobbit > + - technexion,imx6q-pico-nymph # TechNexion i.MX6Q Pico-Nymph > + - technexion,imx6q-pico-pi # TechNexion i.MX6Q Pico-Pi > Still they are unused. So I'd think these boards should be handled like boards that predated bindings: a binding is written that doesn't break existing users. >> [I guess we need to keep the two-compatible list they were originally >> in for compatibility even if it's unused among upstream device trees?] > > You want to change both the binding (thus breaking the ABI) and update > the DTS to reflect new ABI. Then why having a binding at all? If we leave the old two-compatible enumeration intact, there is no ABI broken. > I would assume that either binding is correct or DTS. You propose that > both are wrong and both need changes... in such case this is clearly > broken. IMO the DTS is the correct one. If you want to honor the author's intention that each base board has a different compatible, it should be an extra compatible and not replace the existing one that may be already in use. Cheers Ahmad > > Best regards, > Krzysztof > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel