From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jorge Ramirez <jorge.ramirez-ortiz@linaro.org>
Date: Thu, 25 May 2017 20:38:47 +0200
Subject: [U-Boot] [PATCHv4 3/3] ARM64: poplar: hi3798cv200: u-boot
 support for Poplar 96Boards
In-Reply-To: <20170517220623.GL4631@bill-the-cat>
References: <016bfa5b-ee73-1783-3ca9-34182d813eca@linaro.org>
 <20170510023000.GZ12511@bill-the-cat>
 <e5c5cb79-6047-6007-8bd4-048ff1b3f372@linaro.org>
 <20170510144927.GF12511@bill-the-cat>
 <CAL_JsqJz6rMYo=E_9AZ4-zg2MsOV+DvaOR0vPYqxA7AZbA9_sA@mail.gmail.com>
 <20170510174555.GH12511@bill-the-cat>
 <CAL_JsqLja8RwZtEjSXP+c9UwY7Hpd+7OAM_NZ2srreOtYUYpow@mail.gmail.com>
 <CAPnjgZ3CjT8iXXSVbVqFAu5COHgAgBNjw2D5QvtG3w=pEL-mMw@mail.gmail.com>
 <20170511123547.GC5701@bill-the-cat>
 <f0d08b87-43e0-a7da-7ea7-a67927002fe7@linaro.org>
 <20170517220623.GL4631@bill-the-cat>
Message-ID: <7fd042e6-fb1f-a4ee-0a54-c39a0e25ef40@linaro.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 05/18/2017 12:06 AM, Tom Rini wrote:
>>>> having platform data.
>>> No, I think we're going for overkill here by not doing serial_pl01x.c as
>>> platform data.  ns16550 does platform data for this already.  This
>>> sounds like the lowest overhead way to get the clock populated and not
>>> have some DT data that's not going to be accepted upstream.
>>>
>> ummmm I am a bit lost at this point, could we recap please?
> Lets update the recap:
> - Please re-submit the dts file, now with whatever form is in v4.12-rc1,
>    saying as such in the commit (if it's just the commit message that
>    changes, that's fine and great).

The DTS file in v4.12-rc2 still does NOT contain the usb node.

==> Should I then not use the DM on USB so I can avoid DTS changes?


> - Please update serial_pl01x.c to be able to get the clock via platform
>    data, update and test your board to confirm it works.

um, It gets tricky;
I can not use platform_data since I can not use SERIAL_DM because the 
device tree does have a UART node which gets picked up.

I will have to disable DM_SERIAL and add some configs in 
include/configs/poplar.h

+#define CONFIG_PL011_SERIAL  1
+#define CONFIG_PL011_CLOCK   75000000
+#define CONFIG_PL01x_PORTS   {(void *) 0xF8B00000,}
+#define CONFIG_CONS_INDEX    0

==> is this acceptable? if not, then what should I do?

> - It'd be awesome if you do, but it won't block your series if you
>    don't, update the rest of the platforms that had been using the
>    "clock" platform to instead use the platform data method.
>
> Thanks!