Re: [PATCH v6 2/3] fpga: bridge: Use standard dev_release for class driver

[Russ Weight <russell.h.weight@intel.com>]

On 6/22/21 1:23 AM, Xu Yilun wrote:
> 2 more comments.
>
> On Mon, Jun 21, 2021 at 03:22:48PM -0700, Russ Weight wrote:
>> The FPGA bridge class driver data structure is being treated as a
>> managed resource instead of using standard dev_release call-back
>> to release the class data structure. This change removes the
>> managed resource code and combines the create() and register()
>> functions into a single register() function.
>>
>> Signed-off-by: Russ Weight <russell.h.weight@intel.com>
>> ---
>> v6:
>>   - Changed fpga_bridge_register() parameters to accept an info data
>>     structure to provide flexibility in passing optional parameters.
>>   - Added fpga_bridge_register_simple() function to support current
>>     parameters for users that don't require the use of optional
>>     parameters.
> Add the _simple() description in commit message if needed.
>
>> +struct fpga_bridge *
>> +fpga_bridge_register_simple(struct device *dev, const char *name,
> 			       struct device *parent,

Yes - I'll make these changes.

Thanks,
- Russ
>
>> +			    const struct fpga_bridge_ops *br_ops,
>> +			    void *priv);
>> +void fpga_bridge_unregister(struct fpga_bridge *br);
>>  
>>  #endif /* _LINUX_FPGA_BRIDGE_H */
>> -- 
>> 2.25.1