From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AFCDC433EF for ; Wed, 13 Oct 2021 14:18:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 50E6760ED4 for ; Wed, 13 Oct 2021 14:18:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236097AbhJMOUX (ORCPT ); Wed, 13 Oct 2021 10:20:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:37480 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233590AbhJMOUW (ORCPT ); Wed, 13 Oct 2021 10:20:22 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5FDEC610CB; Wed, 13 Oct 2021 14:18:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634134699; bh=o4y3ndbyguXXtobJH495oY++cOr/9vmGtB8WTaG/fpU=; h=Date:Subject:To:References:From:In-Reply-To:From; b=av+dZT88Z7sB4/D4rZDz/3/76Rv7wPRbzhefNoP52xc09A28Tl1oUmSPBUeKsrMYT ACebys9J1xqMDsiVHHaVra8KMWUVwy7Ee+t/uZuQLruSzaJFUxw2U51F6WAxjeaXV5 4ITzaH194SQ3y8sAPselBloAPvhmSL/b8sLOQrd9w+1dMdg19PSC+xlcH+NsnSPA1d hivnPn5Pzba/yZXb6dY5c/COdghhEv2D27K8/4alD2J/9l1sJw1NBNe1yicu4rc3cK PjqpLeB5XqMFs8WXfJ6kbIvG5MABD81Iln+9iTunyGH0+gVgYg4uD8wKbx65LoOKSQ GdplvWJKaj2Xg== Message-ID: <7feca651-b87d-2d00-7a2e-5e66b4f81221@kernel.org> Date: Wed, 13 Oct 2021 22:18:16 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH] f2fs: replace snprintf in show functions with sysfs_emit Content-Language: en-US To: Qing Wang , Jaegeuk Kim , linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <1634095744-4579-1-git-send-email-wangqing@vivo.com> From: Chao Yu In-Reply-To: <1634095744-4579-1-git-send-email-wangqing@vivo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/10/13 11:29, Qing Wang wrote: > coccicheck complains about the use of snprintf() in sysfs show functions. > > Fix the following coccicheck warning: > fs/f2fs/sysfs.c:198:12-20: WARNING: use scnprintf or sprintf. > fs/f2fs/sysfs.c:247:8-16: WARNING: use scnprintf or sprintf. > > Use sysfs_emit instead of scnprintf or sprintf makes more sense. > > Signed-off-by: Qing Wang Reviewed-by: Chao Yu Thanks, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C66DC433EF for ; Wed, 13 Oct 2021 14:18:27 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C6D96610C8; Wed, 13 Oct 2021 14:18:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C6D96610C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1maf5O-0001IH-3J; Wed, 13 Oct 2021 14:18:26 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maf5N-0001IB-5a for linux-f2fs-devel@lists.sourceforge.net; Wed, 13 Oct 2021 14:18:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=R8wdD8gTE4znP8ZINdANP9pRA9FXiK3VqbYWNglAT68=; b=H2Qcxo4///2YnynJiIdqCfzXRV WfjVymFqhRagNwcyNxh1eMsoQsBh4xfbF8qN2WiILHu1Ft6B5Jt8uEtv3QZbP1tO9kiNVLf3wTTX0 XJOYdCH0xYszaZJ1XaXqpUdidrJZfpKQ/pQbswbtgOmSvUnXqZi3rL0fJbaWBqChYk2w=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=R8wdD8gTE4znP8ZINdANP9pRA9FXiK3VqbYWNglAT68=; b=HJd+jR6sj32hrmB6RT5V8sH8EB ibxS3dj3z6GvH1T6pzWsL7crtiE2NMTyCIKXF6O42mJDrPorXaL5zLC1sNeh48V0bJhSFNNQN90DU G//XxHFq53STMCwk/MceVoNsIJ9oJ3t87zxr4PtG9dd2C32XSC1cI1OrQCsbCk+wWEus=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1maf5M-008S5s-Kc for linux-f2fs-devel@lists.sourceforge.net; Wed, 13 Oct 2021 14:18:25 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5FDEC610CB; Wed, 13 Oct 2021 14:18:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634134699; bh=o4y3ndbyguXXtobJH495oY++cOr/9vmGtB8WTaG/fpU=; h=Date:Subject:To:References:From:In-Reply-To:From; b=av+dZT88Z7sB4/D4rZDz/3/76Rv7wPRbzhefNoP52xc09A28Tl1oUmSPBUeKsrMYT ACebys9J1xqMDsiVHHaVra8KMWUVwy7Ee+t/uZuQLruSzaJFUxw2U51F6WAxjeaXV5 4ITzaH194SQ3y8sAPselBloAPvhmSL/b8sLOQrd9w+1dMdg19PSC+xlcH+NsnSPA1d hivnPn5Pzba/yZXb6dY5c/COdghhEv2D27K8/4alD2J/9l1sJw1NBNe1yicu4rc3cK PjqpLeB5XqMFs8WXfJ6kbIvG5MABD81Iln+9iTunyGH0+gVgYg4uD8wKbx65LoOKSQ GdplvWJKaj2Xg== Message-ID: <7feca651-b87d-2d00-7a2e-5e66b4f81221@kernel.org> Date: Wed, 13 Oct 2021 22:18:16 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Content-Language: en-US To: Qing Wang , Jaegeuk Kim , linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <1634095744-4579-1-git-send-email-wangqing@vivo.com> From: Chao Yu In-Reply-To: <1634095744-4579-1-git-send-email-wangqing@vivo.com> X-Headers-End: 1maf5M-008S5s-Kc Subject: Re: [f2fs-dev] [PATCH] f2fs: replace snprintf in show functions with sysfs_emit X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2021/10/13 11:29, Qing Wang wrote: > coccicheck complains about the use of snprintf() in sysfs show functions. > > Fix the following coccicheck warning: > fs/f2fs/sysfs.c:198:12-20: WARNING: use scnprintf or sprintf. > fs/f2fs/sysfs.c:247:8-16: WARNING: use scnprintf or sprintf. > > Use sysfs_emit instead of scnprintf or sprintf makes more sense. > > Signed-off-by: Qing Wang Reviewed-by: Chao Yu Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel