From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752985AbdCPO4o (ORCPT ); Thu, 16 Mar 2017 10:56:44 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:57156 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752973AbdCPO4L (ORCPT ); Thu, 16 Mar 2017 10:56:11 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfec7f5-f79d06d000004445-74-58caa744fd62 Subject: Re: [PATCH 20/41] drm/bridge: analogix_dp: Set PD_INC_BG first when powering up edp phy To: Sean Paul , linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org Cc: zain wang , Lin Huang , Tomeu Vizoso , Douglas Anderson , linux-kernel@vger.kernel.org, Yakir Yang , Tomasz Figa , =?UTF-8?Q?St=c3=a9phane_Marchesin?= From: Andrzej Hajda Message-id: <7ff09253-a4c3-4086-5224-c0c704d5800f@samsung.com> Date: Thu, 16 Mar 2017 15:54:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 In-reply-to: <20170310043305.17216-21-seanpaul@chromium.org> Content-transfer-encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrDKsWRmVeSWpSXmKPExsWy7djPc7ouy09FGKxZLGJxdtlBNosrX9+z WfzYcIrZ4vKuOWwWnx78Z7aYd+g3o8XdDWcZLTYv+cRs0bf2EptF23Uxi3MNk9kduD2e73rN 5DG74SKLx467Sxg97ncfZ/LYvKTe4++s/SwenzfJBbBHcdmkpOZklqUW6dslcGX87BIueCBY 0fOutoFxIV8XIweHhICJxOlFdV2MnECmmMSFe+vZuhi5OIQEljJKnGk4ywLhfGaU2HVkBSNE lYnE8n33mCASyxglLn28wgqS4BUQlPgx+R4LiM0soCnx4sskqO5njBLzH+0ASwgLJEk86voI NklEIEdiyfFDrCBFzAIHmSQaVj1gBkmwAXX/3XyTDWKqncTbBQfAbBYBVYnm41+YQGxRgQiJ HTd6wOKcAjYSN5uXQW2Wlzh45TnYZgmBS+wSZ399YYd4VFZi0wFmCNNFYt+HbIhvhCVeHd/C DmHLSFye3A3V2s0o8an/BDuEM4VR4t+HGcwQVdYSh49fZIVYxicxadt0qKG8Eh1tQhAlHhLt XY+hhjpKzL81CxoSB4CG7l7OOIFRfhZSiM1CCrFZSH5YwMi8ilEktbQ4Nz212FSvODG3uDQv XS85P3cTIzANnf53/OsOxqXHrA4xCnAwKvHwZiw8FSHEmlhWXJl7iFGCg1lJhNd1CVCINyWx siq1KD++qDQntfgQozQHi5I4754FV8KFBNITS1KzU1MLUotgskwcnFINjGou+fVhCysfCi1Q eZel8eV87Js/tjaxgTtuH23Q3ZRat3DJm+OXuXKmBVme97905O3XE6cbHFf5nfniMO9+yjTH z+cfaVmVzs+OWlKvFf/9zRN9dZ1On3Oc6d3Lxd8uXXyQ4Yz0xt7SlozgX5wMy69bf/6qbt2a 1Xqynkl+5p+stmfb2Bl+LVRiKc5INNRiLipOBAArfuErPwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrFIsWRmVeSWpSXmKPExsVy+t/xy7qBy09FGOxo57Q4u+wgm8WVr+/Z LH5sOMVscXnXHDaLTw/+M1vMO/Sb0eLuhrOMFpuXfGK26Ft7ic2i7bqYxbmGyewO3B7Pd71m 8pjdcJHFY8fdJYwe97uPM3lsXlLv8XfWfhaPz5vkAtij3GwyUhNTUosUUvOS81My89JtlUJD 3HQtlBTyEnNTbZUidH1DgpQUyhJzSoE8IwM04OAc4B6spG+X4Jbxs0u44IFgRc+72gbGhXxd jJwcEgImEsv33WOCsMUkLtxbz9bFyMUhJLCEUaK3+xQzSIJXQFDix+R7LF2MHBzMAuoSU6bk QtQ8Y5R4tPUlK0iNsECSxKOuj4wgNSICORI/u/Uhag4wSrxft5QFxGEWOMgk8f/KEbChbAKa En8332SDWGAn8XbBATCbRUBVovn4F7CLRAUiJOY/XQVmcwrYSNxsXsYCYjMLyEscvPKcZQKj wCwk981CuG8WkqoFjMyrGEVSS4tz03OLjfSKE3OLS/PS9ZLzczcxAuNx27GfW3Ywdr0LPsQo wMGoxMMrMP9UhBBrYllxZe4hRgkOZiURXtclQCHelMTKqtSi/Pii0pzU4kOMpkC3TmSWEk3O B6aKvJJ4QxNDc0tDI2MLC3MjIyVx3qkfroQLCaQnlqRmp6YWpBbB9DFxcEo1MF7V25G+XeXI eaaCXSvWJuVO9Z5bLFQp/WKO5bTUD5H5F3h2LU96cHjz9QemOz6pz1O4p+PBPkNLUOTtRY+1 LzyOT/z2wUTjcOPfN1Fu7zd2G1xrUPPT8vVYeuW27T5tuaX1ovXpz3a8fbTnodnSOalTf0eu WnZA/HwG281+dtu93suWbDscY5OgxFKckWioxVxUnAgA42UGtt0CAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170316145459eucas1p1d914dd6bc9aec83c7b87e5fd32229511 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRvsgrw=?= =?UTF-8?B?7ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRtTYW1z?= =?UTF-8?B?dW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170310044553epcas3p3a909d151787f224e8edee460a3f57e56 X-RootMTR: 20170310044553epcas3p3a909d151787f224e8edee460a3f57e56 References: <20170310043305.17216-1-seanpaul@chromium.org> <20170310043305.17216-21-seanpaul@chromium.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10.03.2017 05:32, Sean Paul wrote: > From: zain wang > > Following the correct power up sequence: > dp_pd=ff => dp_pd=7f => wait 10us => dp_pd=00 Please fix the message. > > Cc: Stéphane Marchesin > Signed-off-by: zain wang > Signed-off-by: Sean Paul > --- > drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 10 ++++++++-- > drivers/gpu/drm/bridge/analogix/analogix_dp_reg.h | 3 +++ > 2 files changed, 11 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c > index b47c5af43560..bb72f8b0e603 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c > @@ -321,10 +321,16 @@ void analogix_dp_set_analog_power_down(struct analogix_dp_device *dp, > break; > case POWER_ALL: > if (enable) { > - reg = DP_PHY_PD | AUX_PD | CH3_PD | CH2_PD | > - CH1_PD | CH0_PD; > + reg = DP_ALL_PD; > writel(reg, dp->reg_base + phy_pd_addr); > } else { > + reg = DP_ALL_PD; > + writel(reg, dp->reg_base + phy_pd_addr); Do we need it? register should be already at proper state, shouldn't be? > + usleep_range(10, 15); > + reg &= ~DP_INC_BG; > + writel(reg, dp->reg_base + phy_pd_addr); > + usleep_range(10, 15); > + > writel(0x00, dp->reg_base + phy_pd_addr); > } > break; > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.h b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.h > index 40200c652533..9602668669f4 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.h > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.h > @@ -342,12 +342,15 @@ > #define DP_PLL_REF_BIT_1_2500V (0x7 << 0) > > /* ANALOGIX_DP_PHY_PD */ > +#define DP_INC_BG (0x1 << 7) > +#define DP_EXP_BG (0x1 << 6) > #define DP_PHY_PD (0x1 << 5) > #define AUX_PD (0x1 << 4) > #define CH3_PD (0x1 << 3) > #define CH2_PD (0x1 << 2) > #define CH1_PD (0x1 << 1) > #define CH0_PD (0x1 << 0) > +#define DP_ALL_PD (0xff) > > /* ANALOGIX_DP_PHY_TEST */ > #define MACRO_RST (0x1 << 5) From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrzej Hajda Subject: Re: [PATCH 20/41] drm/bridge: analogix_dp: Set PD_INC_BG first when powering up edp phy Date: Thu, 16 Mar 2017 15:54:58 +0100 Message-ID: <7ff09253-a4c3-4086-5224-c0c704d5800f@samsung.com> References: <20170310043305.17216-1-seanpaul@chromium.org> <20170310043305.17216-21-seanpaul@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <20170310043305.17216-21-seanpaul@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sean Paul , linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org Cc: zain wang , Lin Huang , Tomeu Vizoso , linux-kernel@vger.kernel.org, Douglas Anderson , Yakir Yang , Tomasz Figa , =?UTF-8?Q?St=c3=a9phane_Marchesin?= List-Id: linux-rockchip.vger.kernel.org T24gMTAuMDMuMjAxNyAwNTozMiwgU2VhbiBQYXVsIHdyb3RlOgo+IEZyb206IHphaW4gd2FuZyA8 d3p6QHJvY2stY2hpcHMuY29tPgo+Cj4gRm9sbG93aW5nIHRoZSBjb3JyZWN0IHBvd2VyIHVwIHNl cXVlbmNlOgo+IGRwX3BkPWZmID0+IGRwX3BkPTdmID0+IHdhaXQgMTB1cyA9PiBkcF9wZD0wMAoK UGxlYXNlIGZpeCB0aGUgbWVzc2FnZS4KCj4KPiBDYzogU3TDqXBoYW5lIE1hcmNoZXNpbiA8bWFy Y2hldUBjaHJvbWl1bS5vcmc+Cj4gU2lnbmVkLW9mZi1ieTogemFpbiB3YW5nIDx3enpAcm9jay1j aGlwcy5jb20+Cj4gU2lnbmVkLW9mZi1ieTogU2VhbiBQYXVsIDxzZWFucGF1bEBjaHJvbWl1bS5v cmc+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYW5hbG9naXgvYW5hbG9naXhfZHBf cmVnLmMgfCAxMCArKysrKysrKy0tCj4gIGRyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYW5hbG9naXgv YW5hbG9naXhfZHBfcmVnLmggfCAgMyArKysKPiAgMiBmaWxlcyBjaGFuZ2VkLCAxMSBpbnNlcnRp b25zKCspLCAyIGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9i cmlkZ2UvYW5hbG9naXgvYW5hbG9naXhfZHBfcmVnLmMgYi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdl L2FuYWxvZ2l4L2FuYWxvZ2l4X2RwX3JlZy5jCj4gaW5kZXggYjQ3YzVhZjQzNTYwLi5iYjcyZjhi MGU2MDMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hbmFsb2dpeC9hbmFs b2dpeF9kcF9yZWcuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYW5hbG9naXgvYW5h bG9naXhfZHBfcmVnLmMKPiBAQCAtMzIxLDEwICszMjEsMTYgQEAgdm9pZCBhbmFsb2dpeF9kcF9z ZXRfYW5hbG9nX3Bvd2VyX2Rvd24oc3RydWN0IGFuYWxvZ2l4X2RwX2RldmljZSAqZHAsCj4gIAkJ YnJlYWs7Cj4gIAljYXNlIFBPV0VSX0FMTDoKPiAgCQlpZiAoZW5hYmxlKSB7Cj4gLQkJCXJlZyA9 IERQX1BIWV9QRCB8IEFVWF9QRCB8IENIM19QRCB8IENIMl9QRCB8Cj4gLQkJCQlDSDFfUEQgfCBD SDBfUEQ7Cj4gKwkJCXJlZyA9IERQX0FMTF9QRDsKPiAgCQkJd3JpdGVsKHJlZywgZHAtPnJlZ19i YXNlICsgcGh5X3BkX2FkZHIpOwo+ICAJCX0gZWxzZSB7Cj4gKwkJCXJlZyA9IERQX0FMTF9QRDsK PiArCQkJd3JpdGVsKHJlZywgZHAtPnJlZ19iYXNlICsgcGh5X3BkX2FkZHIpOwpEbyB3ZSBuZWVk IGl0PyByZWdpc3RlciBzaG91bGQgYmUgYWxyZWFkeSBhdCBwcm9wZXIgc3RhdGUsIHNob3VsZG4n dCBiZT8KPiArCQkJdXNsZWVwX3JhbmdlKDEwLCAxNSk7Cj4gKwkJCXJlZyAmPSB+RFBfSU5DX0JH Owo+ICsJCQl3cml0ZWwocmVnLCBkcC0+cmVnX2Jhc2UgKyBwaHlfcGRfYWRkcik7Cj4gKwkJCXVz bGVlcF9yYW5nZSgxMCwgMTUpOwo+ICsKPiAgCQkJd3JpdGVsKDB4MDAsIGRwLT5yZWdfYmFzZSAr IHBoeV9wZF9hZGRyKTsKPiAgCQl9Cj4gIAkJYnJlYWs7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9icmlkZ2UvYW5hbG9naXgvYW5hbG9naXhfZHBfcmVnLmggYi9kcml2ZXJzL2dwdS9k cm0vYnJpZGdlL2FuYWxvZ2l4L2FuYWxvZ2l4X2RwX3JlZy5oCj4gaW5kZXggNDAyMDBjNjUyNTMz Li45NjAyNjY4NjY5ZjQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hbmFs b2dpeC9hbmFsb2dpeF9kcF9yZWcuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYW5h bG9naXgvYW5hbG9naXhfZHBfcmVnLmgKPiBAQCAtMzQyLDEyICszNDIsMTUgQEAKPiAgI2RlZmlu ZSBEUF9QTExfUkVGX0JJVF8xXzI1MDBWCQkJKDB4NyA8PCAwKQo+ICAKPiAgLyogQU5BTE9HSVhf RFBfUEhZX1BEICovCj4gKyNkZWZpbmUgRFBfSU5DX0JHCQkJCSgweDEgPDwgNykKPiArI2RlZmlu ZSBEUF9FWFBfQkcJCQkJKDB4MSA8PCA2KQo+ICAjZGVmaW5lIERQX1BIWV9QRAkJCQkoMHgxIDw8 IDUpCj4gICNkZWZpbmUgQVVYX1BECQkJCQkoMHgxIDw8IDQpCj4gICNkZWZpbmUgQ0gzX1BECQkJ CQkoMHgxIDw8IDMpCj4gICNkZWZpbmUgQ0gyX1BECQkJCQkoMHgxIDw8IDIpCj4gICNkZWZpbmUg Q0gxX1BECQkJCQkoMHgxIDw8IDEpCj4gICNkZWZpbmUgQ0gwX1BECQkJCQkoMHgxIDw8IDApCj4g KyNkZWZpbmUgRFBfQUxMX1BECQkJCSgweGZmKQo+ICAKPiAgLyogQU5BTE9HSVhfRFBfUEhZX1RF U1QgKi8KPiAgI2RlZmluZSBNQUNST19SU1QJCQkJKDB4MSA8PCA1KQoKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=