Re: [Qemu-devel] [PATCH V5] migration: add capability to bypass the shared memory

From: "Cédric Le Goater" <clg@kaod.org>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Lai Jiangshan <jiangshanlai@gmail.com>
Cc: Juan Quintela <quintela@redhat.com>,
	Eric Blake <eblake@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Sebastien Boeuf <sebastien.boeuf@intel.com>,
	"James O . D . Hunt" <james.o.hunt@intel.com>,
	Xu Wang <gnawux@gmail.com>, Peng Tao <bergwolf@gmail.com>,
	Xiao Guangrong <xiaoguangrong@tencent.com>,
	Xiao Guangrong <xiaoguangrong.eric@gmail.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH V5] migration: add capability to bypass the shared memory
Date: Fri, 27 Apr 2018 09:47:23 +0200	[thread overview]
Message-ID: <7ff588d8-c9a0-b608-357a-8b8cc02407e3@kaod.org> (raw)
In-Reply-To: <20180426190523.GR2631@work-vm>

On 04/26/2018 09:05 PM, Dr. David Alan Gilbert wrote:
>>> Can you please rework this to combine with Cédric Le Goater's
>>> 'discard non-migratable RAMBlocks' - it's quite similar to what you're
>>> trying to do but for a different reason;  If you look at the v2 from
>>> April 13, I think you can  just find somewhere to clear the
>>> RAM_MIGRATABLE flag.
>> Hello Dave:
>>
>> It seems we need to add new qmp/hmp command to clear/add
>> RAM_MIGRATABLE flag which is overkill for such a simple feature.
>> Please point out if there is any simple way to do so.
> I'm fine with you still using a capability to enable/disable it - I
> think that part of your patch is fine;  but then I think you just
> need to check that capability somewhere in Cedric's code; perhaps in his
> qemu_ram_is_migratable?
> 

I have a v3 for this patch but it only adds an error_report(). Working
on the v2 should be fine.

Thanks,

C.