All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: oobitots@cisco.com, openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] dtc: improve reproducibility
Date: Wed, 20 Jan 2021 21:21:23 +0000	[thread overview]
Message-ID: <7ffdf606187272d4b63d60b5b4b9e791741b3843.camel@linuxfoundation.org> (raw)
In-Reply-To: <20210120182001.20523-1-oobitots@cisco.com>

On Wed, 2021-01-20 at 10:20 -0800, Oleksiy Obitotskyy via
lists.openembedded.org wrote:
> Makefile override CFLAGS, so -fmacro/debug-prefix-map
> optiions was omitted and binaries contains absolute
> patch to sources.
> 
> Signed-off-by: Oleksiy Obitotskyy <oobitots@cisco.com>
> ---
>  meta/recipes-kernel/dtc/dtc.inc               | 10 +++++-
>  ...-Makefile-to-add-CFLAGS-not-override.patch | 36 +++++++++++++++++++
>  2 files changed, 45 insertions(+), 1 deletion(-)
>  create mode 100644 meta/recipes-kernel/dtc/dtc/0001-dtc-Fix-Makefile-to-add-CFLAGS-not-override.patch
> 
> diff --git a/meta/recipes-kernel/dtc/dtc.inc b/meta/recipes-kernel/dtc/dtc.inc
> index 0650e3c82e..59badd4951 100644
> --- a/meta/recipes-kernel/dtc/dtc.inc
> +++ b/meta/recipes-kernel/dtc/dtc.inc
> @@ -8,6 +8,14 @@ DEPENDS = "flex-native bison-native"
>  SRC_URI = "git://git.kernel.org/pub/scm/utils/dtc/dtc.git \
>             file://make_install.patch \
>             "
> +
> +def get_reproducibility_patches(d):
> +     if bb.data.inherits_class("reproducible_build", d):
> +        return "file://0001-dtc-Fix-Makefile-to-add-CFLAGS-not-override.patch"
> +     return ""
> +
> +SRC_URI += "${@get_reproducibility_patches(d)}"
> +
>  UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>\d+(\.\d+)+)"

Thanks for looking at this, its good to get some of the remaining
issues sorted!

Is there a reason we can't always apply this patch?

Cheers,

Richard



  reply	other threads:[~2021-01-20 21:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20 18:20 [PATCH] dtc: improve reproducibility Oleksiy Obitotskyy
2021-01-20 21:21 ` Richard Purdie [this message]
2021-01-20 21:59 ` [OE-core] " Otavio Salvador
2021-01-20 22:17   ` Khem Raj
2021-01-21  7:26     ` Oleksiy Obitotskyy
2021-01-21  9:08       ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ffdf606187272d4b63d60b5b4b9e791741b3843.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=oobitots@cisco.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.