From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2 01/20] net/ice: add base code
Date: Thu, 6 Dec 2018 06:23:23 +0000
Message-ID: <7fffada0-ff6a-8450-c3f4-8705d5c9864b@intel.com>
References: <1542956179-80951-1-git-send-email-wenzhuo.lu@intel.com>
 <1543820821-108122-1-git-send-email-wenzhuo.lu@intel.com>
 <1543820821-108122-2-git-send-email-wenzhuo.lu@intel.com>
 <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C4507@BGSMSX101.gar.corp.intel.com>
 <6A0DE07E22DDAD4C9103DF62FEBC09093FE1159D@shsmsx102.ccr.corp.intel.com>
 <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2D40F9@BGSMSX101.gar.corp.intel.com>
 <6A0DE07E22DDAD4C9103DF62FEBC09093FE11765@shsmsx102.ccr.corp.intel.com>
 <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2D4234@BGSMSX101.gar.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
To: "Varghese, Vipin" <vipin.varghese@intel.com>,
 "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id CEF291B101
 for <dev@dpdk.org>; Thu,  6 Dec 2018 07:23:25 +0100 (CET)
In-Reply-To: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2D4234@BGSMSX101.gar.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 12/6/2018 6:03 AM, Varghese, Vipin wrote:
> snipped
>>>>>
>>>>>> +Intel® ICE driver
>>>>>> +==================
>>>>>> +
>>>>>> +This directory contains source code of FreeBSD ice driver of
>>>>>> +version
>>>>>> +2018.10.30 released by the team which develops basic drivers
>>>>>> +for any ice NIC. The directory of base/ contains the original
>>>>>> +source
>>> package.
>>>>>> +This driver is valid for the product(s) listed below
>>>>>> +
>>>>>> +* Intel® Ethernet Network Adapters E810
>>>>>> +
>>>>>> +Updating the driver
>>>>>> +===================
>>>>>> +
>>>>>> +NOTE: The source code in this directory should not be modified
>>>>>> +apart from the following file(s):
>>>>>> +
>>>>>> +    ice_osdep.h
>>>>>
>>>>> I this README persistent in upcoming releases of 'driver/net/ice'?
>>>> Yes.
>>> If Linux driver is enabled in 4.20.1 or higher, then will the wording
>>> 'This directory contains source code of FreeBSD ice driver of' still hold true?
>> Although I don't understand why we talk about the Linux driver version, but I
>> think the answer is yes.
> Ok, reason for linux driver is because 
> 1. you would be planning to push the default kernel driver to linux for ICE.
> 2. the documentation states FreeBSD 2018.10.30, so if there is future enhancement pulled from linux driver this would added here too?
> 
>>
>>>
>>>>>
>>> snipped
>>>>>> +#define ICE_AQC_MAN_MAC_UPDATE_LAA	0
>>>>>> +#define ICE_AQC_MAN_MAC_UPDATE_LAA_WOL	(BIT(0) <<
>>>>>> ICE_AQC_MAN_MAC_WR_S)
>>>>>
>>>>> Can the code be rearranged for?
>>>> We don’t want to change the base code for the sake of maintenance.
>>> I do not follow this, is not your team or individual maintaining the same?
>>> because there should be maintainer for this PMD.
>> This code is not implemented by us. You can take us as a representative of the
>> develop team.
>> If any bug, we'll hande it.
> Ok, currently the team which maintains the code do not want to change the order of code for sake of maintenance. Confusing approach, but I leave this to other members to comment.

Hi Vipin,

Of course driver team maintains the code, only Intel follows a process to update
base code instead of directly updating it which also covers synchronization with
kernel code as you shared the concern above, this process is not specific to ice
driver.