From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754235AbdHYAGE (ORCPT ); Thu, 24 Aug 2017 20:06:04 -0400 Received: from mail-pg0-f51.google.com ([74.125.83.51]:34706 "EHLO mail-pg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753428AbdHYAGB (ORCPT ); Thu, 24 Aug 2017 20:06:01 -0400 From: Kevin Hilman To: Ulf Hansson Cc: Jerome Brunet , Carlo Caione , "linux-mmc\@vger.kernel.org" , "open list\:ARM\/Amlogic Meson..." , "linux-arm-kernel\@lists.infradead.org" , "linux-kernel\@vger.kernel.org" Subject: Re: [PATCH v2 00/16] mmc: meson-gx: driver fixups and upgrades Organization: BayLibre References: <20170821160301.21899-1-jbrunet@baylibre.com> <1503402390.7032.11.camel@baylibre.com> Date: Thu, 24 Aug 2017 17:05:59 -0700 In-Reply-To: (Ulf Hansson's message of "Wed, 23 Aug 2017 15:10:25 +0200") Message-ID: <7h378gh5p4.fsf@baylibre.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ulf Hansson writes: > On 22 August 2017 at 13:46, Jerome Brunet wrote: >> On Tue, 2017-08-22 at 13:15 +0200, Ulf Hansson wrote: >>> On 21 August 2017 at 18:02, Jerome Brunet wrote: >>> > The patchset features several bugfixes, rework and upgrade for the >>> > meson-gx MMC driver. >>> > >>> > The main goal is to improve readability and enable new high speed >>> > modes, such as eMMC DDR52 and sdcard UHS modes up to SDR50 (100Mhz) >>> > >>> > SDR104 is not working with a few cards on the p200 and the >>> > libretech-cc. I suspect that 200Mhz might be a bit too fast for the PCB >>> > of these boards, adding noise to the signal and eventually breaking >>> > the communication with some cards. The same cards are working well on a >>> > laptop or the nanopi-k2 at 200Mhz. >>> > >>> > This series has been tested on gxbb-p200, gxbb-nanopi-k2 and >>> > gxl-s905x-libretech-cc >>> > >>> > Changes since v1 [0]: >>> > * Reorder patches to have fixes first, then rework and finally >>> > enhancements. >>> > * Use CCF to manage clock phases >>> > >>> > [0]: https://lkml.kernel.org/r/20170804174353.16486-1-jbrunet@baylibre.com >>> > >>> > Jerome Brunet (16): >>> > mmc: meson-gx: fix mux mask definition >>> > mmc: meson-gx: remove CLK_DIVIDER_ALLOW_ZERO clock flag >>> > mmc: meson-gx: clean up some constants >>> > mmc: meson-gx: use _irqsave variant of spinlock >>> > mmc: meson-gx: cfg init overwrite values >>> > mmc: meson-gx: rework set_ios function >>> > mmc: meson-gx: rework clk_set function >>> > mmc: meson-gx: rework clock init function >>> > mmc: meson-gx: fix dual data rate mode frequencies >>> > mmc: meson-gx: work around clk-stop issue >>> > mmc: meson-gx: simplify interrupt handler >>> > mmc: meson-gx: implement card_busy callback >>> > mmc: meson-gx: use CCF to handle the clock phases >>> > mmc: meson-gx: implement voltage switch callback >>> > mmc: meson-gx: change default tx phase >>> > mmc: meson-gx: rework tuning function >>> > >>> > drivers/mmc/host/meson-gx-mmc.c | 718 +++++++++++++++++++++++++++-------- >>> > ----- >>> > 1 file changed, 497 insertions(+), 221 deletions(-) >>> > >>> > -- >>> > 2.9.5 >>> > >>> >>> So far, I decided to pick patch 1 -> 3. >> >> Thx Ulf. >> Do you want me to respin w/o patch 1 -> 4 or shall I wait for further review on >> the other changes ? > > I think you can wait a bit, hopefully some of the earlier authors and > Kevin can give some input as well. Most of them already had a Reviewed-by from me, but I just reviewed the new/updateds one now as well. Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH v2 00/16] mmc: meson-gx: driver fixups and upgrades Date: Thu, 24 Aug 2017 17:05:59 -0700 Message-ID: <7h378gh5p4.fsf@baylibre.com> References: <20170821160301.21899-1-jbrunet@baylibre.com> <1503402390.7032.11.camel@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from mail-pg0-f50.google.com ([74.125.83.50]:34706 "EHLO mail-pg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753492AbdHYAGB (ORCPT ); Thu, 24 Aug 2017 20:06:01 -0400 Received: by mail-pg0-f50.google.com with SMTP id a7so4953747pgn.1 for ; Thu, 24 Aug 2017 17:06:01 -0700 (PDT) In-Reply-To: (Ulf Hansson's message of "Wed, 23 Aug 2017 15:10:25 +0200") Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Ulf Hansson Cc: Jerome Brunet , Carlo Caione , "linux-mmc@vger.kernel.org" , "open list:ARM/Amlogic Meson..." , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Ulf Hansson writes: > On 22 August 2017 at 13:46, Jerome Brunet wrote: >> On Tue, 2017-08-22 at 13:15 +0200, Ulf Hansson wrote: >>> On 21 August 2017 at 18:02, Jerome Brunet wrote: >>> > The patchset features several bugfixes, rework and upgrade for the >>> > meson-gx MMC driver. >>> > >>> > The main goal is to improve readability and enable new high speed >>> > modes, such as eMMC DDR52 and sdcard UHS modes up to SDR50 (100Mhz) >>> > >>> > SDR104 is not working with a few cards on the p200 and the >>> > libretech-cc. I suspect that 200Mhz might be a bit too fast for the PCB >>> > of these boards, adding noise to the signal and eventually breaking >>> > the communication with some cards. The same cards are working well on a >>> > laptop or the nanopi-k2 at 200Mhz. >>> > >>> > This series has been tested on gxbb-p200, gxbb-nanopi-k2 and >>> > gxl-s905x-libretech-cc >>> > >>> > Changes since v1 [0]: >>> > * Reorder patches to have fixes first, then rework and finally >>> > enhancements. >>> > * Use CCF to manage clock phases >>> > >>> > [0]: https://lkml.kernel.org/r/20170804174353.16486-1-jbrunet@baylibre.com >>> > >>> > Jerome Brunet (16): >>> > mmc: meson-gx: fix mux mask definition >>> > mmc: meson-gx: remove CLK_DIVIDER_ALLOW_ZERO clock flag >>> > mmc: meson-gx: clean up some constants >>> > mmc: meson-gx: use _irqsave variant of spinlock >>> > mmc: meson-gx: cfg init overwrite values >>> > mmc: meson-gx: rework set_ios function >>> > mmc: meson-gx: rework clk_set function >>> > mmc: meson-gx: rework clock init function >>> > mmc: meson-gx: fix dual data rate mode frequencies >>> > mmc: meson-gx: work around clk-stop issue >>> > mmc: meson-gx: simplify interrupt handler >>> > mmc: meson-gx: implement card_busy callback >>> > mmc: meson-gx: use CCF to handle the clock phases >>> > mmc: meson-gx: implement voltage switch callback >>> > mmc: meson-gx: change default tx phase >>> > mmc: meson-gx: rework tuning function >>> > >>> > drivers/mmc/host/meson-gx-mmc.c | 718 +++++++++++++++++++++++++++-------- >>> > ----- >>> > 1 file changed, 497 insertions(+), 221 deletions(-) >>> > >>> > -- >>> > 2.9.5 >>> > >>> >>> So far, I decided to pick patch 1 -> 3. >> >> Thx Ulf. >> Do you want me to respin w/o patch 1 -> 4 or shall I wait for further review on >> the other changes ? > > I think you can wait a bit, hopefully some of the earlier authors and > Kevin can give some input as well. Most of them already had a Reviewed-by from me, but I just reviewed the new/updateds one now as well. Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@baylibre.com (Kevin Hilman) Date: Thu, 24 Aug 2017 17:05:59 -0700 Subject: [PATCH v2 00/16] mmc: meson-gx: driver fixups and upgrades In-Reply-To: (Ulf Hansson's message of "Wed, 23 Aug 2017 15:10:25 +0200") References: <20170821160301.21899-1-jbrunet@baylibre.com> <1503402390.7032.11.camel@baylibre.com> Message-ID: <7h378gh5p4.fsf@baylibre.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Ulf Hansson writes: > On 22 August 2017 at 13:46, Jerome Brunet wrote: >> On Tue, 2017-08-22 at 13:15 +0200, Ulf Hansson wrote: >>> On 21 August 2017 at 18:02, Jerome Brunet wrote: >>> > The patchset features several bugfixes, rework and upgrade for the >>> > meson-gx MMC driver. >>> > >>> > The main goal is to improve readability and enable new high speed >>> > modes, such as eMMC DDR52 and sdcard UHS modes up to SDR50 (100Mhz) >>> > >>> > SDR104 is not working with a few cards on the p200 and the >>> > libretech-cc. I suspect that 200Mhz might be a bit too fast for the PCB >>> > of these boards, adding noise to the signal and eventually breaking >>> > the communication with some cards. The same cards are working well on a >>> > laptop or the nanopi-k2 at 200Mhz. >>> > >>> > This series has been tested on gxbb-p200, gxbb-nanopi-k2 and >>> > gxl-s905x-libretech-cc >>> > >>> > Changes since v1 [0]: >>> > * Reorder patches to have fixes first, then rework and finally >>> > enhancements. >>> > * Use CCF to manage clock phases >>> > >>> > [0]: https://lkml.kernel.org/r/20170804174353.16486-1-jbrunet at baylibre.com >>> > >>> > Jerome Brunet (16): >>> > mmc: meson-gx: fix mux mask definition >>> > mmc: meson-gx: remove CLK_DIVIDER_ALLOW_ZERO clock flag >>> > mmc: meson-gx: clean up some constants >>> > mmc: meson-gx: use _irqsave variant of spinlock >>> > mmc: meson-gx: cfg init overwrite values >>> > mmc: meson-gx: rework set_ios function >>> > mmc: meson-gx: rework clk_set function >>> > mmc: meson-gx: rework clock init function >>> > mmc: meson-gx: fix dual data rate mode frequencies >>> > mmc: meson-gx: work around clk-stop issue >>> > mmc: meson-gx: simplify interrupt handler >>> > mmc: meson-gx: implement card_busy callback >>> > mmc: meson-gx: use CCF to handle the clock phases >>> > mmc: meson-gx: implement voltage switch callback >>> > mmc: meson-gx: change default tx phase >>> > mmc: meson-gx: rework tuning function >>> > >>> > drivers/mmc/host/meson-gx-mmc.c | 718 +++++++++++++++++++++++++++-------- >>> > ----- >>> > 1 file changed, 497 insertions(+), 221 deletions(-) >>> > >>> > -- >>> > 2.9.5 >>> > >>> >>> So far, I decided to pick patch 1 -> 3. >> >> Thx Ulf. >> Do you want me to respin w/o patch 1 -> 4 or shall I wait for further review on >> the other changes ? > > I think you can wait a bit, hopefully some of the earlier authors and > Kevin can give some input as well. Most of them already had a Reviewed-by from me, but I just reviewed the new/updateds one now as well. Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@baylibre.com (Kevin Hilman) Date: Thu, 24 Aug 2017 17:05:59 -0700 Subject: [PATCH v2 00/16] mmc: meson-gx: driver fixups and upgrades In-Reply-To: (Ulf Hansson's message of "Wed, 23 Aug 2017 15:10:25 +0200") References: <20170821160301.21899-1-jbrunet@baylibre.com> <1503402390.7032.11.camel@baylibre.com> Message-ID: <7h378gh5p4.fsf@baylibre.com> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org Ulf Hansson writes: > On 22 August 2017 at 13:46, Jerome Brunet wrote: >> On Tue, 2017-08-22 at 13:15 +0200, Ulf Hansson wrote: >>> On 21 August 2017 at 18:02, Jerome Brunet wrote: >>> > The patchset features several bugfixes, rework and upgrade for the >>> > meson-gx MMC driver. >>> > >>> > The main goal is to improve readability and enable new high speed >>> > modes, such as eMMC DDR52 and sdcard UHS modes up to SDR50 (100Mhz) >>> > >>> > SDR104 is not working with a few cards on the p200 and the >>> > libretech-cc. I suspect that 200Mhz might be a bit too fast for the PCB >>> > of these boards, adding noise to the signal and eventually breaking >>> > the communication with some cards. The same cards are working well on a >>> > laptop or the nanopi-k2 at 200Mhz. >>> > >>> > This series has been tested on gxbb-p200, gxbb-nanopi-k2 and >>> > gxl-s905x-libretech-cc >>> > >>> > Changes since v1 [0]: >>> > * Reorder patches to have fixes first, then rework and finally >>> > enhancements. >>> > * Use CCF to manage clock phases >>> > >>> > [0]: https://lkml.kernel.org/r/20170804174353.16486-1-jbrunet at baylibre.com >>> > >>> > Jerome Brunet (16): >>> > mmc: meson-gx: fix mux mask definition >>> > mmc: meson-gx: remove CLK_DIVIDER_ALLOW_ZERO clock flag >>> > mmc: meson-gx: clean up some constants >>> > mmc: meson-gx: use _irqsave variant of spinlock >>> > mmc: meson-gx: cfg init overwrite values >>> > mmc: meson-gx: rework set_ios function >>> > mmc: meson-gx: rework clk_set function >>> > mmc: meson-gx: rework clock init function >>> > mmc: meson-gx: fix dual data rate mode frequencies >>> > mmc: meson-gx: work around clk-stop issue >>> > mmc: meson-gx: simplify interrupt handler >>> > mmc: meson-gx: implement card_busy callback >>> > mmc: meson-gx: use CCF to handle the clock phases >>> > mmc: meson-gx: implement voltage switch callback >>> > mmc: meson-gx: change default tx phase >>> > mmc: meson-gx: rework tuning function >>> > >>> > drivers/mmc/host/meson-gx-mmc.c | 718 +++++++++++++++++++++++++++-------- >>> > ----- >>> > 1 file changed, 497 insertions(+), 221 deletions(-) >>> > >>> > -- >>> > 2.9.5 >>> > >>> >>> So far, I decided to pick patch 1 -> 3. >> >> Thx Ulf. >> Do you want me to respin w/o patch 1 -> 4 or shall I wait for further review on >> the other changes ? > > I think you can wait a bit, hopefully some of the earlier authors and > Kevin can give some input as well. Most of them already had a Reviewed-by from me, but I just reviewed the new/updateds one now as well. Kevin