From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54244C433F5 for ; Fri, 4 Mar 2022 17:41:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239237AbiCDRmB (ORCPT ); Fri, 4 Mar 2022 12:42:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238000AbiCDRl7 (ORCPT ); Fri, 4 Mar 2022 12:41:59 -0500 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F13F1637DF for ; Fri, 4 Mar 2022 09:41:09 -0800 (PST) Received: by mail-pg1-x530.google.com with SMTP id c1so8091664pgk.11 for ; Fri, 04 Mar 2022 09:41:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=PVlhcCn7DaGojmQuPVn01R8bc+sVgt8z7aPBiwXDtKA=; b=28LE/bh1PCver1vlxXW2uY48K0BNBXlo7W2CUgCSAgdVq+qPP30mJwwvBhfA/6L7Cu hMmXie39seY56jl9FnYvsxLKRmtsTVhsSjNcFupD3HGgAj9Y2zD5hHz7NaejIKh6/vm4 QIU7z8n+FwTUFGeebviFwZXaGZ6LKQg4Tv9CCseXKCXsJhVBZ3rySuMU/0vA7gldpRsw Y9XGiIJ63OZWPitaMmqUYd7OSMbs5kGXEvieIpcz6gTRFGAXINhpuArFhnxPaLB6/hJG wMiG8AlpP6ECn1vKfBXEpiosjNrKRFEVeojePtYHGAJ2SUacybFgAOIpuZ93ct9IqOIH onYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=PVlhcCn7DaGojmQuPVn01R8bc+sVgt8z7aPBiwXDtKA=; b=BLpFnOVxsg5liAyNaH1pIl2RytTCJ8biTI0Wcp5v8E2WPGRD0NQBTyYjxtwg1hwUMz yWGBy/LXjL+l1S5SN5qVOcZHBsd2Aq06azdCyaiVYO/QxAEqbo92XCL4zNljxqLcdH6K nZVJ2F1DpwKhM5+2uFz3LQoFhgZNKyws+CL6Ykvy1CjqBcy0PdNOxE7j4RecXEFNvfEG jqbr56oOz8cp/wv1oXFvrerYx+6vqSAsuKnVJji9SokqsqXD5m/pFpXn3dzOgCQWpceZ ojLlzvMxD8mtSLdByUc2PnuNzcD5U0uIJKAhycuf8/SexwMa7DbtAof7z2lZDKUrrHYQ MFuQ== X-Gm-Message-State: AOAM533NG0qaY0tXprdw/cowa+O7nJVytpo+K2kXzRpK8NMX3wdcmhbc kDrcpcjPcOOF0ZdGL5y4LlNy9g== X-Google-Smtp-Source: ABdhPJx8/jcrgsC8eOxqGC4hQISCKORpNObve0/4qNvQ59vUxhPXKYZnwgfx+fCtkkqtGPkIn/S1Dw== X-Received: by 2002:a63:544c:0:b0:378:907d:1e37 with SMTP id e12-20020a63544c000000b00378907d1e37mr22764324pgm.394.1646415668764; Fri, 04 Mar 2022 09:41:08 -0800 (PST) Received: from localhost (c-71-197-186-152.hsd1.wa.comcast.net. [71.197.186.152]) by smtp.gmail.com with ESMTPSA id y12-20020a056a00190c00b004f39e28fb87sm6880950pfi.98.2022.03.04.09.41.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Mar 2022 09:41:08 -0800 (PST) From: Kevin Hilman To: Tony Lindgren , linux-omap@vger.kernel.org Cc: Dave Gerlach , Faiz Abbas , Greg Kroah-Hartman , Grygorii Strashko , Keerthy , Nishanth Menon , Suman Anna , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jarkko Nikula Subject: Re: [PATCH] bus: ti-sysc: Fix gpt12 system timer issue with reserved status In-Reply-To: <20210611060224.36769-1-tony@atomide.com> References: <20210611060224.36769-1-tony@atomide.com> Date: Fri, 04 Mar 2022 09:41:07 -0800 Message-ID: <7h7d99ehu4.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tony, Tony Lindgren writes: > Jarkko Nikula reported that Beagleboard > revision c2 stopped booting. Jarkko bisected the issue down to > commit 6cfcd5563b4f ("clocksource/drivers/timer-ti-dm: Fix suspend > and resume for am3 and am4"). > > Let's fix the issue by tagging system timers as reserved rather than > ignoring them. And let's not probe any interconnect target module child > devices for reserved modules. > > This allows PM runtime to keep track of clocks and clockdomains for > the interconnect target module, and prevent the system timer from idling > as we already have SYSC_QUIRK_NO_IDLE and SYSC_QUIRK_NO_IDLE_ON_INIT > flags set for system timers. > > Fixes: 6cfcd5563b4f ("clocksource/drivers/timer-ti-dm: Fix suspend and resume for am3 and am4") > Reported-by: Jarkko Nikula > Signed-off-by: Tony Lindgren I'm debugging why suspend/resume on AM3x and AM4x are mostly working, but getting the warning that not all powerdomains are transitioning: pm33xx pm33xx: PM: Could not transition all powerdomains to target state I bisected it down to $SUBJECT patch, and verified that reverting it makes both on am335x-boneblack and am437x-gp-evm fully suspend, and I'm now seeing: pm33xx pm33xx: PM: Successfully put all powerdomains to target state Note that it doesn't revert cleanly due to some other changes, but this one-liner[1] effectively reverts the behavior of $SUBJECT patch, and also makes things work again. I verified the revert (and hack[1]) on both v5.10 stable and mainline v5.16 but TBH, I'm still not 100% sure what's going on so looking for some guidance from you Tony on what the "real" fix should be. Kevin [1] diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c index 54c0ee6dda30..82379ff9dce5 100644 --- a/drivers/bus/ti-sysc.c +++ b/drivers/bus/ti-sysc.c @@ -3304,7 +3304,7 @@ static int sysc_probe(struct platform_device *pdev) error = sysc_check_active_timer(ddata); if (error == -ENXIO) - ddata->reserved = true; + return error; else if (error) return error; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D98C1C433F5 for ; Fri, 4 Mar 2022 17:42:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cqFmaktUuFd0sJLa/VSZSpeSr3uXmCCCPUQjnOjza/o=; b=EDz6T5b+ZqrJnW eAX2DezdFIho6K7Ne/KT2OIKKhtVXW8IcM95h4TDbpUW9TlJX1mbWYwgEPZgOtXF8Qyr3ubzj1g9h 3KIqqkjOz+u+ZOi9vHb+k+YYmz/xZgggGL6YD4t11kVIaKJTzYjfGV0O7PwRtzlsLaeU68p1hRPyb 0rVX2vByrH+BeA2OWvSe5058O6DS95fGshXh2KvImrFlaHL84fHWWm639MYH8Eaqh8+d/Z8l/JEW/ nqH9uwiWhrpnkVpuFD8zKml6KqJMV3u1upcp40wrK3Sx+zIPeQONl/xNIWIn/lXuPrMHG6CLGlq76 fTvujHd/xIdx+Q/gJWvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nQBvX-00BPw4-4o; Fri, 04 Mar 2022 17:41:15 +0000 Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nQBvS-00BPv5-B6 for linux-arm-kernel@lists.infradead.org; Fri, 04 Mar 2022 17:41:13 +0000 Received: by mail-pg1-x530.google.com with SMTP id t187so3831005pgb.1 for ; Fri, 04 Mar 2022 09:41:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=PVlhcCn7DaGojmQuPVn01R8bc+sVgt8z7aPBiwXDtKA=; b=28LE/bh1PCver1vlxXW2uY48K0BNBXlo7W2CUgCSAgdVq+qPP30mJwwvBhfA/6L7Cu hMmXie39seY56jl9FnYvsxLKRmtsTVhsSjNcFupD3HGgAj9Y2zD5hHz7NaejIKh6/vm4 QIU7z8n+FwTUFGeebviFwZXaGZ6LKQg4Tv9CCseXKCXsJhVBZ3rySuMU/0vA7gldpRsw Y9XGiIJ63OZWPitaMmqUYd7OSMbs5kGXEvieIpcz6gTRFGAXINhpuArFhnxPaLB6/hJG wMiG8AlpP6ECn1vKfBXEpiosjNrKRFEVeojePtYHGAJ2SUacybFgAOIpuZ93ct9IqOIH onYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=PVlhcCn7DaGojmQuPVn01R8bc+sVgt8z7aPBiwXDtKA=; b=UXHZESEcCX9iHbJGPe3w8joRYsG7WrrvDPPpfHbTj5vNER3ylR3SfduIDWYnUicF5r UnZbLXcxLbcovzM9WtudodMYK9xFtq0zDZrV2OYx2EnoO9x0pfg0P5fgeSzy6W5hU2lr QYd+4Vwjen+CoqWSg/eauIzPjyuFTnvLF+HDIisuVQiRgWJY5vADlikDWj5ord2iuKy4 nAtgWd8PXpqYr8XNeXwqXch8lT/z390Zb1sNDjvAaCrY3MqA9BKWK0ufpZDJt2BdGP5H 2fUex0s6o7DciJoAxlotONUdUASzJGFGzAQbg9x0WR2BAUu2OhD1dfhCBy7/lbkv8cqV j+kA== X-Gm-Message-State: AOAM532TeqJAThpjnXnu9L5cpfn5SuHqItqvxVQPEaayfyIrfhhBeWY+ 6VrGWzCW6hrg5sMCRfFO7VSNtg== X-Google-Smtp-Source: ABdhPJx8/jcrgsC8eOxqGC4hQISCKORpNObve0/4qNvQ59vUxhPXKYZnwgfx+fCtkkqtGPkIn/S1Dw== X-Received: by 2002:a63:544c:0:b0:378:907d:1e37 with SMTP id e12-20020a63544c000000b00378907d1e37mr22764324pgm.394.1646415668764; Fri, 04 Mar 2022 09:41:08 -0800 (PST) Received: from localhost (c-71-197-186-152.hsd1.wa.comcast.net. [71.197.186.152]) by smtp.gmail.com with ESMTPSA id y12-20020a056a00190c00b004f39e28fb87sm6880950pfi.98.2022.03.04.09.41.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Mar 2022 09:41:08 -0800 (PST) From: Kevin Hilman To: Tony Lindgren , linux-omap@vger.kernel.org Subject: Re: [PATCH] bus: ti-sysc: Fix gpt12 system timer issue with reserved status In-Reply-To: <20210611060224.36769-1-tony@atomide.com> References: <20210611060224.36769-1-tony@atomide.com> Date: Fri, 04 Mar 2022 09:41:07 -0800 Message-ID: <7h7d99ehu4.fsf@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220304_094110_454679_220F531F X-CRM114-Status: GOOD ( 16.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Grygorii Strashko , Dave Gerlach , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Faiz Abbas , Jarkko Nikula , Keerthy , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Tony, Tony Lindgren writes: > Jarkko Nikula reported that Beagleboard > revision c2 stopped booting. Jarkko bisected the issue down to > commit 6cfcd5563b4f ("clocksource/drivers/timer-ti-dm: Fix suspend > and resume for am3 and am4"). > > Let's fix the issue by tagging system timers as reserved rather than > ignoring them. And let's not probe any interconnect target module child > devices for reserved modules. > > This allows PM runtime to keep track of clocks and clockdomains for > the interconnect target module, and prevent the system timer from idling > as we already have SYSC_QUIRK_NO_IDLE and SYSC_QUIRK_NO_IDLE_ON_INIT > flags set for system timers. > > Fixes: 6cfcd5563b4f ("clocksource/drivers/timer-ti-dm: Fix suspend and resume for am3 and am4") > Reported-by: Jarkko Nikula > Signed-off-by: Tony Lindgren I'm debugging why suspend/resume on AM3x and AM4x are mostly working, but getting the warning that not all powerdomains are transitioning: pm33xx pm33xx: PM: Could not transition all powerdomains to target state I bisected it down to $SUBJECT patch, and verified that reverting it makes both on am335x-boneblack and am437x-gp-evm fully suspend, and I'm now seeing: pm33xx pm33xx: PM: Successfully put all powerdomains to target state Note that it doesn't revert cleanly due to some other changes, but this one-liner[1] effectively reverts the behavior of $SUBJECT patch, and also makes things work again. I verified the revert (and hack[1]) on both v5.10 stable and mainline v5.16 but TBH, I'm still not 100% sure what's going on so looking for some guidance from you Tony on what the "real" fix should be. Kevin [1] diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c index 54c0ee6dda30..82379ff9dce5 100644 --- a/drivers/bus/ti-sysc.c +++ b/drivers/bus/ti-sysc.c @@ -3304,7 +3304,7 @@ static int sysc_probe(struct platform_device *pdev) error = sysc_check_active_timer(ddata); if (error == -ENXIO) - ddata->reserved = true; + return error; else if (error) return error; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel