From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754150AbdHYAEg (ORCPT ); Thu, 24 Aug 2017 20:04:36 -0400 Received: from mail-pg0-f47.google.com ([74.125.83.47]:38596 "EHLO mail-pg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753924AbdHYAEe (ORCPT ); Thu, 24 Aug 2017 20:04:34 -0400 From: Kevin Hilman To: Jerome Brunet Cc: Ulf Hansson , Carlo Caione , linux-mmc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 13/16] mmc: meson-gx: use CCF to handle the clock phases Organization: BayLibre References: <20170821160301.21899-1-jbrunet@baylibre.com> <20170821160301.21899-14-jbrunet@baylibre.com> Date: Thu, 24 Aug 2017 17:04:26 -0700 In-Reply-To: <20170821160301.21899-14-jbrunet@baylibre.com> (Jerome Brunet's message of "Mon, 21 Aug 2017 18:02:58 +0200") Message-ID: <7hd17kh5rp.fsf@baylibre.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jerome Brunet writes: > Several phases can be controlled on the meson-gx controller, the core, tx > and rx clock phase. The tx and rx uses delays to allow for a more fine > grained setting of the phase. To properly compute the phase using delays, > accessing the clock rate is necessary. > > Instead of ad-hoc functions, use the common clock framework to set the > clock phases (and access the clock rate while doing it). > > Signed-off-by: Jerome Brunet I have to admit to not fully understanding the MMC tuning aspsects here, but I like this approach to using the clock framework for handling the extra clocks. Acked-by: Kevin Hilman From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@baylibre.com (Kevin Hilman) Date: Thu, 24 Aug 2017 17:04:26 -0700 Subject: [PATCH v2 13/16] mmc: meson-gx: use CCF to handle the clock phases In-Reply-To: <20170821160301.21899-14-jbrunet@baylibre.com> (Jerome Brunet's message of "Mon, 21 Aug 2017 18:02:58 +0200") References: <20170821160301.21899-1-jbrunet@baylibre.com> <20170821160301.21899-14-jbrunet@baylibre.com> Message-ID: <7hd17kh5rp.fsf@baylibre.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Jerome Brunet writes: > Several phases can be controlled on the meson-gx controller, the core, tx > and rx clock phase. The tx and rx uses delays to allow for a more fine > grained setting of the phase. To properly compute the phase using delays, > accessing the clock rate is necessary. > > Instead of ad-hoc functions, use the common clock framework to set the > clock phases (and access the clock rate while doing it). > > Signed-off-by: Jerome Brunet I have to admit to not fully understanding the MMC tuning aspsects here, but I like this approach to using the clock framework for handling the extra clocks. Acked-by: Kevin Hilman From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@baylibre.com (Kevin Hilman) Date: Thu, 24 Aug 2017 17:04:26 -0700 Subject: [PATCH v2 13/16] mmc: meson-gx: use CCF to handle the clock phases In-Reply-To: <20170821160301.21899-14-jbrunet@baylibre.com> (Jerome Brunet's message of "Mon, 21 Aug 2017 18:02:58 +0200") References: <20170821160301.21899-1-jbrunet@baylibre.com> <20170821160301.21899-14-jbrunet@baylibre.com> Message-ID: <7hd17kh5rp.fsf@baylibre.com> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org Jerome Brunet writes: > Several phases can be controlled on the meson-gx controller, the core, tx > and rx clock phase. The tx and rx uses delays to allow for a more fine > grained setting of the phase. To properly compute the phase using delays, > accessing the clock rate is necessary. > > Instead of ad-hoc functions, use the common clock framework to set the > clock phases (and access the clock rate while doing it). > > Signed-off-by: Jerome Brunet I have to admit to not fully understanding the MMC tuning aspsects here, but I like this approach to using the clock framework for handling the extra clocks. Acked-by: Kevin Hilman