All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@linaro.org>
To: Lina Iyer <lina.iyer@linaro.org>
Cc: tglx@linutronix.de, linux-pm@vger.kernel.org,
	daniel.lezcano@linaro.org, ulf.hansson@linaro.org,
	Praveen Chidambaram <pchidamb@codeaurora.org>
Subject: Re: [PATCH 1/2] arm: irq: Notify affinity change when migrating IRQs during hotplug
Date: Wed, 27 Aug 2014 10:09:10 -0700	[thread overview]
Message-ID: <7hegw1g8qx.fsf@paris.lan> (raw)
In-Reply-To: <1408553988-63924-1-git-send-email-lina.iyer@linaro.org> (Lina Iyer's message of "Wed, 20 Aug 2014 10:59:47 -0600")

Lina Iyer <lina.iyer@linaro.org> writes:

> From: Praveen Chidambaram <pchidamb@codeaurora.org>
>
> Hotplug causes IRQs affine to a core that is being taken down to migrate
> to an online core. This is done by directly calling the irq_set_affinity
> associated with the irq_chip structure. Instead using the
> irq_set_affinity_locked() api lets the notifications bubble through.

changelog nit: and why do you want/need the notification to bubble
through?   IOW, you're explaining "what" the patch does, but not "why",
which typically includes a summary of the problem being solved.  (I know
the background from the other series, but other reviewers may not know
the history there.)

Also, please post these to linux-arm-kernel.

Thanks,

Kevin

  parent reply	other threads:[~2014-08-27 17:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-20 16:59 [PATCH 1/2] arm: irq: Notify affinity change when migrating IRQs during hotplug Lina Iyer
2014-08-20 16:59 ` [PATCH 2/2] arm64: " Lina Iyer
2014-08-27 17:09 ` Kevin Hilman [this message]
2014-08-27 22:51   ` [PATCH 1/2] arm: " Lina Iyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7hegw1g8qx.fsf@paris.lan \
    --to=khilman@linaro.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=lina.iyer@linaro.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pchidamb@codeaurora.org \
    --cc=tglx@linutronix.de \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.