From: Kevin Hilman <khilman@baylibre.com>
To: Loys Ollivier <lollivier@baylibre.com>,
devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org
Cc: Loys Ollivier <lollivier@baylibre.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Subject: Re: [PATCH v3] arm64: dts: meson: Fix mmc cd-gpios polarity
Date: Thu, 10 Jan 2019 17:28:11 -0800 [thread overview]
Message-ID: <7hftu0oudw.fsf@baylibre.com> (raw)
In-Reply-To: <1547134822-18498-1-git-send-email-lollivier@baylibre.com>
Loys Ollivier <lollivier@baylibre.com> writes:
> Commit 89a5e15bcba8 ("gpio/mmc/of: Respect polarity in the device tree")
> changed the behavior of "cd-inverted" to follow the device tree bindings
> specification.
> Lines specifying "cd-inverted" are now "active high".
>
> Fix the SD card for meson by setting the cd-gpios as "active low" according
> to the boards specifications.
>
> Fixes: 89a5e15bcba8 ("gpio/mmc/of: Respect polarity in the device tree")
> Signed-off-by: Loys Ollivier <lollivier@baylibre.com>
Thanks for fixing this!
Queued as a fix for v5.1-rc,
I see that this is being fixed in the driver also, but I think fixing
the DTs is necessary also.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org
Cc: Loys Ollivier <lollivier@baylibre.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Subject: Re: [PATCH v3] arm64: dts: meson: Fix mmc cd-gpios polarity
Date: Thu, 10 Jan 2019 17:28:11 -0800 [thread overview]
Message-ID: <7hftu0oudw.fsf@baylibre.com> (raw)
In-Reply-To: <1547134822-18498-1-git-send-email-lollivier@baylibre.com>
Loys Ollivier <lollivier@baylibre.com> writes:
> Commit 89a5e15bcba8 ("gpio/mmc/of: Respect polarity in the device tree")
> changed the behavior of "cd-inverted" to follow the device tree bindings
> specification.
> Lines specifying "cd-inverted" are now "active high".
>
> Fix the SD card for meson by setting the cd-gpios as "active low" according
> to the boards specifications.
>
> Fixes: 89a5e15bcba8 ("gpio/mmc/of: Respect polarity in the device tree")
> Signed-off-by: Loys Ollivier <lollivier@baylibre.com>
Thanks for fixing this!
Queued as a fix for v5.1-rc,
I see that this is being fixed in the driver also, but I think fixing
the DTs is necessary also.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Loys Ollivier <lollivier@baylibre.com>,
devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Loys Ollivier <lollivier@baylibre.com>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH v3] arm64: dts: meson: Fix mmc cd-gpios polarity
Date: Thu, 10 Jan 2019 17:28:11 -0800 [thread overview]
Message-ID: <7hftu0oudw.fsf@baylibre.com> (raw)
In-Reply-To: <1547134822-18498-1-git-send-email-lollivier@baylibre.com>
Loys Ollivier <lollivier@baylibre.com> writes:
> Commit 89a5e15bcba8 ("gpio/mmc/of: Respect polarity in the device tree")
> changed the behavior of "cd-inverted" to follow the device tree bindings
> specification.
> Lines specifying "cd-inverted" are now "active high".
>
> Fix the SD card for meson by setting the cd-gpios as "active low" according
> to the boards specifications.
>
> Fixes: 89a5e15bcba8 ("gpio/mmc/of: Respect polarity in the device tree")
> Signed-off-by: Loys Ollivier <lollivier@baylibre.com>
Thanks for fixing this!
Queued as a fix for v5.1-rc,
I see that this is being fixed in the driver also, but I think fixing
the DTs is necessary also.
Kevin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Loys Ollivier <lollivier@baylibre.com>,
devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Loys Ollivier <lollivier@baylibre.com>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH v3] arm64: dts: meson: Fix mmc cd-gpios polarity
Date: Thu, 10 Jan 2019 17:28:11 -0800 [thread overview]
Message-ID: <7hftu0oudw.fsf@baylibre.com> (raw)
In-Reply-To: <1547134822-18498-1-git-send-email-lollivier@baylibre.com>
Loys Ollivier <lollivier@baylibre.com> writes:
> Commit 89a5e15bcba8 ("gpio/mmc/of: Respect polarity in the device tree")
> changed the behavior of "cd-inverted" to follow the device tree bindings
> specification.
> Lines specifying "cd-inverted" are now "active high".
>
> Fix the SD card for meson by setting the cd-gpios as "active low" according
> to the boards specifications.
>
> Fixes: 89a5e15bcba8 ("gpio/mmc/of: Respect polarity in the device tree")
> Signed-off-by: Loys Ollivier <lollivier@baylibre.com>
Thanks for fixing this!
Queued as a fix for v5.1-rc,
I see that this is being fixed in the driver also, but I think fixing
the DTs is necessary also.
Kevin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-01-11 1:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 15:40 [PATCH v3] arm64: dts: meson: Fix mmc cd-gpios polarity Loys Ollivier
2019-01-10 15:40 ` Loys Ollivier
2019-01-10 15:40 ` Loys Ollivier
2019-01-11 1:28 ` Kevin Hilman [this message]
2019-01-11 1:28 ` Kevin Hilman
2019-01-11 1:28 ` Kevin Hilman
2019-01-11 1:28 ` Kevin Hilman
2019-01-11 19:46 ` Martin Blumenstingl
2019-01-11 19:46 ` Martin Blumenstingl
2019-01-11 19:46 ` Martin Blumenstingl
2019-01-11 19:55 ` Kevin Hilman
2019-01-11 19:55 ` Kevin Hilman
2019-01-11 19:55 ` Kevin Hilman
2019-01-14 13:30 ` Loys Ollivier
2019-01-14 13:30 ` Loys Ollivier
2019-01-14 13:30 ` Loys Ollivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hftu0oudw.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=lollivier@baylibre.com \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.