From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3175C433DF for ; Thu, 23 Jul 2020 08:27:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF5DE22B43 for ; Thu, 23 Jul 2020 08:27:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PXBSLqSP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF5DE22B43 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:32790 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jyWa6-0004Ir-T1 for qemu-devel@archiver.kernel.org; Thu, 23 Jul 2020 04:27:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55700) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jyWZR-0003sI-RZ for qemu-devel@nongnu.org; Thu, 23 Jul 2020 04:27:17 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:56148 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jyWZP-0000dU-BT for qemu-devel@nongnu.org; Thu, 23 Jul 2020 04:27:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595492833; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fU8rzEGnhAGu/hw3ofPmJ6QIdGtcpxDIn0tSVgQe89E=; b=PXBSLqSP4NOrf9UOUR/tJS0OkldABlNFF3wG8sjUTZPHzwyOzjqh+AehvpegkpKZML/Sbi fptx9jaLUDrubHwyUEBB6dnNfUSh/S70QyLXJIB2qvgXbl44qPMgEWU/KzaS9Z77Vtp9VW cs89hVMyB2dxwMQxw6REY1D4FnrKORQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-149-133RoOuRN4-LMVmU3CU86A-1; Thu, 23 Jul 2020 04:27:11 -0400 X-MC-Unique: 133RoOuRN4-LMVmU3CU86A-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3B408106B244 for ; Thu, 23 Jul 2020 08:27:10 +0000 (UTC) Received: from turbo.dinechin.lan (ovpn-113-141.ams2.redhat.com [10.36.113.141]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 94D1871D13; Thu, 23 Jul 2020 08:27:02 +0000 (UTC) References: <20200722084935.9601-1-kraxel@redhat.com> <20200722111822.skfkwlmr5ikhkaqh@sirius.home.kraxel.org> User-agent: mu4e 1.5.5; emacs 26.3 From: Christophe de Dinechin To: Gerd Hoffmann Subject: Re: [PATCH] spice: simplify chardev setup In-reply-to: <20200722111822.skfkwlmr5ikhkaqh@sirius.home.kraxel.org> Date: Thu, 23 Jul 2020 10:26:59 +0200 Message-ID: <7hh7ty4ox8.fsf@turbo.dinechin.lan> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=207.211.31.120; envelope-from=dinechin@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/22 22:13:02 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , qemu-devel@nongnu.org, =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2020-07-22 at 13:18 CEST, Gerd Hoffmann wrote... > On Wed, Jul 22, 2020 at 12:19:43PM +0200, Christophe de Dinechin wrote: >> >> On 2020-07-22 at 11:20 CEST, Christophe de Dinechin wrote... >> > On 2020-07-22 at 10:49 CEST, Gerd Hoffmann wrote... >> >> Initialize spice before chardevs. That allows to register the spice >> >> chardevs directly in the init function and removes the need to maintain >> >> a linked list of chardevs just for registration. >> >> >> >> Signed-off-by: Gerd Hoffmann >> > >> > Looks good to me, but I still need to test how this integrates with my work >> > on putting SPICE in a module. >> >> That part does not seem to work so well. It looks like with this move, the >> init happens before the module is loaded: >> >> qemu-system-x86_64 -display spice-app >> Unexpected error in qemu_chr_open_spice_port() at ui/../chardev/spice.c:307: >> qemu-system-x86_64: spice not enabled >> >> I'll try to find the correct fix. Any idea how to address this? > > move chardev init from early to normal: Works for me. Reviewed-by: Christophe de Dinechin Tested-by: Christophe de Dinechin > > commit 77297a71e6be60997caf2c55c09ce01a8c492bc2 > Author: Gerd Hoffmann > Date: Wed Jul 22 13:17:28 2020 +0200 > > [fixup] spice app > > diff --git a/ui/spice-app.c b/ui/spice-app.c > index 40fb2ef57399..03d971b15f0c 100644 > --- a/ui/spice-app.c > +++ b/ui/spice-app.c > @@ -117,7 +117,6 @@ static void spice_app_atexit(void) > static void spice_app_display_early_init(DisplayOptions *opts) > { > QemuOpts *qopts; > - ChardevBackend *be = chr_spice_backend_new(); > GError *err = NULL; > > if (opts->has_full_screen) { > @@ -162,6 +161,15 @@ static void spice_app_display_early_init(DisplayOptions *opts) > qemu_opt_set(qopts, "gl", opts->has_gl ? "on" : "off", &error_abort); > display_opengl = opts->has_gl; > #endif > +} > + > +static void spice_app_display_init(DisplayState *ds, DisplayOptions *opts) > +{ > + ChardevBackend *be = chr_spice_backend_new(); > + QemuOpts *qopts; > + GError *err = NULL; > + gchar *uri; > + > be->u.spiceport.data->fqdn = g_strdup("org.qemu.monitor.qmp.0"); > qemu_chardev_new("org.qemu.monitor.qmp", TYPE_CHARDEV_SPICEPORT, > be, NULL, &error_abort); > @@ -171,13 +179,6 @@ static void spice_app_display_early_init(DisplayOptions *opts) > qemu_opt_set(qopts, "mode", "control", &error_abort); > > qapi_free_ChardevBackend(be); > -} > - > -static void spice_app_display_init(DisplayState *ds, DisplayOptions *opts) > -{ > - GError *err = NULL; > - gchar *uri; > - > uri = g_strjoin("", "spice+unix://", app_dir, "/", "spice.sock", NULL); > info_report("Launching display with URI: %s", uri); > g_app_info_launch_default_for_uri(uri, NULL, &err); -- Cheers, Christophe de Dinechin (IRC c3d)