From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756789AbbJ2JMx (ORCPT ); Thu, 29 Oct 2015 05:12:53 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:33352 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752280AbbJ2JMs (ORCPT ); Thu, 29 Oct 2015 05:12:48 -0400 From: Kevin Hilman To: Eddie Huang Cc: Yingjoe Chen , "devicetree\@vger.kernel.org" , Russell King - ARM Linux , , Arnd Bergmann , Tyler Baker , Stephen Boyd , lkml , Olof Johansson , Rob Herring , , Sascha Hauer , Matthias Brugger , "linux-arm-kernel\@lists.infradead.org" Subject: Re: [PATCH v5 4/5] ARM: dts: mt8135: enable basic SMP bringup for mt8135 References: <1443799181-50409-1-git-send-email-yingjoe.chen@mediatek.com> <1443799181-50409-5-git-send-email-yingjoe.chen@mediatek.com> <1445843717.23888.1.camel@mtksdaap41> <1445859610.26723.4.camel@mtksdaap41> Date: Thu, 29 Oct 2015 02:12:45 -0700 In-Reply-To: <1445859610.26723.4.camel@mtksdaap41> (Eddie Huang's message of "Mon, 26 Oct 2015 19:40:10 +0800") Message-ID: <7hlhamjawi.fsf@deeprootsystems.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eddie Huang writes: > Hi Kevin, > > On Mon, 2015-10-26 at 17:06 +0900, Kevin Hilman wrote: >> On Mon, Oct 26, 2015 at 4:15 PM, Yingjoe Chen wrote: >> > On Mon, 2015-10-26 at 09:56 +0900, Kevin Hilman wrote: >> >> Hello, >> >> >> >> On Sat, Oct 3, 2015 at 12:19 AM, Yingjoe Chen wrote: >> >> > Add arch timer node to enable arch-timer support. MT8135 firmware >> >> > doesn't correctly setup arch-timer frequency and CNTVOFF, add >> >> > properties to workaround this. >> >> > >> >> > This also set cpu enable-method to enable SMP. >> >> > >> >> > Signed-off-by: Yingjoe Chen >> >> >> >> kernelci.org started detecting new boot failures for the mt8135-evb in >> >> the arm-soc tree[1], and the boot failures were bisected down to this >> >> patch, which landed upstream in the form of commit d186a394bb98 (ARM: >> >> dts: mt8135: enable basic SMP bringup for mt8135) >> >> >> >> Maybe this new SMP support requires updating the firmware on the board >> >> as well? If so, the changelog should've been a bit more explicit >> >> about firmware dependencies. >> > >> > Kevin, >> > >> > Thanks for testing. >> > >> > No, it doesn't need new firmware. Will test to see what's going wrong. >> >> Thanks for following up. I'll be glad to test any patches if you have >> anything you'd like me to test. > > You need "clockevents/drivers/mtk: Fix spurious interrupt leading to > crash" (https://lkml.org/lkml/2015/8/24/803) > > Daniel Lezcano already applied this patch in his tree for 4.4. > (https://git.linaro.org/people/daniel.lezcano/linux.git) > Thanks for letting us know. In the future, these kinds of cross-tree dependencies are important to mention in the cover letter of the pull request so we can setup dependency branches and keep arm-soc/for-next building and booting. Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH v5 4/5] ARM: dts: mt8135: enable basic SMP bringup for mt8135 Date: Thu, 29 Oct 2015 02:12:45 -0700 Message-ID: <7hlhamjawi.fsf@deeprootsystems.com> References: <1443799181-50409-1-git-send-email-yingjoe.chen@mediatek.com> <1443799181-50409-5-git-send-email-yingjoe.chen@mediatek.com> <1445843717.23888.1.camel@mtksdaap41> <1445859610.26723.4.camel@mtksdaap41> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1445859610.26723.4.camel@mtksdaap41> (Eddie Huang's message of "Mon, 26 Oct 2015 19:40:10 +0800") Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Eddie Huang Cc: Yingjoe Chen , "devicetree@vger.kernel.org" , Russell King - ARM Linux , srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, Arnd Bergmann , Tyler Baker , Stephen Boyd , lkml , Olof Johansson , Rob Herring , linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Sascha Hauer , Matthias Brugger , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org Eddie Huang writes: > Hi Kevin, > > On Mon, 2015-10-26 at 17:06 +0900, Kevin Hilman wrote: >> On Mon, Oct 26, 2015 at 4:15 PM, Yingjoe Chen wrote: >> > On Mon, 2015-10-26 at 09:56 +0900, Kevin Hilman wrote: >> >> Hello, >> >> >> >> On Sat, Oct 3, 2015 at 12:19 AM, Yingjoe Chen wrote: >> >> > Add arch timer node to enable arch-timer support. MT8135 firmware >> >> > doesn't correctly setup arch-timer frequency and CNTVOFF, add >> >> > properties to workaround this. >> >> > >> >> > This also set cpu enable-method to enable SMP. >> >> > >> >> > Signed-off-by: Yingjoe Chen >> >> >> >> kernelci.org started detecting new boot failures for the mt8135-evb in >> >> the arm-soc tree[1], and the boot failures were bisected down to this >> >> patch, which landed upstream in the form of commit d186a394bb98 (ARM: >> >> dts: mt8135: enable basic SMP bringup for mt8135) >> >> >> >> Maybe this new SMP support requires updating the firmware on the board >> >> as well? If so, the changelog should've been a bit more explicit >> >> about firmware dependencies. >> > >> > Kevin, >> > >> > Thanks for testing. >> > >> > No, it doesn't need new firmware. Will test to see what's going wrong. >> >> Thanks for following up. I'll be glad to test any patches if you have >> anything you'd like me to test. > > You need "clockevents/drivers/mtk: Fix spurious interrupt leading to > crash" (https://lkml.org/lkml/2015/8/24/803) > > Daniel Lezcano already applied this patch in his tree for 4.4. > (https://git.linaro.org/people/daniel.lezcano/linux.git) > Thanks for letting us know. In the future, these kinds of cross-tree dependencies are important to mention in the cover letter of the pull request so we can setup dependency branches and keep arm-soc/for-next building and booting. Kevin -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@kernel.org (Kevin Hilman) Date: Thu, 29 Oct 2015 02:12:45 -0700 Subject: [PATCH v5 4/5] ARM: dts: mt8135: enable basic SMP bringup for mt8135 In-Reply-To: <1445859610.26723.4.camel@mtksdaap41> (Eddie Huang's message of "Mon, 26 Oct 2015 19:40:10 +0800") References: <1443799181-50409-1-git-send-email-yingjoe.chen@mediatek.com> <1443799181-50409-5-git-send-email-yingjoe.chen@mediatek.com> <1445843717.23888.1.camel@mtksdaap41> <1445859610.26723.4.camel@mtksdaap41> Message-ID: <7hlhamjawi.fsf@deeprootsystems.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Eddie Huang writes: > Hi Kevin, > > On Mon, 2015-10-26 at 17:06 +0900, Kevin Hilman wrote: >> On Mon, Oct 26, 2015 at 4:15 PM, Yingjoe Chen wrote: >> > On Mon, 2015-10-26 at 09:56 +0900, Kevin Hilman wrote: >> >> Hello, >> >> >> >> On Sat, Oct 3, 2015 at 12:19 AM, Yingjoe Chen wrote: >> >> > Add arch timer node to enable arch-timer support. MT8135 firmware >> >> > doesn't correctly setup arch-timer frequency and CNTVOFF, add >> >> > properties to workaround this. >> >> > >> >> > This also set cpu enable-method to enable SMP. >> >> > >> >> > Signed-off-by: Yingjoe Chen >> >> >> >> kernelci.org started detecting new boot failures for the mt8135-evb in >> >> the arm-soc tree[1], and the boot failures were bisected down to this >> >> patch, which landed upstream in the form of commit d186a394bb98 (ARM: >> >> dts: mt8135: enable basic SMP bringup for mt8135) >> >> >> >> Maybe this new SMP support requires updating the firmware on the board >> >> as well? If so, the changelog should've been a bit more explicit >> >> about firmware dependencies. >> > >> > Kevin, >> > >> > Thanks for testing. >> > >> > No, it doesn't need new firmware. Will test to see what's going wrong. >> >> Thanks for following up. I'll be glad to test any patches if you have >> anything you'd like me to test. > > You need "clockevents/drivers/mtk: Fix spurious interrupt leading to > crash" (https://lkml.org/lkml/2015/8/24/803) > > Daniel Lezcano already applied this patch in his tree for 4.4. > (https://git.linaro.org/people/daniel.lezcano/linux.git) > Thanks for letting us know. In the future, these kinds of cross-tree dependencies are important to mention in the cover letter of the pull request so we can setup dependency branches and keep arm-soc/for-next building and booting. Kevin