From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C544C4321E for ; Wed, 12 Oct 2022 17:56:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229676AbiJLR4J (ORCPT ); Wed, 12 Oct 2022 13:56:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229468AbiJLR4G (ORCPT ); Wed, 12 Oct 2022 13:56:06 -0400 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23D9F5C348 for ; Wed, 12 Oct 2022 10:56:03 -0700 (PDT) Received: by mail-pj1-x1031.google.com with SMTP id t10-20020a17090a4e4a00b0020af4bcae10so2766312pjl.3 for ; Wed, 12 Oct 2022 10:56:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=rn/UDIcscu5abOpP3v+WUHTT/jflHG0HmbSWAfN3l54=; b=4uAbc7fbIErK5qUn9SAy5Jkng45r6O6mebcOQfFPXDS9n30sCnvMd2bwu66lRPOFKN XTKsR/xQAfifYS1nMUKITEX9xpFSYVcZMEq/LSWrJAQY6lWma5wLwE4d+OZkYtIe8Or+ 5/uvyXEjFfQmFRVROMktn/nNrZSrQoDJ2fHnzgwti4B/C0sXkDmi2dWoGBl+eEkUBYuy Oo0NLkrKyf7qVI6YWXhdS+9JFEkj22AUtFeB9PIOcx7btBOOqspiVy6ibskfNJ2YzOGd JMd/zxLaLtZkiwscZcR69ubsR4sVifHLLmIY9VtxgMpqfkTFSxER1TCwhm5gOVmWDd/p btXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rn/UDIcscu5abOpP3v+WUHTT/jflHG0HmbSWAfN3l54=; b=2h5tB/drsQx5trjwgunAoIucL/tYpSLg76Q3oUu/nFrJS8xm8qCTC6EjeH9xcLxHwc XoiTNvYvWqoJRedElJWel0HpYOsSQu0D3TR+mnsNFDfdd/3PfDWnJDuL9IfvkFQzxS44 fJtg7qMeqkICz2cM2fr0igL5qP2ts+nSeE+vxKXOl9Ytt9PcOetCw1FnZAz+cVK7lTCp BJAFSnkuJT0jUTQ2ySI43a32m0a8hs9J/4EC6iWi4nxDeF14ZyIL1iGjaoaEWbRbfAg9 BnCMpYY/RgTJXodZOTtl8A1XEH+smSssngZI8snYAxH9+zb+hd8KkUpiVctk3wlZPGMc WBiA== X-Gm-Message-State: ACrzQf2y37pJNuonxK4WvdN29qfj8tXW+Y2VcAEBnCa5Y8B0fXq/0fjM K599Zh6Vo13kklL1g2MZcPRnCQ== X-Google-Smtp-Source: AMsMyM7zr66pcJj/ae8owjpIzOJuITFx/A8rJzNZeOjMKqUvNZKR6cxqEkmXqJO5rLkZ/6ZIhCu+MA== X-Received: by 2002:a17:90b:17cf:b0:20d:72eb:fd0c with SMTP id me15-20020a17090b17cf00b0020d72ebfd0cmr6377751pjb.217.1665597362585; Wed, 12 Oct 2022 10:56:02 -0700 (PDT) Received: from localhost ([75.172.140.17]) by smtp.gmail.com with ESMTPSA id l6-20020a170902f68600b0017f92246e4dsm11047925plg.181.2022.10.12.10.56.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Oct 2022 10:56:01 -0700 (PDT) From: Kevin Hilman To: Krzysztof Kozlowski , jerome Neanne , lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, nm@ti.com, kristo@kernel.org, dmitry.torokhov@gmail.com, krzysztof.kozlowski+dt@linaro.org, catalin.marinas@arm.com, will@kernel.org, lee@kernel.org, tony@atomide.com, vigneshr@ti.com, bjorn.andersson@linaro.org, shawnguo@kernel.org, geert+renesas@glider.be, dmitry.baryshkov@linaro.org, marcel.ziswiler@toradex.com, vkoul@kernel.org, biju.das.jz@bp.renesas.com, arnd@arndb.de, jeff@labundy.com Cc: afd@ti.com, narmstrong@baylibre.com, msp@baylibre.com, j-keerthy@ti.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH v6 6/6] arm64: defconfig: Add tps65219 as modules In-Reply-To: References: <20221011140549.16761-1-jneanne@baylibre.com> <20221011140549.16761-7-jneanne@baylibre.com> <72b9809e-d6d7-862a-26b8-221d14ea4322@linaro.org> <60507e87-cf92-13d9-29d0-83f18a648f4b@baylibre.com> Date: Wed, 12 Oct 2022 10:56:00 -0700 Message-ID: <7hzge1hqof.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Krzysztof Kozlowski writes: > On 12/10/2022 04:39, jerome Neanne wrote: >>> You explained what you did, which is easily visible. You did not explain >>> why you are doing it. >>> >>> Best regards, >>> Krzysztof >>> >> Thanks for pointing me to the detailed guidelines >> I'm new to upstream and not well aware of all good practices. >> >> Would below commit message be more suitable: >> >> Add support for the TPS65219 PMIC by enabling MFD, regulator and >> power-button drivers. All drivers enabled as modules. > > This still says only what you did. I still does not explain why. Jerome, maybe adding a bit of preamble like: "Development boards from TI include the TPS65219 PMIC. Add support..." Krzysztof, I'm the first to argue for descriptive/verbose changelogs, but IMO, this is getting a little bit nit-picky. The series adds a new driver, DTS and defconfig patches to enable support the new driver. The "why" for changes to defconfig changes like this are kind of implied/obvious, and there is lots of precedent for changelogs of defconfig changes for simple drivers to simply say "enable X and Y". If my above suggesion is not enough, please make a suggestion for what you think would qualify as an appropritate changelong that answers "why" for a simple driver change. Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DEA03C433FE for ; Wed, 12 Oct 2022 17:57:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=M0Bz3bD85OaXUrkhqKBhROJAAIO8iGH/A6hPb3UFCUE=; b=M7PpiwDlE5FCK/ Fr9BoxFOxtoUTnZXohmBmWJyL12/iw6KFJH0MO+cHTfg+NhyP96LBD+D+6bPEBmDv7cEBsORI+Dzo khLyomLfdF9P7km/snrInqykPvDhyHkRIyZ5+s6e5wJNVoHwEaLy0pkNYmbPfHG5qfN1BKXTVQm7Q KKNWIV3YK7hx0O0X76Wj5xZTKwXURLk+bqip9A8yn3wvcbrXV6zFzkYE8vneWzAeN2SPQaXkrzUW6 7bNscxJBYkph31oI6Y2OE14UMZf1/svPahd47Nd6V5k4AP4mYVTZkDHWKkvREXz26JbLFJo6TaEta dSxfGTVQvFJInUMutkIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oifxk-008vI4-Ex; Wed, 12 Oct 2022 17:56:12 +0000 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oifxd-008vGs-4b for linux-arm-kernel@lists.infradead.org; Wed, 12 Oct 2022 17:56:10 +0000 Received: by mail-pj1-x1029.google.com with SMTP id l1-20020a17090a72c100b0020a6949a66aso2775049pjk.1 for ; Wed, 12 Oct 2022 10:56:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=rn/UDIcscu5abOpP3v+WUHTT/jflHG0HmbSWAfN3l54=; b=4uAbc7fbIErK5qUn9SAy5Jkng45r6O6mebcOQfFPXDS9n30sCnvMd2bwu66lRPOFKN XTKsR/xQAfifYS1nMUKITEX9xpFSYVcZMEq/LSWrJAQY6lWma5wLwE4d+OZkYtIe8Or+ 5/uvyXEjFfQmFRVROMktn/nNrZSrQoDJ2fHnzgwti4B/C0sXkDmi2dWoGBl+eEkUBYuy Oo0NLkrKyf7qVI6YWXhdS+9JFEkj22AUtFeB9PIOcx7btBOOqspiVy6ibskfNJ2YzOGd JMd/zxLaLtZkiwscZcR69ubsR4sVifHLLmIY9VtxgMpqfkTFSxER1TCwhm5gOVmWDd/p btXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rn/UDIcscu5abOpP3v+WUHTT/jflHG0HmbSWAfN3l54=; b=ZWBM06htmKCUCYu0k22URzjyNkCOQGJR8keyxuvEIHnxtLhFiTDei4dOF2Q+XafYhe e0srnmUVNx2j29v23UwUC58a7viWbD3sUiazia4Q9pqtCGIFWkq/pSd9EZC0KWKDaLwT vf2NmG5yAjdhyvY3N8Djf9FPCP1Vp+OEz7c+wX9uyeyDgeRsk31t7+f00xv71+DPZlpY LEf58KdHWViOyHebUm0N/Yhsor2xw9l1mun3GLwZ5j7widBxbxFKktKLS4GkjWLTb2+K W1A7Wbpc1P6xLu4OWmID6vVvLIdrDWncbR0N9BLR0DMyiPNul9SaBa9x8v0o3WjXRmek y8oQ== X-Gm-Message-State: ACrzQf2HQXGSvMW6gYVKT0yaTbPwXVtlpFEa4L8FQjEqRAJp8p72RsNn ZCKAii0Wg7mkLVSk1T6FKInJNw== X-Google-Smtp-Source: AMsMyM7zr66pcJj/ae8owjpIzOJuITFx/A8rJzNZeOjMKqUvNZKR6cxqEkmXqJO5rLkZ/6ZIhCu+MA== X-Received: by 2002:a17:90b:17cf:b0:20d:72eb:fd0c with SMTP id me15-20020a17090b17cf00b0020d72ebfd0cmr6377751pjb.217.1665597362585; Wed, 12 Oct 2022 10:56:02 -0700 (PDT) Received: from localhost ([75.172.140.17]) by smtp.gmail.com with ESMTPSA id l6-20020a170902f68600b0017f92246e4dsm11047925plg.181.2022.10.12.10.56.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Oct 2022 10:56:01 -0700 (PDT) From: Kevin Hilman To: Krzysztof Kozlowski , jerome Neanne , lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, nm@ti.com, kristo@kernel.org, dmitry.torokhov@gmail.com, krzysztof.kozlowski+dt@linaro.org, catalin.marinas@arm.com, will@kernel.org, lee@kernel.org, tony@atomide.com, vigneshr@ti.com, bjorn.andersson@linaro.org, shawnguo@kernel.org, geert+renesas@glider.be, dmitry.baryshkov@linaro.org, marcel.ziswiler@toradex.com, vkoul@kernel.org, biju.das.jz@bp.renesas.com, arnd@arndb.de, jeff@labundy.com Cc: afd@ti.com, narmstrong@baylibre.com, msp@baylibre.com, j-keerthy@ti.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH v6 6/6] arm64: defconfig: Add tps65219 as modules In-Reply-To: References: <20221011140549.16761-1-jneanne@baylibre.com> <20221011140549.16761-7-jneanne@baylibre.com> <72b9809e-d6d7-862a-26b8-221d14ea4322@linaro.org> <60507e87-cf92-13d9-29d0-83f18a648f4b@baylibre.com> Date: Wed, 12 Oct 2022 10:56:00 -0700 Message-ID: <7hzge1hqof.fsf@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221012_105605_421404_2D855990 X-CRM114-Status: GOOD ( 13.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Krzysztof Kozlowski writes: > On 12/10/2022 04:39, jerome Neanne wrote: >>> You explained what you did, which is easily visible. You did not explain >>> why you are doing it. >>> >>> Best regards, >>> Krzysztof >>> >> Thanks for pointing me to the detailed guidelines >> I'm new to upstream and not well aware of all good practices. >> >> Would below commit message be more suitable: >> >> Add support for the TPS65219 PMIC by enabling MFD, regulator and >> power-button drivers. All drivers enabled as modules. > > This still says only what you did. I still does not explain why. Jerome, maybe adding a bit of preamble like: "Development boards from TI include the TPS65219 PMIC. Add support..." Krzysztof, I'm the first to argue for descriptive/verbose changelogs, but IMO, this is getting a little bit nit-picky. The series adds a new driver, DTS and defconfig patches to enable support the new driver. The "why" for changes to defconfig changes like this are kind of implied/obvious, and there is lots of precedent for changelogs of defconfig changes for simple drivers to simply say "enable X and Y". If my above suggesion is not enough, please make a suggestion for what you think would qualify as an appropritate changelong that answers "why" for a simple driver change. Kevin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel